You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "TaoYang526 (via GitHub)" <gi...@apache.org> on 2023/06/13 09:34:36 UTC
[GitHub] [yunikorn-release] TaoYang526 opened a new pull request, #147: [YUNIKORN-1786] perf-tools build and dependency updates
TaoYang526 opened a new pull request, #147:
URL: https://github.com/apache/yunikorn-release/pull/147
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-release] wilfred-s commented on a diff in pull request #147: [YUNIKORN-1786] perf-tools build and dependency updates
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s commented on code in PR #147:
URL: https://github.com/apache/yunikorn-release/pull/147#discussion_r1231816205
##########
go.mod:
##########
@@ -22,59 +22,63 @@ go 1.20
require (
github.com/TaoYang526/goutils v0.0.0-20210209083921-039008f0a57d
- github.com/apache/yunikorn-core v0.0.0-20220325135453-73d55282f052
- github.com/mitchellh/mapstructure v1.1.2
- github.com/olekukonko/tablewriter v0.0.0-20170122224234-a0225b3f23b5
+ github.com/apache/yunikorn-core v0.0.0-20230609084156-d2d7ce89457c
+ github.com/apache/yunikorn-scheduler-interface v0.0.0-20230517151935-1714a5751931
+ github.com/mitchellh/mapstructure v1.5.0
+ github.com/olekukonko/tablewriter v0.0.5
go.uber.org/zap v1.24.0
- gonum.org/v1/plot v0.9.0
- gopkg.in/yaml.v2 v2.2.8
+ gonum.org/v1/plot v0.13.0
+ gopkg.in/yaml.v2 v2.4.0
Review Comment:
Should we not move to `yaml.v3` ? The last time `yaml.v2` got updated was 3 years ago.
##########
go.mod:
##########
@@ -22,59 +22,63 @@ go 1.20
require (
github.com/TaoYang526/goutils v0.0.0-20210209083921-039008f0a57d
- github.com/apache/yunikorn-core v0.0.0-20220325135453-73d55282f052
- github.com/mitchellh/mapstructure v1.1.2
- github.com/olekukonko/tablewriter v0.0.0-20170122224234-a0225b3f23b5
+ github.com/apache/yunikorn-core v0.0.0-20230609084156-d2d7ce89457c
+ github.com/apache/yunikorn-scheduler-interface v0.0.0-20230517151935-1714a5751931
+ github.com/mitchellh/mapstructure v1.5.0
+ github.com/olekukonko/tablewriter v0.0.5
go.uber.org/zap v1.24.0
- gonum.org/v1/plot v0.9.0
- gopkg.in/yaml.v2 v2.2.8
+ gonum.org/v1/plot v0.13.0
+ gopkg.in/yaml.v2 v2.4.0
gotest.tools v2.2.0+incompatible
Review Comment:
Same here: we have moved to `gotest.tools/v3` everywhere in our repositories
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [YUNIKORN-1786] perf-tools build and dependency updates [yunikorn-release]
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s closed pull request #147: [YUNIKORN-1786] perf-tools build and dependency updates
URL: https://github.com/apache/yunikorn-release/pull/147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-release] wilfred-s commented on pull request #147: [YUNIKORN-1786] perf-tools build and dependency updates
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s commented on PR #147:
URL: https://github.com/apache/yunikorn-release/pull/147#issuecomment-1601830301
the yaml dependency has been handled in #149, just leaves the gotools change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org