You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by ilya musayev <il...@cloudsand.com> on 2013/06/13 01:54:04 UTC
Re: Review Request: CLOUDSTACK-2053: fixed if/else logic to address
redundant entires,
fixed boto/cloud-init support by adding metadata rewrite rule
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11582/
-----------------------------------------------------------
(Updated June 12, 2013, 11:54 p.m.)
Review request for cloudstack, Chip Childers and Chiradeep Vittal.
Changes
-------
return $result was set too early skipping the code below it, fixed it by placing at the bottom of the function.
Description
-------
Resubmitting for the 3rd time, as review board crashed on my submissions previously
Rewrote the bash if/else check to fix redundant entries
Added RewriteRules to support boto/cloud-init - as per Chiradeep - this would only affect
VMWare deployments, as this userdata.sh script is only used with vmware system router vms
This addresses bug CLOUDSTACK-2053.
Diffs (updated)
-----
patches/systemvm/debian/config/root/userdata.sh e5d170b
Diff: https://reviews.apache.org/r/11582/diff/
Testing
-------
4.1 with vSphere
Thanks,
ilya musayev
Re: Review Request 11582: CLOUDSTACK-2053: fixed if/else logic to address
redundant entires,
fixed boto/cloud-init support by adding metadata rewrite rule
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11582/#review23511
-----------------------------------------------------------
Commit 88b36edf87140692861f00da05f3fa8955340c80 in branch refs/heads/4.2 from ilya musayev
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=88b36ed ]
CLOUDSTACK-2053: Fixed userdata.sh redundancy and cloud-init support
- ASF Subversion and Git Services
On June 12, 2013, 11:54 p.m., ilya musayev wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11582/
> -----------------------------------------------------------
>
> (Updated June 12, 2013, 11:54 p.m.)
>
>
> Review request for cloudstack, Chip Childers and Chiradeep Vittal.
>
>
> Bugs: CLOUDSTACK-2053
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Resubmitting for the 3rd time, as review board crashed on my submissions previously
>
> Rewrote the bash if/else check to fix redundant entries
> Added RewriteRules to support boto/cloud-init - as per Chiradeep - this would only affect
> VMWare deployments, as this userdata.sh script is only used with vmware system router vms
>
>
> Diffs
> -----
>
> patches/systemvm/debian/config/root/userdata.sh e5d170b
>
> Diff: https://reviews.apache.org/r/11582/diff/
>
>
> Testing
> -------
>
> 4.1 with vSphere
>
>
> Thanks,
>
> ilya musayev
>
>
Re: Review Request: CLOUDSTACK-2053: fixed if/else logic to address
redundant entires,
fixed boto/cloud-init support by adding metadata rewrite rule
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11582/#review21883
-----------------------------------------------------------
Commit 4612656de86a4a0258852c3fb89724bda6b612b3 in branch refs/heads/4.1 from ilya musayev
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4612656 ]
CLOUDSTACK-2053: Fixed userdata.sh redundancy and cloud-init support
- ASF Subversion and Git Services
On June 12, 2013, 11:54 p.m., ilya musayev wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11582/
> -----------------------------------------------------------
>
> (Updated June 12, 2013, 11:54 p.m.)
>
>
> Review request for cloudstack, Chip Childers and Chiradeep Vittal.
>
>
> Description
> -------
>
> Resubmitting for the 3rd time, as review board crashed on my submissions previously
>
> Rewrote the bash if/else check to fix redundant entries
> Added RewriteRules to support boto/cloud-init - as per Chiradeep - this would only affect
> VMWare deployments, as this userdata.sh script is only used with vmware system router vms
>
>
> This addresses bug CLOUDSTACK-2053.
>
>
> Diffs
> -----
>
> patches/systemvm/debian/config/root/userdata.sh e5d170b
>
> Diff: https://reviews.apache.org/r/11582/diff/
>
>
> Testing
> -------
>
> 4.1 with vSphere
>
>
> Thanks,
>
> ilya musayev
>
>
Re: Review Request 11582: CLOUDSTACK-2053: fixed if/else logic to address
redundant entires,
fixed boto/cloud-init support by adding metadata rewrite rule
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11582/#review23507
-----------------------------------------------------------
Commit eb3ffef95ae493df94df97639fdf8c1a4cd8410f in branch refs/heads/master from ilya musayev
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=eb3ffef ]
CLOUDSTACK-2053: Fixed userdata.sh redundancy and cloud-init support
- ASF Subversion and Git Services
On June 12, 2013, 11:54 p.m., ilya musayev wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11582/
> -----------------------------------------------------------
>
> (Updated June 12, 2013, 11:54 p.m.)
>
>
> Review request for cloudstack, Chip Childers and Chiradeep Vittal.
>
>
> Bugs: CLOUDSTACK-2053
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Resubmitting for the 3rd time, as review board crashed on my submissions previously
>
> Rewrote the bash if/else check to fix redundant entries
> Added RewriteRules to support boto/cloud-init - as per Chiradeep - this would only affect
> VMWare deployments, as this userdata.sh script is only used with vmware system router vms
>
>
> Diffs
> -----
>
> patches/systemvm/debian/config/root/userdata.sh e5d170b
>
> Diff: https://reviews.apache.org/r/11582/diff/
>
>
> Testing
> -------
>
> 4.1 with vSphere
>
>
> Thanks,
>
> ilya musayev
>
>
Re: Review Request 11582: CLOUDSTACK-2053: fixed if/else logic to address
redundant entires,
fixed boto/cloud-init support by adding metadata rewrite rule
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11582/#review23513
-----------------------------------------------------------
Commit 8f4b9bccfed63a37762907bdd058506f4e7b6e6d in branch refs/heads/4.0 from ilya musayev
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8f4b9bc ]
CLOUDSTACK-2053: Fixed userdata.sh redundancy and cloud-init support
- ASF Subversion and Git Services
On June 12, 2013, 11:54 p.m., ilya musayev wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11582/
> -----------------------------------------------------------
>
> (Updated June 12, 2013, 11:54 p.m.)
>
>
> Review request for cloudstack, Chip Childers and Chiradeep Vittal.
>
>
> Bugs: CLOUDSTACK-2053
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Resubmitting for the 3rd time, as review board crashed on my submissions previously
>
> Rewrote the bash if/else check to fix redundant entries
> Added RewriteRules to support boto/cloud-init - as per Chiradeep - this would only affect
> VMWare deployments, as this userdata.sh script is only used with vmware system router vms
>
>
> Diffs
> -----
>
> patches/systemvm/debian/config/root/userdata.sh e5d170b
>
> Diff: https://reviews.apache.org/r/11582/diff/
>
>
> Testing
> -------
>
> 4.1 with vSphere
>
>
> Thanks,
>
> ilya musayev
>
>