You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Isabel Jimenez <co...@isabeljimenez.com> on 2015/11/03 18:58:19 UTC
Review Request 39908: Added a section to Upgrades doc
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
Added mention to Credential protobuf change in 0.26 in uprades.md
Diffs
-----
docs/upgrades.md 3854e59
Diff: https://reviews.apache.org/r/39908/diff/
Testing
-------
Thanks,
Isabel Jimenez
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/#review104955
-----------------------------------------------------------
Ship it!
Modulo Neil's comment.
- Michael Park
On Nov. 3, 2015, 6 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39908/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 6 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3560
> https://issues.apache.org/jira/browse/MESOS-3560
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention to Credential protobuf change in 0.26 in uprades.md
>
>
> Diffs
> -----
>
> docs/upgrades.md 3854e59
>
> Diff: https://reviews.apache.org/r/39908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
> On Nov. 3, 2015, 7:21 p.m., Neil Conway wrote:
> > docs/upgrades.md, line 16
> > <https://reviews.apache.org/r/39908/diff/1/?file=1114771#file1114771line16>
> >
> > AFAIK this isn't Java-specific.
>
> Isabel Jimenez wrote:
> This will mostly impact Java frameworks since they'll have to not only update the generated protos but change their framework code. See:
> https://github.com/apache/mesos/commit/38dbadc944f56e24725fba102bbd2db76cb31228#diff-2ca9e1a2a6f66a790bbbfae40708ecfaL249
>
> Neil Conway wrote:
> Sorry, I'm still confused: updating the generated protos will require changes to framework code (if your framework examines the `secret` field), regardless of language. e.g., the type of the field has changed from []byte to string in the Go generated code.
True, let me remove the language specificity.
- Isabel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/#review104953
-----------------------------------------------------------
On Nov. 3, 2015, 6 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39908/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 6 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3560
> https://issues.apache.org/jira/browse/MESOS-3560
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention to Credential protobuf change in 0.26 in uprades.md
>
>
> Diffs
> -----
>
> docs/upgrades.md 3854e59
>
> Diff: https://reviews.apache.org/r/39908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Neil Conway <ne...@gmail.com>.
> On Nov. 3, 2015, 7:21 p.m., Neil Conway wrote:
> > docs/upgrades.md, line 16
> > <https://reviews.apache.org/r/39908/diff/1/?file=1114771#file1114771line16>
> >
> > AFAIK this isn't Java-specific.
>
> Isabel Jimenez wrote:
> This will mostly impact Java frameworks since they'll have to not only update the generated protos but change their framework code. See:
> https://github.com/apache/mesos/commit/38dbadc944f56e24725fba102bbd2db76cb31228#diff-2ca9e1a2a6f66a790bbbfae40708ecfaL249
Sorry, I'm still confused: updating the generated protos will require changes to framework code (if your framework examines the `secret` field), regardless of language. e.g., the type of the field has changed from []byte to string in the Go generated code.
- Neil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/#review104953
-----------------------------------------------------------
On Nov. 3, 2015, 6 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39908/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 6 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3560
> https://issues.apache.org/jira/browse/MESOS-3560
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention to Credential protobuf change in 0.26 in uprades.md
>
>
> Diffs
> -----
>
> docs/upgrades.md 3854e59
>
> Diff: https://reviews.apache.org/r/39908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
> On Nov. 3, 2015, 7:21 p.m., Neil Conway wrote:
> > docs/upgrades.md, line 16
> > <https://reviews.apache.org/r/39908/diff/1/?file=1114771#file1114771line16>
> >
> > AFAIK this isn't Java-specific.
This will mostly impact Java frameworks since they'll have to not only update the generated protos but change their framework code. See:
https://github.com/apache/mesos/commit/38dbadc944f56e24725fba102bbd2db76cb31228#diff-2ca9e1a2a6f66a790bbbfae40708ecfaL249
- Isabel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/#review104953
-----------------------------------------------------------
On Nov. 3, 2015, 6 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39908/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 6 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3560
> https://issues.apache.org/jira/browse/MESOS-3560
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention to Credential protobuf change in 0.26 in uprades.md
>
>
> Diffs
> -----
>
> docs/upgrades.md 3854e59
>
> Diff: https://reviews.apache.org/r/39908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/#review104953
-----------------------------------------------------------
docs/upgrades.md (line 16)
<https://reviews.apache.org/r/39908/#comment163307>
AFAIK this isn't Java-specific.
- Neil Conway
On Nov. 3, 2015, 6 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39908/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 6 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3560
> https://issues.apache.org/jira/browse/MESOS-3560
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention to Credential protobuf change in 0.26 in uprades.md
>
>
> Diffs
> -----
>
> docs/upgrades.md 3854e59
>
> Diff: https://reviews.apache.org/r/39908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/#review104950
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39908]
All tests passed.
- Mesos ReviewBot
On Nov. 3, 2015, 6 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39908/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 6 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3560
> https://issues.apache.org/jira/browse/MESOS-3560
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention to Credential protobuf change in 0.26 in uprades.md
>
>
> Diffs
> -----
>
> docs/upgrades.md 3854e59
>
> Diff: https://reviews.apache.org/r/39908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/#review105011
-----------------------------------------------------------
CHANGELOG (lines 1 - 8)
<https://reviews.apache.org/r/39908/#comment163372>
Please rebase based on https://reviews.apache.org/r/39922/
- Guangya Liu
On 十一月 3, 2015, 11:51 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39908/
> -----------------------------------------------------------
>
> (Updated 十一月 3, 2015, 11:51 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3560
> https://issues.apache.org/jira/browse/MESOS-3560
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention to Credential protobuf change in 0.26 in uprades.md
>
>
> Diffs
> -----
>
> CHANGELOG 99d8882
> docs/upgrades.md 3854e59
>
> Diff: https://reviews.apache.org/r/39908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/#review105022
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39908]
All tests passed.
- Mesos ReviewBot
On Nov. 4, 2015, 12:14 a.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39908/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2015, 12:14 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3560
> https://issues.apache.org/jira/browse/MESOS-3560
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention to Credential protobuf change in 0.26 in uprades.md
>
>
> Diffs
> -----
>
> CHANGELOG 75f7355
> docs/upgrades.md 3854e59
>
> Diff: https://reviews.apache.org/r/39908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/#review105014
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 十一月 4, 2015, 12:14 a.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39908/
> -----------------------------------------------------------
>
> (Updated 十一月 4, 2015, 12:14 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3560
> https://issues.apache.org/jira/browse/MESOS-3560
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention to Credential protobuf change in 0.26 in uprades.md
>
>
> Diffs
> -----
>
> CHANGELOG 75f7355
> docs/upgrades.md 3854e59
>
> Diff: https://reviews.apache.org/r/39908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/
-----------------------------------------------------------
(Updated Nov. 4, 2015, 12:14 a.m.)
Review request for mesos and Michael Park.
Changes
-------
rebase
Bugs: MESOS-3560
https://issues.apache.org/jira/browse/MESOS-3560
Repository: mesos
Description
-------
Added mention to Credential protobuf change in 0.26 in uprades.md
Diffs (updated)
-----
CHANGELOG 75f7355
docs/upgrades.md 3854e59
Diff: https://reviews.apache.org/r/39908/diff/
Testing
-------
Thanks,
Isabel Jimenez
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/
-----------------------------------------------------------
(Updated Nov. 3, 2015, 11:51 p.m.)
Review request for mesos and Michael Park.
Bugs: MESOS-3560
https://issues.apache.org/jira/browse/MESOS-3560
Repository: mesos
Description
-------
Added mention to Credential protobuf change in 0.26 in uprades.md
Diffs (updated)
-----
CHANGELOG 99d8882
docs/upgrades.md 3854e59
Diff: https://reviews.apache.org/r/39908/diff/
Testing
-------
Thanks,
Isabel Jimenez
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/#review105009
-----------------------------------------------------------
docs/upgrades.md (line 16)
<https://reviews.apache.org/r/39908/#comment163365>
I think you should identify that only JSON format is affected?
- Guangya Liu
On 十一月 3, 2015, 11:41 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39908/
> -----------------------------------------------------------
>
> (Updated 十一月 3, 2015, 11:41 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3560
> https://issues.apache.org/jira/browse/MESOS-3560
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention to Credential protobuf change in 0.26 in uprades.md
>
>
> Diffs
> -----
>
> CHANGELOG 99d8882
> docs/upgrades.md 3854e59
>
> Diff: https://reviews.apache.org/r/39908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/
-----------------------------------------------------------
(Updated Nov. 3, 2015, 11:41 p.m.)
Review request for mesos and Michael Park.
Bugs: MESOS-3560
https://issues.apache.org/jira/browse/MESOS-3560
Repository: mesos
Description
-------
Added mention to Credential protobuf change in 0.26 in uprades.md
Diffs (updated)
-----
CHANGELOG 99d8882
docs/upgrades.md 3854e59
Diff: https://reviews.apache.org/r/39908/diff/
Testing
-------
Thanks,
Isabel Jimenez
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/#review105000
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39908]
All tests passed.
- Mesos ReviewBot
On Nov. 3, 2015, 10:30 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39908/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 10:30 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3560
> https://issues.apache.org/jira/browse/MESOS-3560
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention to Credential protobuf change in 0.26 in uprades.md
>
>
> Diffs
> -----
>
> CHANGELOG 99d8882
> docs/upgrades.md 3854e59
>
> Diff: https://reviews.apache.org/r/39908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
> On Nov. 3, 2015, 11:33 p.m., Guangya Liu wrote:
> > CHANGELOG, line 4
> > <https://reviews.apache.org/r/39908/diff/4/?file=1115243#file1115243line4>
> >
> > Why not put this to `Bug` catalog?
As this is an API breaking change we prefered to refer to it under 'API changes' even if the JIRA type is orgininally a bug
- Isabel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/#review105002
-----------------------------------------------------------
On Nov. 3, 2015, 10:30 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39908/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 10:30 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3560
> https://issues.apache.org/jira/browse/MESOS-3560
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention to Credential protobuf change in 0.26 in uprades.md
>
>
> Diffs
> -----
>
> CHANGELOG 99d8882
> docs/upgrades.md 3854e59
>
> Diff: https://reviews.apache.org/r/39908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
> On Nov. 3, 2015, 11:33 p.m., Guangya Liu wrote:
> > CHANGELOG, line 1
> > <https://reviews.apache.org/r/39908/diff/4/?file=1115243#file1115243line1>
> >
> > s/Version 0.26.0/Version 0.26.0(WIP)
>
> Isabel Jimenez wrote:
> This are the release notes, so they apply only for releases. No need to specify WIP
>
> Guangya Liu wrote:
> The CHANGELOG for 0.26.0 was not finished, I think that we put a `WIP` here and remove it when release 0.26.0, thoughts? Thanks.
My bad, I will specify WIP.
- Isabel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/#review105002
-----------------------------------------------------------
On Nov. 3, 2015, 10:30 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39908/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 10:30 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3560
> https://issues.apache.org/jira/browse/MESOS-3560
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention to Credential protobuf change in 0.26 in uprades.md
>
>
> Diffs
> -----
>
> CHANGELOG 99d8882
> docs/upgrades.md 3854e59
>
> Diff: https://reviews.apache.org/r/39908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
> On Nov. 3, 2015, 11:33 p.m., Guangya Liu wrote:
> > CHANGELOG, line 1
> > <https://reviews.apache.org/r/39908/diff/4/?file=1115243#file1115243line1>
> >
> > s/Version 0.26.0/Version 0.26.0(WIP)
This are the release notes, so they apply only for releases. No need to specify WIP
- Isabel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/#review105002
-----------------------------------------------------------
On Nov. 3, 2015, 10:30 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39908/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 10:30 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3560
> https://issues.apache.org/jira/browse/MESOS-3560
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention to Credential protobuf change in 0.26 in uprades.md
>
>
> Diffs
> -----
>
> CHANGELOG 99d8882
> docs/upgrades.md 3854e59
>
> Diff: https://reviews.apache.org/r/39908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Guangya Liu <gy...@gmail.com>.
> On 十一月 3, 2015, 11:33 p.m., Guangya Liu wrote:
> > CHANGELOG, line 1
> > <https://reviews.apache.org/r/39908/diff/4/?file=1115243#file1115243line1>
> >
> > s/Version 0.26.0/Version 0.26.0(WIP)
>
> Isabel Jimenez wrote:
> This are the release notes, so they apply only for releases. No need to specify WIP
The CHANGELOG for 0.26.0 was not finished, I think that we put a `WIP` here and remove it when release 0.26.0, thoughts? Thanks.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/#review105002
-----------------------------------------------------------
On 十一月 3, 2015, 10:30 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39908/
> -----------------------------------------------------------
>
> (Updated 十一月 3, 2015, 10:30 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3560
> https://issues.apache.org/jira/browse/MESOS-3560
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention to Credential protobuf change in 0.26 in uprades.md
>
>
> Diffs
> -----
>
> CHANGELOG 99d8882
> docs/upgrades.md 3854e59
>
> Diff: https://reviews.apache.org/r/39908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/#review105002
-----------------------------------------------------------
CHANGELOG (line 1)
<https://reviews.apache.org/r/39908/#comment163358>
s/Version 0.26.0/Version 0.26.0(WIP)
CHANGELOG (line 4)
<https://reviews.apache.org/r/39908/#comment163359>
Why not put this to `Bug` catalog?
- Guangya Liu
On 十一月 3, 2015, 10:30 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39908/
> -----------------------------------------------------------
>
> (Updated 十一月 3, 2015, 10:30 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3560
> https://issues.apache.org/jira/browse/MESOS-3560
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention to Credential protobuf change in 0.26 in uprades.md
>
>
> Diffs
> -----
>
> CHANGELOG 99d8882
> docs/upgrades.md 3854e59
>
> Diff: https://reviews.apache.org/r/39908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/
-----------------------------------------------------------
(Updated Nov. 3, 2015, 10:30 p.m.)
Review request for mesos and Michael Park.
Bugs: MESOS-3560
https://issues.apache.org/jira/browse/MESOS-3560
Repository: mesos
Description
-------
Added mention to Credential protobuf change in 0.26 in uprades.md
Diffs (updated)
-----
CHANGELOG 99d8882
docs/upgrades.md 3854e59
Diff: https://reviews.apache.org/r/39908/diff/
Testing
-------
Thanks,
Isabel Jimenez
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/
-----------------------------------------------------------
(Updated Nov. 3, 2015, 10:23 p.m.)
Review request for mesos and Michael Park.
Changes
-------
Added CHANGELOG section and removed a trailing space
Bugs: MESOS-3560
https://issues.apache.org/jira/browse/MESOS-3560
Repository: mesos
Description
-------
Added mention to Credential protobuf change in 0.26 in uprades.md
Diffs (updated)
-----
CHANGELOG 99d8882
docs/upgrades.md 3854e59
Diff: https://reviews.apache.org/r/39908/diff/
Testing
-------
Thanks,
Isabel Jimenez
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Michael Park <mc...@gmail.com>.
> On Nov. 3, 2015, 8:06 p.m., Vinod Kone wrote:
> > docs/upgrades.md, line 16
> > <https://reviews.apache.org/r/39908/diff/2/?file=1114943#file1114943line16>
> >
> > this should also be mentioned in the CHANGELOG.
>
> Michael Park wrote:
> The CHANGELOG will be created by the release managers for 0.26.0 (Bernd and Till) right? I understand we'll want to make sure this is included in the CHANGELOG for 0.26.0 once it is introduced. Do you think we need to block this patch for it?
>
> Vinod Kone wrote:
> We typically update CHANGELOG whenever we make API/incompatible changes. That way we don't lose track of this stuff when the release time comes around. While Release Managers do a sanity check and dump the JIRA ticket list, it would be great if we can help them out whenever we can. This is the same reason we ask people to add stuff to "upgrades" asap instead of waiting till the release cycle.
Got it, thanks! Isabel, let's include the CHANGELOG changes in this patch?
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/#review104967
-----------------------------------------------------------
On Nov. 3, 2015, 7:52 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39908/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 7:52 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3560
> https://issues.apache.org/jira/browse/MESOS-3560
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention to Credential protobuf change in 0.26 in uprades.md
>
>
> Diffs
> -----
>
> docs/upgrades.md 3854e59
>
> Diff: https://reviews.apache.org/r/39908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Michael Park <mc...@gmail.com>.
> On Nov. 3, 2015, 8:06 p.m., Vinod Kone wrote:
> > docs/upgrades.md, line 16
> > <https://reviews.apache.org/r/39908/diff/2/?file=1114943#file1114943line16>
> >
> > this should also be mentioned in the CHANGELOG.
The CHANGELOG will be created by the release managers for 0.26.0 (Bernd and Till) right? I understand we'll want to make sure this is included in the CHANGELOG for 0.26.0 once it is introduced. Do you think we need to block this patch for it?
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/#review104967
-----------------------------------------------------------
On Nov. 3, 2015, 7:52 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39908/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 7:52 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3560
> https://issues.apache.org/jira/browse/MESOS-3560
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention to Credential protobuf change in 0.26 in uprades.md
>
>
> Diffs
> -----
>
> docs/upgrades.md 3854e59
>
> Diff: https://reviews.apache.org/r/39908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Vinod Kone <vi...@gmail.com>.
> On Nov. 3, 2015, 8:06 p.m., Vinod Kone wrote:
> > docs/upgrades.md, line 16
> > <https://reviews.apache.org/r/39908/diff/2/?file=1114943#file1114943line16>
> >
> > this should also be mentioned in the CHANGELOG.
>
> Michael Park wrote:
> The CHANGELOG will be created by the release managers for 0.26.0 (Bernd and Till) right? I understand we'll want to make sure this is included in the CHANGELOG for 0.26.0 once it is introduced. Do you think we need to block this patch for it?
We typically update CHANGELOG whenever we make API/incompatible changes. That way we don't lose track of this stuff when the release time comes around. While Release Managers do a sanity check and dump the JIRA ticket list, it would be great if we can help them out whenever we can. This is the same reason we ask people to add stuff to "upgrades" asap instead of waiting till the release cycle.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/#review104967
-----------------------------------------------------------
On Nov. 3, 2015, 7:52 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39908/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 7:52 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3560
> https://issues.apache.org/jira/browse/MESOS-3560
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention to Credential protobuf change in 0.26 in uprades.md
>
>
> Diffs
> -----
>
> docs/upgrades.md 3854e59
>
> Diff: https://reviews.apache.org/r/39908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/#review104967
-----------------------------------------------------------
docs/upgrades.md (line 16)
<https://reviews.apache.org/r/39908/#comment163320>
this should also be mentioned in the CHANGELOG.
- Vinod Kone
On Nov. 3, 2015, 7:52 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39908/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 7:52 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3560
> https://issues.apache.org/jira/browse/MESOS-3560
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added mention to Credential protobuf change in 0.26 in uprades.md
>
>
> Diffs
> -----
>
> docs/upgrades.md 3854e59
>
> Diff: https://reviews.apache.org/r/39908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/
-----------------------------------------------------------
(Updated Nov. 3, 2015, 7:52 p.m.)
Review request for mesos and Michael Park.
Bugs: MESOS-3560
https://issues.apache.org/jira/browse/MESOS-3560
Repository: mesos
Description
-------
Added mention to Credential protobuf change in 0.26 in uprades.md
Diffs (updated)
-----
docs/upgrades.md 3854e59
Diff: https://reviews.apache.org/r/39908/diff/
Testing
-------
Thanks,
Isabel Jimenez
Re: Review Request 39908: Added a section to Upgrades doc
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39908/
-----------------------------------------------------------
(Updated Nov. 3, 2015, 6 p.m.)
Review request for mesos and Michael Park.
Bugs: MESOS-3560
https://issues.apache.org/jira/browse/MESOS-3560
Repository: mesos
Description
-------
Added mention to Credential protobuf change in 0.26 in uprades.md
Diffs
-----
docs/upgrades.md 3854e59
Diff: https://reviews.apache.org/r/39908/diff/
Testing
-------
Thanks,
Isabel Jimenez