You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Oleg Gusakov (JIRA)" <ji...@codehaus.org> on 2009/01/06 21:27:19 UTC
[jira] Created: (MNG-3973) MavenDependencyProcessor does not throw
an Exception when parent pom not found
MavenDependencyProcessor does not throw an Exception when parent pom not found
------------------------------------------------------------------------------
Key: MNG-3973
URL: http://jira.codehaus.org/browse/MNG-3973
Project: Maven 2
Issue Type: Bug
Affects Versions: 3.0-alpha-1
Reporter: Oleg Gusakov
Please indicate all problems like this with DependencyProcessorException or re-throw MetadataReaderException if it was thrown in a reader callback.
Currently - MavenDependencyProcessor logs a warning and moves on
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3973) MavenDependencyProcessor does not
throw an Exception when parent pom not found
Posted by "Oleg Gusakov (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=160436#action_160436 ]
Oleg Gusakov commented on MNG-3973:
-----------------------------------
traced it to getParentsOfDomainModel( domainModel, mdReader ) returning null when parent POM is not available
Please process all possible nulls gracefully - now I simply get back an NPE, which does not mean too much
> MavenDependencyProcessor does not throw an Exception when parent pom not found
> ------------------------------------------------------------------------------
>
> Key: MNG-3973
> URL: http://jira.codehaus.org/browse/MNG-3973
> Project: Maven 2
> Issue Type: Bug
> Affects Versions: 3.0-alpha-1
> Reporter: Oleg Gusakov
> Assignee: Shane Isbell
> Fix For: 3.0-alpha-2
>
>
> Please indicate all problems like this with DependencyProcessorException or re-throw MetadataReaderException if it was thrown in a reader callback.
> Currently - MavenDependencyProcessor logs a warning and moves on
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MNG-3973) MavenDependencyProcessor
does not throw an Exception when parent pom not found
Posted by "Oleg Gusakov (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=160447#action_160447 ]
Oleg Gusakov edited comment on MNG-3973 at 1/9/09 12:17 AM:
------------------------------------------------------------
fixed parent NPE in r732937.
There might be others - code needs a review for correct processing of erroneous conditions
was (Author: olle):
fixed parent NPE in r732937.
There might be others - code need a review for correct processing of erroneous conditions
> MavenDependencyProcessor does not throw an Exception when parent pom not found
> ------------------------------------------------------------------------------
>
> Key: MNG-3973
> URL: http://jira.codehaus.org/browse/MNG-3973
> Project: Maven 2
> Issue Type: Bug
> Affects Versions: 3.0-alpha-1
> Reporter: Oleg Gusakov
> Assignee: Shane Isbell
> Fix For: 3.0-alpha-2
>
>
> Please indicate all problems like this with DependencyProcessorException or re-throw MetadataReaderException if it was thrown in a reader callback.
> Currently - MavenDependencyProcessor logs a warning and moves on
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MNG-3973) MavenDependencyProcessor does not throw
an Exception when parent pom not found
Posted by "Shane Isbell (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shane Isbell closed MNG-3973.
-----------------------------
Resolution: Fixed
Went through the code. Looks like there was one other place where mdReader could return null or empty bytes. Added a check for this.
> MavenDependencyProcessor does not throw an Exception when parent pom not found
> ------------------------------------------------------------------------------
>
> Key: MNG-3973
> URL: http://jira.codehaus.org/browse/MNG-3973
> Project: Maven 2
> Issue Type: Bug
> Affects Versions: 3.0-alpha-1
> Reporter: Oleg Gusakov
> Assignee: Shane Isbell
> Fix For: 3.0-alpha-2
>
>
> Please indicate all problems like this with DependencyProcessorException or re-throw MetadataReaderException if it was thrown in a reader callback.
> Currently - MavenDependencyProcessor logs a warning and moves on
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3973) MavenDependencyProcessor does not
throw an Exception when parent pom not found
Posted by "Oleg Gusakov (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=160447#action_160447 ]
Oleg Gusakov commented on MNG-3973:
-----------------------------------
fixed parent NPE in r732937.
There might be others - code need a review for correct processing of erroneous conditions
> MavenDependencyProcessor does not throw an Exception when parent pom not found
> ------------------------------------------------------------------------------
>
> Key: MNG-3973
> URL: http://jira.codehaus.org/browse/MNG-3973
> Project: Maven 2
> Issue Type: Bug
> Affects Versions: 3.0-alpha-1
> Reporter: Oleg Gusakov
> Assignee: Shane Isbell
> Fix For: 3.0-alpha-2
>
>
> Please indicate all problems like this with DependencyProcessorException or re-throw MetadataReaderException if it was thrown in a reader callback.
> Currently - MavenDependencyProcessor logs a warning and moves on
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3973) MavenDependencyProcessor does not
throw an Exception when parent pom not found
Posted by "Shane Isbell (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=160221#action_160221 ]
Shane Isbell commented on MNG-3973:
-----------------------------------
Definitely need more information. The MavenDependencyProcessor just throws exceptions, it has no logging. It also doesn't swallow any exceptions.
> MavenDependencyProcessor does not throw an Exception when parent pom not found
> ------------------------------------------------------------------------------
>
> Key: MNG-3973
> URL: http://jira.codehaus.org/browse/MNG-3973
> Project: Maven 2
> Issue Type: Bug
> Affects Versions: 3.0-alpha-1
> Reporter: Oleg Gusakov
> Assignee: Shane Isbell
> Fix For: 3.0-alpha-2
>
>
> Please indicate all problems like this with DependencyProcessorException or re-throw MetadataReaderException if it was thrown in a reader callback.
> Currently - MavenDependencyProcessor logs a warning and moves on
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3973) MavenDependencyProcessor does not throw
an Exception when parent pom not found
Posted by "Oleg Gusakov (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Gusakov updated MNG-3973:
------------------------------
Assignee: Shane Isbell
Fix Version/s: 3.0-alpha-2
> MavenDependencyProcessor does not throw an Exception when parent pom not found
> ------------------------------------------------------------------------------
>
> Key: MNG-3973
> URL: http://jira.codehaus.org/browse/MNG-3973
> Project: Maven 2
> Issue Type: Bug
> Affects Versions: 3.0-alpha-1
> Reporter: Oleg Gusakov
> Assignee: Shane Isbell
> Fix For: 3.0-alpha-2
>
>
> Please indicate all problems like this with DependencyProcessorException or re-throw MetadataReaderException if it was thrown in a reader callback.
> Currently - MavenDependencyProcessor logs a warning and moves on
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira