You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "wattt3 (via GitHub)" <gi...@apache.org> on 2026/05/31 12:49:13 UTC
[PR] [test] fix flaky testRebalanceWithRemoteLog [fluss]
wattt3 opened a new pull request, #3409:
URL: https://github.com/apache/fluss/pull/3409
<!--
*Thank you very much for contributing to Fluss - we are happy that you want to help us improve Fluss. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub issue](https://github.com/apache/fluss/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no issue.
- Name the pull request in the format "[component] Title of the pull request", where *[component]* should be replaced by the name of the component being changed. Typically, this corresponds to the component label assigned to the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are unsure about which is the best component.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes.
- Each pull request should address only one issue, not mix up code from multiple issues.
- **Generative AI disclosure:** Indicate whether generative AI tools were used in authoring this PR. If yes, specify the tool below.
- [ ] No generative AI tools used
- [ ] Yes (please specify the tool below)
**(The sections below can be removed for hotfixes or typos)**
-->
<!--
Generated-by: [Tool Name and Version] following [the guidelines](https://github.com/apache/fluss/blob/main/AGENTS.md)
-->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #3385
<!-- What is the purpose of the change -->
The test captures the remote log segment count, then asserts it's unchanged after rebalance.
But, `produceRecordsAndWaitRemoteLogCopy()` does not ensure that all log segments have been copied to remote, so the `remoteLogSize`(captured count) is non-deterministic.
### Brief change log
- Add `FlussClusterExtension#waitUntilAllLogSegmentsCopyToRemote()`, which waits until the remote log end offset reaches the active segment's base offset (i.e. all non-active segments are copied to remote).
- Uses `waitUntilAllLogSegmentsCopyToRemote()` instead of `waitUntilSomeLogSegmentsCopyToRemote()`, so the captured segment count is stable.
<!-- Please describe the changes made in this pull request and explain how they address the issue -->
### Tests
Ran `RebalanceManagerITCase.testRebalanceWithRemoteLog` 100 times
- Before fix: 9 / 100 failed
- After fix: 0 / 100 failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [test] fix flaky testRebalanceWithRemoteLog [fluss]
Posted by "wattt3 (via GitHub)" <gi...@apache.org>.
wattt3 commented on PR #3409:
URL: https://github.com/apache/fluss/pull/3409#issuecomment-4589361339
Oh, I see.
I didn't notice there was same issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [test] fix flaky testRebalanceWithRemoteLog [fluss]
Posted by "Kaixuan-Duan (via GitHub)" <gi...@apache.org>.
Kaixuan-Duan commented on PR #3409:
URL: https://github.com/apache/fluss/pull/3409#issuecomment-4589100833
This problem seems to be the same as #2974.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [test] fix flaky testRebalanceWithRemoteLog [fluss]
Posted by "swuferhong (via GitHub)" <gi...@apache.org>.
swuferhong commented on PR #3409:
URL: https://github.com/apache/fluss/pull/3409#issuecomment-4589299721
Hi @wattt3 Since @Kaixuan-Duan has already fixed this issue in https://github.com/apache/fluss/pull/3313, I will merge his commit. Thank you for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [test] fix flaky testRebalanceWithRemoteLog [fluss]
Posted by "wattt3 (via GitHub)" <gi...@apache.org>.
wattt3 commented on PR #3409:
URL: https://github.com/apache/fluss/pull/3409#issuecomment-4586740065
Hi @swuferhong
I saw you've worked on this area before.
So I'd appreciate it if you could take a look.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [test] fix flaky testRebalanceWithRemoteLog [fluss]
Posted by "swuferhong (via GitHub)" <gi...@apache.org>.
swuferhong closed pull request #3409: [test] fix flaky testRebalanceWithRemoteLog
URL: https://github.com/apache/fluss/pull/3409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org