You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by Alexander Broekhuis <a....@gmail.com> on 2012/08/08 10:59:55 UTC
Re: [RFC] [PATCH v1 0/9] More Fixes
I've worked through these patches and applied most of them.
I've ignored the path specific problems since on the command line I don't
see any warnings at this moment.
And as mentioned before, I'll look into the Eclipse project and if it can
be generated by CMake. Maintaining one project file which works on multiple
systems might be impossible.
Thanks for the patches! Really appreciated.
>> I asked for review because I could not find something like a __linux__
>> define
>>
>> I work on olsr as well, and that codebase is very cross platform but
>> there we have many parts that are OS specific. IMHO you can't avoid that
>> in cross platform code...
>>
>
I agree, I was just curious what the cause of the warnings was. I haven't
seen them before on my system (linux and osx).
--
Met vriendelijke groet,
Alexander Broekhuis
Re: [RFC] [PATCH v1 0/9] More Fixes
Posted by Alexander Broekhuis <a....@gmail.com>.
Hi,
> Ferry Huberts wrote:
>>
>> however, I saw you didn't preserve my authorship of miniunz.h,
>>> which is considered 'bad taste' in open source projects...
>>>
>>
My mistake here, I didn't take the patch as is, but only the changed lines.
My Eclipse adds the default header. Never intended to do any harm or add my
own name explicitly.
>
>> For the record, it is quite common in Apache projects to not name an
>> individual author in source files, but instead mention the
>> development team. For example, in Felix we have the following
>>
>
> ok, cool.
> I didn't contribute to many apache projects yet ;-)
> I just followed the convention that was in the source files
I agree with Marcel, as mentioned, the header is from my default Eclipse
setup. Since we are working towards a release, all headers have to be
checked for the Apache license. So I'll take this into account and
remove/change the Eclipse headers.
>
> convention:
>>
>> * @author <a href="mailto:dev@felix.apache.**org <de...@felix.apache.org>">Felix
>> Project
>> Team</a>
>>
>> I would suggest the Celix team considers this suggestion.
>>
>
+1.
--
Met vriendelijke groet,
Alexander Broekhuis
Re: [RFC] [PATCH v1 0/9] More Fixes
Posted by Ferry Huberts <ma...@hupie.com>.
On 08-08-12 16:57, Marcel Offermans wrote:
> On Aug 8, 2012, at 16:47 PM, Ferry Huberts wrote:
>
>> however, I saw you didn't preserve my authorship of miniunz.h,
>> which is considered 'bad taste' in open source projects...
>
> For the record, it is quite common in Apache projects to not name an
> individual author in source files, but instead mention the
> development team. For example, in Felix we have the following
ok, cool.
I didn't contribute to many apache projects yet ;-)
I just followed the convention that was in the source files
> convention:
>
> * @author <a href="mailto:dev@felix.apache.org">Felix Project
> Team</a>
>
> I would suggest the Celix team considers this suggestion.
>
> Greetings, Marcel
>
--
Ferry Huberts
Re: [RFC] [PATCH v1 0/9] More Fixes
Posted by Marcel Offermans <ma...@luminis.nl>.
On Aug 8, 2012, at 16:47 PM, Ferry Huberts wrote:
> however, I saw you didn't preserve my authorship of miniunz.h, which is considered 'bad taste' in open source projects...
For the record, it is quite common in Apache projects to not name an individual author in source files, but instead mention the development team. For example, in Felix we have the following convention:
* @author <a href="mailto:dev@felix.apache.org">Felix Project Team</a>
I would suggest the Celix team considers this suggestion.
Greetings, Marcel
Re: [RFC] [PATCH v1 0/9] More Fixes
Posted by Ferry Huberts <ma...@hupie.com>.
On 08-08-12 15:45, Alexander Broekhuis wrote:
> 2012/8/8 Alexander Broekhuis <a....@gmail.com>
>
>> I've worked through these patches and applied most of them.
>
>
> The patches have been committed in [1]. Probably [2] is also needed to
> compile (some file moves where taken into the 1st commit).
>
> [1]: http://svn.apache.org/viewvc?rev=1370760&view=rev
> [2]: http://svn.apache.org/viewvc?rev=1370761&view=rev
>
> If you find some time, could you verify if everything has been fixed?
> (taken my previous message into account..).
thanks for applying.
everything seems to be fixed.
however, I saw you didn't preserve my authorship of miniunz.h, which is
considered 'bad taste' in open source projects...
my rebased branch compared to trunk:
> - * Created on: Aug 8, 2012
> - * Author: alexander
> + * Created on: Jul 13, 2012
> + * Author: Ferry Huberts
>
>
--
Ferry Huberts
Re: [RFC] [PATCH v1 0/9] More Fixes
Posted by Alexander Broekhuis <a....@gmail.com>.
2012/8/8 Alexander Broekhuis <a....@gmail.com>
> I've worked through these patches and applied most of them.
The patches have been committed in [1]. Probably [2] is also needed to
compile (some file moves where taken into the 1st commit).
[1]: http://svn.apache.org/viewvc?rev=1370760&view=rev
[2]: http://svn.apache.org/viewvc?rev=1370761&view=rev
If you find some time, could you verify if everything has been fixed?
(taken my previous message into account..).
--
Met vriendelijke groet,
Alexander Broekhuis