You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by "strongduanmu (via GitHub)" <gi...@apache.org> on 2025/02/03 09:26:00 UTC

Re: [PR] [CALCITE-1466] Support for UNSIGNED types of TINYINT, SMALLINT, MEDIUMINT, INT, BIGINT in type system [calcite-avatica]

strongduanmu commented on PR #275:
URL: https://github.com/apache/calcite-avatica/pull/275#issuecomment-2630398296

   > The changes look fine, but it's hard to tell whether all code paths that may be relevant have been handled until we have some end-to-end tests.
   
   Yes, I agree with you, end-to-end testing is very important. Currently, I have tested different unsigned types with `calcite avatica 1.26.0-SNAPSHOT` and they all work fine. When this PR is merged, I will try to support unsigned types in calcite and add more end-to-end test cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org