You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/07/03 21:41:42 UTC
Re: Review Request 67235: Added per-framework metrics for types of
resources contained in offers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67235/
-----------------------------------------------------------
(Updated July 3, 2018, 9:41 p.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.
Bugs: MESOS-8940
https://issues.apache.org/jira/browse/MESOS-8940
Repository: mesos
Description
-------
Added per-framework metrics for types of resources contained in offers.
Diffs (updated)
-----
src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb
Diff: https://reviews.apache.org/r/67235/diff/5/
Changes: https://reviews.apache.org/r/67235/diff/4-5/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 67235: Added per-framework metrics for types of
resources contained in offers.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67235/
-----------------------------------------------------------
(Updated July 18, 2018, 1:46 a.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.
Bugs: MESOS-8940
https://issues.apache.org/jira/browse/MESOS-8940
Repository: mesos
Description
-------
Added per-framework metrics for types of resources contained in offers.
Diffs
-----
src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb
Diff: https://reviews.apache.org/r/67235/diff/5/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 67235: Added per-framework metrics for types of
resources contained in offers.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67235/#review205698
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66882', '66819', '66820', '67808', '67809', '67812', '67813', '67814', '66841', '66842', '66843', '67147', '66844', '66855', '66861', '66856', '66870', '66883', '67187', '67235']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67235
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67235/logs/mesos-tests-stdout.log):
```
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (801 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (599 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[ OK ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1325 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[ OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (802 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (802 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (1006 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[ OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (597 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[ OK ] DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5165 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (4956 ms)
[----------] 24 tests from DockerContainerizerTest (90217 ms total)
[----------] 1 test from HungDockerTest
[ RUN ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull
d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @000000905693BDB0.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @000000905693C010.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @00000265933CF4C8.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @000002659450F360.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @00000265945C6FB0.
ERROR: 5 leaked mock objects found at program exit.
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67235/logs/mesos-tests-stderr.log):
```
I0703 22:51:45.960681 9388 authenticatee.cpp:299] Authentication success
I0703 22:51:45.961689 8204 master.cpp:9830] Successfully authenticated principal 'test-principal' at scheduler-0ef579da-198f-407a-b859-3ba49ca2031c@192.10.1.6:56346
I0703 22:51:45.961689 8552 sched.cpp:501] Successfully authenticated with master master@192.10.1.6:56346
I0703 22:51:45.962689 9388 master.cpp:2941] Received SUBSCRIBE call for framework 'default' at scheduler-0ef579da-198f-407a-b859-3ba49ca2031c@192.10.1.6:56346
I0703 22:51:45.962689 9388 master.cpp:2242] Authorizing framework principal 'test-principal' to receive offers for roles '{ * }'
I0703 22:51:45.963690 8224 master.cpp:3022] Subscribing framework default with checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0703 22:51:45.975672 8224 master.cpp:10021] Adding framework 993d0452-bfa9-45ad-a897-56720c36c7ed-0000 (default) at scheduler-0ef579da-198f-407a-b859-3ba49ca2031c@192.10.1.6:56346 with roles { } suppressed
I0703 22:51:45.976670 5668 sched.cpp:749] Framework registered with 993d0452-bfa9-45ad-a897-56720c36c7ed-0000
I0703 22:51:45.978691 8204 hierarchical.cpp:306] Added framework 993d0452-bfa9-45ad-a897-56720c36c7ed-0000
E0703 22:51:46.063894 8380 slave.cpp:7289] EXIT with status 1: Failed to perform recovery: Collect failed: Failed to run 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat -H npipe:////./pipe/docker_engine ps -a': exited with status 1; stderr=''C:\Program' is not recognized as an internal or external command,
operable program or batch file.
'
If recovery failed due to a change in configuration and you want to
keep the current agent id, you might want to change the
`--reconfiguration_policy` flag to a more permissive value.
To restart this agent with a new agent id instead, do as follows:
rm -f C:\Users\jenkins\AppData\Local\Temp\sDOVv4\meta\slaves\latest
This ensures that the agent does not recover old live executors.
If you use the Docker containerizer and think that the Docker
daemon state is broken, you can try to clear it. But be careful:
these commands will erase all containers and images from this host,
not just those started by Mesos!
docker kill $(docker ps -q)
docker rm $(docker ps -a -q)
docker rmi $(docker images -q)
Finally, restart the agent.
```
- Mesos Reviewbot Windows
On July 3, 2018, 9:41 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67235/
> -----------------------------------------------------------
>
> (Updated July 3, 2018, 9:41 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.
>
>
> Bugs: MESOS-8940
> https://issues.apache.org/jira/browse/MESOS-8940
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per-framework metrics for types of resources contained in offers.
>
>
> Diffs
> -----
>
> src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
> src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb
>
>
> Diff: https://reviews.apache.org/r/67235/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>