You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/11 14:22:36 UTC

[GitHub] [arrow] nealrichardson commented on a change in pull request #7929: ARROW-9602: [R] Improve cmake detection in Linux build

nealrichardson commented on a change in pull request #7929:
URL: https://github.com/apache/arrow/pull/7929#discussion_r468620814



##########
File path: r/tools/linuxlibs.R
##########
@@ -315,8 +315,13 @@ build_libarrow <- function(src_dir, dst_dir) {
 }
 
 ensure_cmake <- function() {
-  cmake <- Sys.which("cmake")
-  if (!nzchar(cmake) || cmake_version() < 3.2) {
+  cmake <- find_cmake(c(
+    Sys.getenv("CMAKE"),
+    Sys.which("cmake"),
+    Sys.which("cmake3")

Review comment:
       Apparently so; it was in the report on https://issues.apache.org/jira/browse/ARROW-9602




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org