You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Steve Carlin (Code Review)" <ge...@cloudera.org> on 2025/07/06 16:28:33 UTC
[Impala-ASF-CR] IMPALA-14201: Calcite planner: Not catching erroneous casts.
Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23125
Change subject: IMPALA-14201: Calcite planner: Not catching erroneous casts.
......................................................................
IMPALA-14201: Calcite planner: Not catching erroneous casts.
The cast from date to int was succeeding and returning a null row.
With this commit, a check is done to make sure the cast function
signature exists.
Change-Id: Ic8e4bf1e65916cd128fd0bd75c39be5d7834c954
---
M fe/src/main/java/org/apache/impala/analysis/CastExpr.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexCallConverter.java
M testdata/workloads/functional-query/queries/QueryTest/calcite.test
3 files changed, 38 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/23125/1
--
To view, visit http://gerrit.cloudera.org:8080/23125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8e4bf1e65916cd128fd0bd75c39be5d7834c954
Gerrit-Change-Number: 23125
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-14201: Calcite planner: Not catching erroneous casts.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23125 )
Change subject: IMPALA-14201: Calcite planner: Not catching erroneous casts.
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19716/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8e4bf1e65916cd128fd0bd75c39be5d7834c954
Gerrit-Change-Number: 23125
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Sun, 06 Jul 2025 16:59:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14201: Calcite planner: Not catching erroneous casts.
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Steve Carlin has abandoned this change. ( http://gerrit.cloudera.org:8080/23125 )
Change subject: IMPALA-14201: Calcite planner: Not catching erroneous casts.
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/23125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic8e4bf1e65916cd128fd0bd75c39be5d7834c954
Gerrit-Change-Number: 23125
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>