You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/27 02:26:03 UTC

[GitHub] sunjincheng121 edited a comment on issue #7837: [FLINK-11091][table] Clear the use of deprecated `process(ProcessFunc…

sunjincheng121 edited a comment on issue #7837: [FLINK-11091][table] Clear the use of deprecated `process(ProcessFunc…
URL: https://github.com/apache/flink/pull/7837#issuecomment-467697840
 
 
   Thanks for your review and very nice comments! @hequn8128 
   
   I'm not sure if abstracting an internal method that contains only one method call is the best, but the code looks really clean. +1 for your proposal.
   
   I have updated the PR. 
   
   Thanks,
   Jincheng

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services