[GitHub] [commons-math] chentao106 commented on issue #126: #MATH-1525 Move out "EmptyClusterStrategy" from KMeansPlusPlusClusterer

[GitBox <gi...@apache.org>]

chentao106 commented on issue #126: #MATH-1525 Move out "EmptyClusterStrategy" from KMeansPlusPlusClusterer
URL: https://github.com/apache/commons-math/pull/126#issuecomment-600475045
 
 
   > A commit is missing. Did you force push on your branch or on a branch this is based on?
   > 
   > However there is also this error:
   > 
   > ```
   > [ERROR] /home/travis/build/apache/commons-math/src/main/java/org/apache/commons/math4/ml/clustering/extractor/FarthestPointExtractor.java:[66,47] getCenter() is not public in org.apache.commons.math4.ml.clustering.CentroidCluster; cannot be accessed from outside package
   > ```
   > 
   > Given that this is true (the method is package private), this PR will always fail.
   
   I think it is fail to merge with the newest master change, that the "public getCenter()"->"getCenter()" trigger a compile error.
   
   I have to make a new PR to fix this, thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services