[jira] [Commented] (SQOOP-1742) Sqoop2: Add type to connectors during upgrade

["Veena Basavaraj (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SQOOP-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213302#comment-14213302 ] 

Veena Basavaraj commented on SQOOP-1742:
----------------------------------------

I looked at the upgraded DB and the type is infact filled.

The snapshot I was seeing was from a failed upgrade before I think hence I thought this was a issue.
My bad.

So looks like the upgrade connector code sets the type for every connector it will try to upgrade.

 @Override

  public void upgradeConnectorAndConfigs(MConnector mConnector, Connection conn) {

    updateConnectorAndDeleteConfigs(mConnector, conn);


 

   updateConnectorStatement = conn.prepareStatement(STMT_UPDATE_CONFIGURABLE);

      deleteInput = conn.prepareStatement(STMT_DELETE_INPUTS_FOR_CONFIGURABLE);

      deleteConfigDirection = conn.prepareStatement(STMT_DELETE_DIRECTIONS_FOR_CONFIGURABLE);

      deleteConfig = conn.prepareStatement(STMT_DELETE_CONFIGS_FOR_CONFIGURABLE);

      

      updateConnectorStatement.setString(1, mConnector.getUniqueName());

      updateConnectorStatement.setString(2, mConnector.getClassName());

      updateConnectorStatement.setString(3, mConnector.getVersion());

      updateConnectorStatement.setString(4, mConnector.getType().name());

      updateConnectorStatement.setLong(5, mConnector.getPersistenceId());

> Sqoop2: Add type to connectors during upgrade
> ---------------------------------------------
>
>                 Key: SQOOP-1742
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1742
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.99.4
>            Reporter: Abraham Elmahrek
>             Fix For: 1.99.4
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)