[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #7492: Minor: Add `ScalarValue::data_type()` for consistency with other APIs

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #7492:
URL: https://github.com/apache/arrow-datafusion/pull/7492#discussion_r1318899619


##########
datafusion/common/src/scalar.rs:
##########
@@ -1149,6 +1149,13 @@ impl ScalarValue {
         }
     }
 
+    /// Getter for the `DataType` of the value.
+    ///
+    /// Suggest using  [`Self::data_type`] as a more standard API
+    pub fn get_datatype(&self) -> DataType {
+        self.data_type()
+    }

Review Comment:
   We could/should -- I was basically being lazy. 
   
   I'll try and find time to bash out a follow on PR to deprecate it and update the uses. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org