You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/03/31 17:33:17 UTC

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5512: Traffic Ops Go client cleanup

ocket8888 commented on a change in pull request #5512:
URL: https://github.com/apache/trafficcontrol/pull/5512#discussion_r605091043



##########
File path: traffic_ops/testing/api/v4/cachegroups_parameters_test.go
##########
@@ -45,7 +46,9 @@ func CreateTestCacheGroupParameters(t *testing.T) {
 
 	// Get Parameter to assign to Cache Group
 	firstParameter := testData.Parameters[0]
-	paramResp, _, err := TOSession.GetParameterByName(firstParameter.Name)
+	params := url.Values{}
+	params.Set("name", firstParameter.Name)
+	paramResp, _, err := TOSession.GetParameters(nil, params)

Review comment:
       I'm going to follow this PR up with another that makes all the call signatures of the methods consistent. I was going to do this then, but it's easy enough to do it now if you want.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org