You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@skywalking.apache.org by Sheng Wu <wu...@apache.org> on 2021/08/23 09:56:10 UTC
[Attention] Our main repo will face CI time block shortly
Hi
In case not everyone noticed, the main CI-IT task time of our main
repo is closing in one hour.
Our e2e tasks and plugin tests are still efficient, but CI-IT will be
a time blocker for us shortly.
In my mind, the only option would be to split the java agent from the
main repo codebase and create a skywalking-java repo instead. This is
still not urgent, but the trend is very clear.
When we reach that point, we will not have any so-called main-repo
anymore. Everything would be a component, and replaceable.
There is no action planned to be taken, but I hope everyone could know
this day will come eventually. If the time is over 60 mins, we may
have no option, but to do it.
Sheng Wu 吴晟
Twitter, wusheng1108
Re: [Attention] Our main repo will face CI time block shortly
Posted by Sheng Wu <wu...@gmail.com>.
I think we don't have any tech block for the repo split.
If more people think it is reasonable, we can do that. And, we have to
keep the version continuous when the repo splits.
Sheng Wu 吴晟
Twitter, wusheng1108
kezhenxu94@apache <ke...@apache.org> 于2021年8月24日周二 上午9:53写道：
>
> Hi, I’m big +1 to split the repo into two,
> the reason for me is to make it more clear and reasonable to maintain,
> also, for new contributors they usually don't understand why Java agent
> is different with other languages' agents and they usually mix the backend
> with Java agent because they are in the same repo.
>
> As for the CI waiting time, if splitting the repo can reduce the time,
> splitting the CI tasks into backend and agent, and only run the tasks
> when their corresponding codes are changed, can also reduce the time.
>
>
> > On Aug 23, 2021, at 17:56, Sheng Wu <wu...@apache.org> wrote:
> >
> > Hi
> >
> > In case not everyone noticed, the main CI-IT task time of our main
> > repo is closing in one hour.
> > Our e2e tasks and plugin tests are still efficient, but CI-IT will be
> > a time blocker for us shortly.
> >
> > In my mind, the only option would be to split the java agent from the
> > main repo codebase and create a skywalking-java repo instead. This is
> > still not urgent, but the trend is very clear.
> > When we reach that point, we will not have any so-called main-repo
> > anymore. Everything would be a component, and replaceable.
> >
> > There is no action planned to be taken, but I hope everyone could know
> > this day will come eventually. If the time is over 60 mins, we may
> > have no option, but to do it.
> >
> > Sheng Wu 吴晟
> > Twitter, wusheng1108
>
> —————————
> Zhenxu Ke (柯振旭)
> GitHub @kezhenxu94
>
Split Java agent codebases into skywalking-java repo. Was:
[Attention] Our main repo will face CI time block shortly
Posted by Sheng Wu <wu...@gmail.com>.
Hi Everyone
Due to this proposal received a very positive results from both the
committer team and the community[1], we are taking action now.
The new repository, skywalking-java[2], has been created. And the code
transfer has begun. After the agent side is finished, we will remove
the codes from the main repo directly.
After this move, the java agent and backend wouldn't ask for a version
match. We are going to focus on protocol-level compatibility only.
[1] https://github.com/apache/skywalking/discussions/7548
[2] https://github.com/apache/skywalking-java
Sheng Wu 吴晟
Twitter, wusheng1108
Sheng Wu <wu...@gmail.com> 于2021年8月24日周二 上午10:13写道：
>
> java agent is really skywalking for Java language :P If you ask me
>
>
> Sheng Wu 吴晟
> Twitter, wusheng1108
>
> Daming <da...@apache.org> 于2021年8月24日周二 上午10:05写道：
> >
> > Hi,
> > ++1 , (I am very glad to heart splitting repo.)
> >
> > ---
> > Personally, skywalking-java looks like skywalking for Java language. Could
> > we name it skywalking-agent-java or skywalking-java-agent? (Even I know we
> > named other languages in this format, skywalking-{language})
> >
> > Haochao Zhuang
> >
> > kezhenxu94@apache <ke...@apache.org> 于2021年8月24日周二 上午9:53写道：
> >
> > > Hi, I’m big +1 to split the repo into two,
> > > the reason for me is to make it more clear and reasonable to maintain,
> > > also, for new contributors they usually don't understand why Java agent
> > > is different with other languages' agents and they usually mix the backend
> > > with Java agent because they are in the same repo.
> > >
> > > As for the CI waiting time, if splitting the repo can reduce the time,
> > > splitting the CI tasks into backend and agent, and only run the tasks
> > > when their corresponding codes are changed, can also reduce the time.
> > >
> > >
> > > > On Aug 23, 2021, at 17:56, Sheng Wu <wu...@apache.org> wrote:
> > > >
> > > > Hi
> > > >
> > > > In case not everyone noticed, the main CI-IT task time of our main
> > > > repo is closing in one hour.
> > > > Our e2e tasks and plugin tests are still efficient, but CI-IT will be
> > > > a time blocker for us shortly.
> > > >
> > > > In my mind, the only option would be to split the java agent from the
> > > > main repo codebase and create a skywalking-java repo instead. This is
> > > > still not urgent, but the trend is very clear.
> > > > When we reach that point, we will not have any so-called main-repo
> > > > anymore. Everything would be a component, and replaceable.
> > > >
> > > > There is no action planned to be taken, but I hope everyone could know
> > > > this day will come eventually. If the time is over 60 mins, we may
> > > > have no option, but to do it.
> > > >
> > > > Sheng Wu 吴晟
> > > > Twitter, wusheng1108
> > >
> > > —————————
> > > Zhenxu Ke (柯振旭)
> > > GitHub @kezhenxu94
> > >
> > >
Re: [Attention] Our main repo will face CI time block shortly
Posted by Sheng Wu <wu...@gmail.com>.
java agent is really skywalking for Java language :P If you ask me
Sheng Wu 吴晟
Twitter, wusheng1108
Daming <da...@apache.org> 于2021年8月24日周二 上午10:05写道：
>
> Hi,
> ++1 , (I am very glad to heart splitting repo.)
>
> ---
> Personally, skywalking-java looks like skywalking for Java language. Could
> we name it skywalking-agent-java or skywalking-java-agent? (Even I know we
> named other languages in this format, skywalking-{language})
>
> Haochao Zhuang
>
> kezhenxu94@apache <ke...@apache.org> 于2021年8月24日周二 上午9:53写道：
>
> > Hi, I’m big +1 to split the repo into two,
> > the reason for me is to make it more clear and reasonable to maintain,
> > also, for new contributors they usually don't understand why Java agent
> > is different with other languages' agents and they usually mix the backend
> > with Java agent because they are in the same repo.
> >
> > As for the CI waiting time, if splitting the repo can reduce the time,
> > splitting the CI tasks into backend and agent, and only run the tasks
> > when their corresponding codes are changed, can also reduce the time.
> >
> >
> > > On Aug 23, 2021, at 17:56, Sheng Wu <wu...@apache.org> wrote:
> > >
> > > Hi
> > >
> > > In case not everyone noticed, the main CI-IT task time of our main
> > > repo is closing in one hour.
> > > Our e2e tasks and plugin tests are still efficient, but CI-IT will be
> > > a time blocker for us shortly.
> > >
> > > In my mind, the only option would be to split the java agent from the
> > > main repo codebase and create a skywalking-java repo instead. This is
> > > still not urgent, but the trend is very clear.
> > > When we reach that point, we will not have any so-called main-repo
> > > anymore. Everything would be a component, and replaceable.
> > >
> > > There is no action planned to be taken, but I hope everyone could know
> > > this day will come eventually. If the time is over 60 mins, we may
> > > have no option, but to do it.
> > >
> > > Sheng Wu 吴晟
> > > Twitter, wusheng1108
> >
> > —————————
> > Zhenxu Ke (柯振旭)
> > GitHub @kezhenxu94
> >
> >
Re: [Attention] Our main repo will face CI time block shortly
Posted by Daming <da...@apache.org>.
Hi,
++1 , (I am very glad to heart splitting repo.)
---
Personally, skywalking-java looks like skywalking for Java language. Could
we name it skywalking-agent-java or skywalking-java-agent? (Even I know we
named other languages in this format, skywalking-{language})
Haochao Zhuang
kezhenxu94@apache <ke...@apache.org> 于2021年8月24日周二 上午9:53写道：
> Hi, I’m big +1 to split the repo into two,
> the reason for me is to make it more clear and reasonable to maintain,
> also, for new contributors they usually don't understand why Java agent
> is different with other languages' agents and they usually mix the backend
> with Java agent because they are in the same repo.
>
> As for the CI waiting time, if splitting the repo can reduce the time,
> splitting the CI tasks into backend and agent, and only run the tasks
> when their corresponding codes are changed, can also reduce the time.
>
>
> > On Aug 23, 2021, at 17:56, Sheng Wu <wu...@apache.org> wrote:
> >
> > Hi
> >
> > In case not everyone noticed, the main CI-IT task time of our main
> > repo is closing in one hour.
> > Our e2e tasks and plugin tests are still efficient, but CI-IT will be
> > a time blocker for us shortly.
> >
> > In my mind, the only option would be to split the java agent from the
> > main repo codebase and create a skywalking-java repo instead. This is
> > still not urgent, but the trend is very clear.
> > When we reach that point, we will not have any so-called main-repo
> > anymore. Everything would be a component, and replaceable.
> >
> > There is no action planned to be taken, but I hope everyone could know
> > this day will come eventually. If the time is over 60 mins, we may
> > have no option, but to do it.
> >
> > Sheng Wu 吴晟
> > Twitter, wusheng1108
>
> —————————
> Zhenxu Ke (柯振旭)
> GitHub @kezhenxu94
>
>
Re: [Attention] Our main repo will face CI time block shortly
Posted by "kezhenxu94@apache" <ke...@apache.org>.
Hi, I’m big +1 to split the repo into two,
the reason for me is to make it more clear and reasonable to maintain,
also, for new contributors they usually don't understand why Java agent
is different with other languages' agents and they usually mix the backend
with Java agent because they are in the same repo.
As for the CI waiting time, if splitting the repo can reduce the time,
splitting the CI tasks into backend and agent, and only run the tasks
when their corresponding codes are changed, can also reduce the time.
> On Aug 23, 2021, at 17:56, Sheng Wu <wu...@apache.org> wrote:
>
> Hi
>
> In case not everyone noticed, the main CI-IT task time of our main
> repo is closing in one hour.
> Our e2e tasks and plugin tests are still efficient, but CI-IT will be
> a time blocker for us shortly.
>
> In my mind, the only option would be to split the java agent from the
> main repo codebase and create a skywalking-java repo instead. This is
> still not urgent, but the trend is very clear.
> When we reach that point, we will not have any so-called main-repo
> anymore. Everything would be a component, and replaceable.
>
> There is no action planned to be taken, but I hope everyone could know
> this day will come eventually. If the time is over 60 mins, we may
> have no option, but to do it.
>
> Sheng Wu 吴晟
> Twitter, wusheng1108
—————————
Zhenxu Ke (柯振旭)
GitHub @kezhenxu94