You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2016/09/25 07:20:10 UTC
[GitHub] zeppelin pull request #1457: [Hot Fix] Add a newline for bullet list markdow...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/1457
[Hot Fix] Add a newline for bullet list markdown rendering
### What is this PR for?
After #1416 merged, the bullet list in https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/install/install.html#installation isn't properly rendered now. It needs an extra newline.
### What type of PR is it?
Hot Fix
### Screenshots (if appropriate)
- Before
<img width="834" alt="screen shot 2016-09-25 at 4 13 25 pm" src="https://cloud.githubusercontent.com/assets/10060731/18813621/5e10c2dc-833b-11e6-8410-bb1d37d8228b.png">
- After
<img width="834" alt="screen shot 2016-09-25 at 4 13 36 pm" src="https://cloud.githubusercontent.com/assets/10060731/18813622/6705b744-833b-11e6-8fab-3a69d8585c7a.png">
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin fix/install.md
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1457.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1457
----
commit 73c1a4f99586b60622fc8320a65f3ccfb838e128
Author: AhyoungRyu <ah...@apache.org>
Date: 2016-09-25T07:14:39Z
Add a newline for bullet list markdown rendering
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1457: [Hot Fix] Add a newline for bullet list markdow...
Posted by AhyoungRyu <gi...@git.apache.org>.
GitHub user AhyoungRyu reopened a pull request:
https://github.com/apache/zeppelin/pull/1457
[Hot Fix] Add a newline for bullet list markdown rendering
### What is this PR for?
After #1416 merged, the bullet list in https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/install/install.html#installation isn't properly rendered now. It needs an extra newline.
### What type of PR is it?
Hot Fix
### Screenshots (if appropriate)
- Before
<img width="834" alt="screen shot 2016-09-25 at 4 13 25 pm" src="https://cloud.githubusercontent.com/assets/10060731/18813621/5e10c2dc-833b-11e6-8410-bb1d37d8228b.png">
- After
<img width="834" alt="screen shot 2016-09-25 at 4 13 36 pm" src="https://cloud.githubusercontent.com/assets/10060731/18813622/6705b744-833b-11e6-8fab-3a69d8585c7a.png">
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin fix/install.md
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1457.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1457
----
commit 73c1a4f99586b60622fc8320a65f3ccfb838e128
Author: AhyoungRyu <ah...@apache.org>
Date: 2016-09-25T07:14:39Z
Add a newline for bullet list markdown rendering
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1457: [Hot Fix] Add a newline for bullet list markdown rende...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1457
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1457: [Hot Fix] Add a newline for bullet list markdown rende...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1457
Thanks @minahlee for you prompt verification :)
Sadly CI is not green but only
```
SCALA_VER="2.10" SPARK_VER="1.4.1" HADOOP_VER="2.3" PROFILE="-Pspark-1.4 -Pr -Phadoop-2.3 -Ppyspark -Psparkr"
```
failed with `No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.`
So merging this one as a hotfix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1457: [Hot Fix] Add a newline for bullet list markdow...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1457
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1457: [Hot Fix] Add a newline for bullet list markdow...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu closed the pull request at:
https://github.com/apache/zeppelin/pull/1457
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---