Re: [PATCH] Check for cancel function in repos->repos andwc->reposcopy

[Bhuvaneswaran Arumugam <bh...@collab.net>]

On Tue, 2008-03-25 at 09:42 -0500, Hyrum K. Wright wrote:
> Bhuvaneswaran Arumugam wrote:
>  > @@ -1267,6 +1270,10 @@
>  >        svn_client_commit_item3_t *item =
>  >          APR_ARRAY_IDX(commit_items, i, svn_client_commit_item3_t *);
>  >
>  > +      /* Check for cancellation */
>  > +      if (ctx->cancel_func)
>  > +        SVN_ERR(ctx->cancel_func(ctx->cancel_baton));
>  > +
>  >        /* Set the mergeinfo for the destination to the combined merge
>  >           info known to the WC and the repository. */
>  >        item->outgoing_prop_changes = apr_array_make(pool, 1,
> 
> This looks to be inside a loop which just sets up the copy, but doesn't
> perform the actual copy.  We are already checking for cancelation inside
> of sn_client__do_commit(), so I don't know that this extra check is needed.

Thanks for the review comment Hyrum. Yeah, we already check for
cancellation in svn_client__do_commit(). Sounds like the extra check
here is not needed.
-- 
Regards,
Bhuvaneswaran