[GitHub] [spark] HyukjinKwon commented on a diff in pull request #41138: [SPARK-43457][CONNECT][PYTHON] Augument user agent with OS, Python and Spark versions

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #41138:
URL: https://github.com/apache/spark/pull/41138#discussion_r1193232765


##########
python/pyspark/sql/connect/client.py:
##########
@@ -299,7 +301,12 @@ def userAgent(self) -> str:
             raise SparkConnectException(
                 f"'user_agent' parameter should not exceed 2048 characters, found {len} characters."
             )
-        return user_agent
+        return " ".join([

Review Comment:
   Don't have a strong opinion but wonder if we should return a dictionary or at least JSON string in case it's programmatically used



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org