You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/12/03 21:13:49 UTC

[GitHub] [calcite] vlsi commented on issue #1625: [CALCITE-3559] Drop HydromaticFileSetCheck, upgrade Checkstyle

vlsi commented on issue #1625: [CALCITE-3559] Drop HydromaticFileSetCheck, upgrade Checkstyle
URL: https://github.com/apache/calcite/pull/1625#issuecomment-561359572
 
 
   > HydromaticFileSetCheck checks things that checkstyle doesn't, and can't. If we remove it, we have less code style coverage.
   
   You are right.
   The suggested direction is to keep away from Checkstyle as it distracts developers.
   
   Almost all the checks can be implemented without HydromaticFileSetCheck, so it is natural to drop it.
   
   We can even live with a reduced set of rules for a while.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services