[jira] [Commented] (KYLIN-3146) Response code and exception should be standardised for cube checking

["Shaofeng SHI (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309077#comment-16309077 ] 

Shaofeng SHI commented on KYLIN-3146:
-------------------------------------

+1 

> Response code and exception should be standardised for cube checking   
> -----------------------------------------------------------------------
>
>                 Key: KYLIN-3146
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3146
>             Project: Kylin
>          Issue Type: Improvement
>            Reporter:  Kaige Liu
>            Assignee:  Kaige Liu
>            Priority: Minor
>
> Checking if cubes exist or not is a common behaviour in some APIs. But we have lots of different responses for the same behaviour.
> Let's take CubeController as an example. When can not find a cube with its name, someone gives a *400* as response code, someone returns *404*, and others send back a *500*. Not only HTTP response code is not standard, which kind of exception should be thrown is not unified as well. Still using the above example, we can find *IllegalArgumentException*, *BadRequestException*, *InternalErrorException*.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)