You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by tzolov <gi...@git.apache.org> on 2015/07/31 02:55:15 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-189: Add Apache Geode In...
GitHub user tzolov opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/173
ZEPPELIN-189: Add Apache Geode Interpreter for Zeppelin
Syntax look like this:
%geode.oql
SELECT * FROM /regionOne o WHERE o.field1 > 146 AND o.field2 LIKE '%some%';
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tzolov/incubator-zeppelin ZEPPELIN-189
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/173.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #173
----
commit b28e0b7cedab060daa9ae0db5ea0e44eb91123de
Author: tzolov <ch...@gmail.com>
Date: 2015-07-31T00:24:41Z
ZEPPELIN-189: Add Apache Geode Interpreter for Zeppelin
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-189: Add Apache Geode In...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/173#issuecomment-128165573
Thank you.
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-189: Add Apache Geode In...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/173
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-189: Add Apache Geode In...
Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/173#issuecomment-128653509
@bzz, @Leemoonsoo thank you for the support and for the passions ;)
@martin-g thanks for the valuable suggestions?
@bzz, the GH is still not in sync. Shall i submit an INFRA ticket or you've done it already?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-189: Add Apache Geode In...
Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/173#issuecomment-128172256
Sure @Leemoonsoo i've just added it. Thanks for the effort of reviewing it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-189: Add Apache Geode In...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/173#issuecomment-127440252
Great!
One more thing @tzolov just to double-check, are you sure 96ebdef belongs to this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-189: Add Apache Geode In...
Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/173#issuecomment-127587202
Ah, thanks for spotting this @bzz !
Not sure how i've managed to do it but 96ebdef is definitely not one of my commits and it is not related to ZEPPELIN-189.
Would it be safe if i remove the commit from the history (e.g. git rebase -i HEAD~XX) and force push again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-zeppelin pull request: ZEPPELIN-189: Add
Apache Geode In...
Posted by Christian Tzolov <ct...@pivotal.io>.
good to know, thanks!
On 6 August 2015 at 13:26, Alex <ke...@gmail.com> wrote:
> As an author, you can just close and open your PR to trigger CI build
> again.
>
> --
> Kind regards,
> Alexander
>
> > On 06 Aug 2015, at 15:51, tzolov <gi...@git.apache.org> wrote:
> >
> > Github user tzolov commented on the pull request:
> >
> >
> https://github.com/apache/incubator-zeppelin/pull/173#issuecomment-128270221
> >
> > FYI, I made a small commit just to trigger a new Travis CI build.
> Sometimes TravisCI fails with no obvious reasons and there is no way to
> restart it but to commit.
> > The change itself is addition of a safeguard in the open() method to
> ensure the previous connections are closed. (e.g. some sort of method
> idempotency guarantees).
> >
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your
> > reply appear on GitHub as well. If your project does not have this
> feature
> > enabled and wishes so, or if the feature is enabled but not working,
> please
> > contact infrastructure at infrastructure@apache.org or file a JIRA
> ticket
> > with INFRA.
> > ---
>
--
Christian Tzolov <http://www.linkedin.com/in/tzolov> | Solution Architect,
EMEA Practice Team | Pivotal <http://pivotal.io/>
ctzolov@pivotal.io|+31610285517
Re: [GitHub] incubator-zeppelin pull request: ZEPPELIN-189: Add Apache Geode In...
Posted by Alex <ke...@gmail.com>.
As an author, you can just close and open your PR to trigger CI build again.
--
Kind regards,
Alexander
> On 06 Aug 2015, at 15:51, tzolov <gi...@git.apache.org> wrote:
>
> Github user tzolov commented on the pull request:
>
> https://github.com/apache/incubator-zeppelin/pull/173#issuecomment-128270221
>
> FYI, I made a small commit just to trigger a new Travis CI build. Sometimes TravisCI fails with no obvious reasons and there is no way to restart it but to commit.
> The change itself is addition of a safeguard in the open() method to ensure the previous connections are closed. (e.g. some sort of method idempotency guarantees).
>
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-189: Add Apache Geode In...
Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/173#issuecomment-128270221
FYI, I made a small commit just to trigger a new Travis CI build. Sometimes TravisCI fails with no obvious reasons and there is no way to restart it but to commit.
The change itself is addition of a safeguard in the open() method to ensure the previous connections are closed. (e.g. some sort of method idempotency guarantees).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-189: Add Apache Geode In...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/173#issuecomment-128540918
Thank you for contributing!
It have just been merged to master. GH mirror is somehow slow on catching up though
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-189: Add Apache Geode In...
Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/173#issuecomment-128690578
here is the INFRA ticket: https://issues.apache.org/jira/browse/INFRA-10087
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-189: Add Apache Geode In...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/173#issuecomment-127102733
Can you double check formatting of pom?
Except for that it looks good to me, the only thing is that discussion on the new interpreters contributions is still ongoing on the list dev@
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-189: Add Apache Geode In...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/173#issuecomment-128545478
To resolve github mirror sync issue, i used to file an issue to INFRA, like
https://issues.apache.org/jira/browse/INFRA-9974?jql=project%20%3D%20INFRA%20and%20reporter%20%3D%20moon%20and%20text%20~%20sync
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-189: Add Apache Geode In...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/173#issuecomment-128166581
Do you mind add geode interpreter to https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java#L384 ? which will be the default value when zeppelin-site.xml is missing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-189: Add Apache Geode In...
Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/173#issuecomment-127168415
@bzz, thanks for reviewing this! With the last commits, I've removed the obsoleted dependencies and cleaned the pom format.
@buzz, @Leemoonsoo, could you please point me to the @dev discussion concerning the interpreter contribution?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-189: Add Apache Geode In...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/173#issuecomment-127804450
Sure! Yes, I think that is safe to do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-189: Add Apache Geode In...
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/173#issuecomment-128271524
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-189: Add Apache Geode In...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/173#issuecomment-128185364
Thanks. Looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-189: Add Apache Geode In...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/173#issuecomment-127180763
@tzolov
The subject is 'interpreter with no test'. But the discussion converged to managing interpreters.
http://apache-zeppelin-incubating-dev-mailing-list.75694.x6.nabble.com/Interpreter-with-no-test-td430.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-189: Add Apache Geode In...
Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/173#issuecomment-127940733
@bzz , the parasite commits are cleaned and the code is rebased to the latest zeppelin/master.
I've also committed a small change to allow control of the number of results displayed on the frontend: 0ff81c9.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---