You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by bo...@apache.org on 2008/05/22 02:10:10 UTC
svn commit: r658947 - in /apr/apr-util/branches/1.3.x: CHANGES test/dbd.c
test/testmemcache.c
Author: bojan
Date: Wed May 21 17:10:10 2008
New Revision: 658947
URL: http://svn.apache.org/viewvc?rev=658947&view=rev
Log:
Backport r658946 from the trunk.
Document that we're counting rows in DBD from 1.
Adjust DBD test to print rows from 1.
Remove an unused variable from memcache test.
Modified:
apr/apr-util/branches/1.3.x/CHANGES
apr/apr-util/branches/1.3.x/test/dbd.c
apr/apr-util/branches/1.3.x/test/testmemcache.c
Modified: apr/apr-util/branches/1.3.x/CHANGES
URL: http://svn.apache.org/viewvc/apr/apr-util/branches/1.3.x/CHANGES?rev=658947&r1=658946&r2=658947&view=diff
==============================================================================
--- apr/apr-util/branches/1.3.x/CHANGES [utf-8] (original)
+++ apr/apr-util/branches/1.3.x/CHANGES [utf-8] Wed May 21 17:10:10 2008
@@ -1,6 +1,10 @@
-*- coding: utf-8 -*-
Changes with APR-util 1.3.0
+ *) All DBD drivers now count rows from 1, which affects PostgreSQL and MySQL
+ drivers in particular. Using row number zero is an error.
+ [Bojan Smojver]
+
*) Add support for OpenLDAP's ability to support a directory of
certificate authorities. [Eric Covener]
Modified: apr/apr-util/branches/1.3.x/test/dbd.c
URL: http://svn.apache.org/viewvc/apr/apr-util/branches/1.3.x/test/dbd.c?rev=658947&r1=658946&r2=658947&view=diff
==============================================================================
--- apr/apr-util/branches/1.3.x/test/dbd.c (original)
+++ apr/apr-util/branches/1.3.x/test/dbd.c Wed May 21 17:10:10 2008
@@ -122,7 +122,7 @@
for (rv = apr_dbd_get_row(driver, pool, res, &row, -1);
rv == 0;
rv = apr_dbd_get_row(driver, pool, res, &row, -1)) {
- printf("ROW %d: ", i++) ;
+ printf("ROW %d: ", ++i) ;
for (n = 0; n < apr_dbd_num_cols(driver, res); ++n) {
entry = apr_dbd_get_entry(driver, row, n);
if (entry == NULL) {
@@ -295,7 +295,7 @@
for (rv = apr_dbd_get_row(driver, pool, res, &row, -1);
rv == 0;
rv = apr_dbd_get_row(driver, pool, res, &row, -1)) {
- printf("ROW %d: ", i++) ;
+ printf("ROW %d: ", ++i) ;
for (n = 0; n < apr_dbd_num_cols(driver, res); ++n) {
entry = apr_dbd_get_entry(driver, row, n);
if (entry == NULL) {
Modified: apr/apr-util/branches/1.3.x/test/testmemcache.c
URL: http://svn.apache.org/viewvc/apr/apr-util/branches/1.3.x/test/testmemcache.c?rev=658947&r1=658946&r2=658947&view=diff
==============================================================================
--- apr/apr-util/branches/1.3.x/test/testmemcache.c (original)
+++ apr/apr-util/branches/1.3.x/test/testmemcache.c Wed May 21 17:10:10 2008
@@ -367,7 +367,7 @@
apr_status_t rv;
apr_memcache_t *memcache;
apr_memcache_server_t *server;
- apr_uint32_t new, next = 2;
+ apr_uint32_t new;
char *result;
apr_size_t len;
apr_uint32_t i;