[jira] [Commented] (OFBIZ-10696) ConcurrentModificationException in ShoppingCart.cleanUpShipGroups

["Danny Trunk (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-10696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16712443#comment-16712443 ] 

Danny Trunk commented on OFBIZ-10696:
-------------------------------------

Unfortunately I cannot test it either. Someone in my company reported the exception from a log file. We cannot reproduce it certainly. But be aware that you simply check for the first iteration item if it's quantity is zero, not each item as it is the case now.

> ConcurrentModificationException in ShoppingCart.cleanUpShipGroups
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-10696
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10696
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Trunk
>            Reporter: Danny Trunk
>            Assignee: Jacques Le Roux
>            Priority: Major
>             Fix For: 17.12.01, 16.11.06
>
>         Attachments: OFBIZ-10696.diff
>
>
> {code:java}
> java.util.ConcurrentModificationException: null
>         at java.util.LinkedList$ListItr.checkForComodification(LinkedList.java:966) ~[?:1.8.0_181]
>         at java.util.LinkedList$ListItr.next(LinkedList.java:888) ~[?:1.8.0_181]
>         at org.apache.ofbiz.order.shoppingcart.ShoppingCart.cleanUpShipGroups(ShoppingCart.java:2199) ~[ofbiz.jar:?]
> {code}
> There's a for-loop over shipInfo and a call to clear inside this loop which leads to a ConcurrentModificationException: https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java?view=markup#l2251



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)