You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@iotdb.apache.org by "sunjincheng (Jira)" <ji...@apache.org> on 2021/02/17 12:28:00 UTC
[jira] [Commented] (IOTDB-1156) Improve the quality and efficiency
of code formatting
[ https://issues.apache.org/jira/browse/IOTDB-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17285807#comment-17285807 ]
sunjincheng commented on IOTDB-1156:
------------------------------------
Fixed in Master: a9f9f1d2d60b1c50a6c805e31839183a727b6cf4
> Improve the quality and efficiency of code formatting
> -----------------------------------------------------
>
> Key: IOTDB-1156
> URL: https://issues.apache.org/jira/browse/IOTDB-1156
> Project: Apache IoTDB
> Issue Type: Sub-task
> Components: Core/Others
> Reporter: sunjincheng
> Assignee: sunjincheng
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.12.0
>
>
> Although IoTDB has a check style specification, the unification of the current code format is still not well controlled, such as Missing spaces[1][2] or the most typical problems of mixing 2-space and 4-space in indents [3][4], etc.
> So, I would like to propose using Spotless for IoTDB coding style check, the detail can found in the discussion [5].
> [1] https://github.com/apache/iotdb/blob/05a628dd59256e94510307184a5ecb1d2a6da23f/cluster/src/main/java/org/apache/iotdb/cluster/ClientMain.java#L177
> [2] https://github.com/apache/iotdb/blob/05a628dd59256e94510307184a5ecb1d2a6da23f/cli/src/test/java/org/apache/iotdb/cli/AbstractScript.java#L65
> [3] https://github.com/apache/iotdb/blob/05a628dd59256e94510307184a5ecb1d2a6da23f/cluster/src/main/java/org/apache/iotdb/cluster/exception/EntryCompactedException.java#L24
> [4] https://github.com/apache/iotdb/blob/05a628dd59256e94510307184a5ecb1d2a6da23f/cluster/src/main/java/org/apache/iotdb/cluster/log/snapshot/FileSnapshot.java#L196
> [5] https://lists.apache.org/thread.html/rd07d66cc819bce546aced54d7f0b0ab4552a910a120f05fe900915dc%40%3Cdev.iotdb.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)