You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/08/05 13:40:25 UTC
[GitHub] [flink-table-store] SteNicholas opened a new pull request, #264: [FLINK-28754] Document that Java 8 is required to build table store
SteNicholas opened a new pull request, #264:
URL: https://github.com/apache/flink-table-store/pull/264
Flink Table Store can not be built with Java 11, but the "[build from source](https://nightlies.apache.org/flink/flink-table-store-docs-master/docs/engines/build)" instructions don't mention this restriction.
**The brief change log**
- Add the instructions of built with Java 11 in `build.md`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] alpinegizmo commented on a diff in pull request #264: [FLINK-28754] Document that Java 8 is required to build table store
Posted by GitBox <gi...@apache.org>.
alpinegizmo commented on code in PR #264:
URL: https://github.com/apache/flink-table-store/pull/264#discussion_r939695425
##########
docs/content/docs/engines/build.md:
##########
@@ -24,9 +24,15 @@ specific language governing permissions and limitations
under the License.
-->
-# Build From Source
+# Build from Source
-Clone from git, enter:
+In order to build Flink you need the source code. Either [download the source of a release]({{< downloads >}}) or [clone the git repository]({{< github_repo >}}).
+
+In addition you need **Maven 3** and a **JDK** (Java Development Kit). Flink Table Store requires **Java 8** to build.
+
+*NOTE: Maven 3.3.x can build Flink Table Store, but will not properly shade away certain dependencies. Maven 3.2.5 creates the libraries properly.*
Review Comment:
Flink needs maven 3.2.5 to get the shading right -- though work is ongoing to overcome this limitation -- but is it also true for the Table Store?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi merged pull request #264: [FLINK-28754] Document that Java 8 is required to build table store
Posted by GitBox <gi...@apache.org>.
JingsongLi merged PR #264:
URL: https://github.com/apache/flink-table-store/pull/264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] SteNicholas commented on pull request #264: [FLINK-28754] Document that Java 8 is required to build table store
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on PR #264:
URL: https://github.com/apache/flink-table-store/pull/264#issuecomment-1207586860
@JingsongLi, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] alpinegizmo commented on a diff in pull request #264: [FLINK-28754] Document that Java 8 is required to build table store
Posted by GitBox <gi...@apache.org>.
alpinegizmo commented on code in PR #264:
URL: https://github.com/apache/flink-table-store/pull/264#discussion_r939695277
##########
docs/content/docs/engines/build.md:
##########
@@ -24,9 +24,15 @@ specific language governing permissions and limitations
under the License.
-->
-# Build From Source
+# Build from Source
-Clone from git, enter:
+In order to build Flink you need the source code. Either [download the source of a release]({{< downloads >}}) or [clone the git repository]({{< github_repo >}}).
Review Comment:
```suggestion
In order to build the Flink Table Store you need the source code. Either [download the source of a release]({{< downloads >}}) or [clone the git repository]({{< github_repo >}}).
```
##########
docs/content/docs/engines/build.md:
##########
@@ -24,9 +24,15 @@ specific language governing permissions and limitations
under the License.
-->
-# Build From Source
+# Build from Source
-Clone from git, enter:
+In order to build Flink you need the source code. Either [download the source of a release]({{< downloads >}}) or [clone the git repository]({{< github_repo >}}).
+
+In addition you need **Maven 3** and a **JDK** (Java Development Kit). Flink Table Store requires **Java 8** to build.
+
+*NOTE: Maven 3.3.x can build Flink Table Store, but will not properly shade away certain dependencies. Maven 3.2.5 creates the libraries properly.*
Review Comment:
This is true for Flink -- though work is ongoing to overcome this limitation -- but is it also true for the Table Store?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] alpinegizmo commented on a diff in pull request #264: [FLINK-28754] Document that Java 8 is required to build table store
Posted by GitBox <gi...@apache.org>.
alpinegizmo commented on code in PR #264:
URL: https://github.com/apache/flink-table-store/pull/264#discussion_r939695425
##########
docs/content/docs/engines/build.md:
##########
@@ -24,9 +24,15 @@ specific language governing permissions and limitations
under the License.
-->
-# Build From Source
+# Build from Source
-Clone from git, enter:
+In order to build Flink you need the source code. Either [download the source of a release]({{< downloads >}}) or [clone the git repository]({{< github_repo >}}).
+
+In addition you need **Maven 3** and a **JDK** (Java Development Kit). Flink Table Store requires **Java 8** to build.
+
+*NOTE: Maven 3.3.x can build Flink Table Store, but will not properly shade away certain dependencies. Maven 3.2.5 creates the libraries properly.*
Review Comment:
Flink needs maven 3.2.5 to get the shading right -- though work is ongoing to overcome this limitation -- but is this also true for the Table Store?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org