You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/06/27 19:07:27 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #5408: [AIRFLOW-4763] Allow list in DockerOperator.command

mik-laj commented on a change in pull request #5408: [AIRFLOW-4763] Allow list in DockerOperator.command
URL: https://github.com/apache/airflow/pull/5408#discussion_r298326779
 
 

 ##########
 File path: airflow/operators/docker_operator.py
 ##########
 @@ -247,7 +247,7 @@ def execute(self, context):
                     if self.xcom_all else line.encode('utf-8')
 
     def get_command(self):
-        if self.command is not None and self.command.strip().find('[') == 0:
+        if isinstance(self.command, str) and self.command.strip().find('[') == 0:
 
 Review comment:
   When Jinja returns the "[" sign, an array is created. Please look at related PR: https://github.com/apache/airflow/pull/4900

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services