You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@weex.apache.org by Hanks10100 <gi...@git.apache.org> on 2017/10/09 08:35:41 UTC

[GitHub] incubator-weex pull request #770: [WEEX-78] Replace "includes" with "indexOf...

GitHub user Hanks10100 opened a pull request:

    https://github.com/apache/incubator-weex/pull/770

    [WEEX-78] Replace "includes" with "indexOf" to improve compatibility

    ### Problem
    
    `Array.prototype.includes` is defined in ECMAScript 2016 (ES7) which is not compatible with low version js engines.
    
    ### Solution
    
    Use `Array.prototype.indexOf` instead of `Array.prototype.includes`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Hanks10100/incubator-weex jsfm-bugfix-includes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/770.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #770
    
----
commit bdd651bb45c137e8f6bcf860029a399c79cffbf7
Author: Hanks <zh...@gmail.com>
Date:   2017-10-09T08:34:26Z

    * [jsfm] use "indexOf" instead of "includes" in Element.fireEvent

----


---

[GitHub] incubator-weex issue #770: [WEEX-78] Replace "includes" with "indexOf" to im...

Posted by Hanks10100 <gi...@git.apache.org>.

Github user Hanks10100 commented on the issue:

    https://github.com/apache/incubator-weex/pull/770
  
    Already merged. https://github.com/apache/incubator-weex/commit/d10be0bcf9624ca0f56fe8f60d646f71ed2f1aa0


---

[GitHub] incubator-weex issue #770: [WEEX-78] Replace "includes" with "indexOf" to im...

Posted by Hanks10100 <gi...@git.apache.org>.

Github user Hanks10100 commented on the issue:

    https://github.com/apache/incubator-weex/pull/770
  
    Fix [WEEX-78](https://issues.apache.org/jira/projects/WEEX/issues/WEEX-78).


---

[GitHub] incubator-weex pull request #770: [WEEX-78] Replace "includes" with "indexOf...

Posted by Hanks10100 <gi...@git.apache.org>.

Github user Hanks10100 closed the pull request at:

    https://github.com/apache/incubator-weex/pull/770


---

[GitHub] incubator-weex issue #770: [WEEX-78] Replace "includes" with "indexOf" to im...

Posted by weex-bot <gi...@git.apache.org>.

Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/770
  
    
    <!--
      0 failure: 
      2 warning:  No Changelog chan..., This PR should up...
      1 messages
      
    -->
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>No Changelog changes!</td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>This PR should update related documents as well. </td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>danger test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---