You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/17 14:46:17 UTC
[GitHub] [flink] zhijiangW commented on a change in pull request #8191:
[FLINK-12213][network] Pass TaskManagerMetricGroup into constructor of
NetworkEnvironment
zhijiangW commented on a change in pull request #8191: [FLINK-12213][network] Pass TaskManagerMetricGroup into constructor of NetworkEnvironment
URL: https://github.com/apache/flink/pull/8191#discussion_r276279559
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
##########
@@ -357,15 +357,16 @@ public static TaskExecutor startTaskManager(
TaskManagerServices taskManagerServices = TaskManagerServices.fromConfiguration(
taskManagerServicesConfiguration,
resourceID,
+ remoteAddress,
+ metricRegistry,
Review comment:
Yes it also makes sense to create the `TaskManagerMetricGroup` before `TaskManagerServices`. I just thought it should be regarded as a component of `TaskManagerServices` like `TaskManagerLocation`. Nevertheless from the aspect of minimal change, I am willing to make it separate as you suggested.
That is a good idea to extract the creation of `NetworkEnvironment` completely. I would do that in separate commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services