You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "kayx23 (via GitHub)" <gi...@apache.org> on 2023/05/09 06:23:26 UTC
[GitHub] [apisix] kayx23 opened a new issue, #9441: Stream Route `remote_addr` Naming Suggestion
kayx23 opened a new issue, #9441:
URL: https://github.com/apache/apisix/issues/9441
### Description
## Current State
`remote_addr` in a stream route is used to filter requests by client's IP address. The naming of this attribute is confusing. It is difficult to tell if `remote_addr` means upstream service or downstream client's IP.
## Suggestion
Rename `remote_addr` to `client_addr` or similar
## Relevant Docs
* [Admin API Stream Routes](https://apisix.apache.org/docs/apisix/admin-api/#stream-route-api)
* [Stream Proxy doc](https://apisix.apache.org/docs/apisix/next/stream-proxy/)
### Environment
latest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] kayx23 closed issue #9441: Stream Route `remote_addr` Naming Suggestion
Posted by "kayx23 (via GitHub)" <gi...@apache.org>.
kayx23 closed issue #9441: Stream Route `remote_addr` Naming Suggestion
URL: https://github.com/apache/apisix/issues/9441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] kayx23 commented on issue #9441: Stream Route `remote_addr` Naming Suggestion
Posted by "kayx23 (via GitHub)" <gi...@apache.org>.
kayx23 commented on issue #9441:
URL: https://github.com/apache/apisix/issues/9441#issuecomment-1543653851
ok I see. Thanks for the clarification! Issue closed.
Traky
On Wed, May 10, 2023 at 8:07 PM Fatih Bayram ***@***.***>
wrote:
> The remote_addr variable is an embedded variable used by Nginx that
> provides information about the client address. This variable is critical in
> Nginx's internal workings and is necessary for properly routing HTTP
> requests. Therefore, renaming this variable to client_addr or something
> similar could cause Nginx to behave unexpectedly or produce errors.
> http://nginx.org/en/docs/http/ngx_http_core_module.html
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/apisix/issues/9441#issuecomment-1542089322>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AJOIYDYMOQV56VJFOU5VVNTXFOAG3ANCNFSM6AAAAAAX3AGLGM>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] fatihbm commented on issue #9441: Stream Route `remote_addr` Naming Suggestion
Posted by "fatihbm (via GitHub)" <gi...@apache.org>.
fatihbm commented on issue #9441:
URL: https://github.com/apache/apisix/issues/9441#issuecomment-1542089322
The `remote_addr` variable is an embedded variable used by Nginx that provides information about the client address. This variable is critical in Nginx's internal workings and is necessary for properly routing HTTP requests. Therefore, renaming this variable to `client_addr` or something similar could cause Nginx to behave unexpectedly or produce errors.
http://nginx.org/en/docs/http/ngx_http_core_module.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] kayx23 commented on issue #9441: Stream Route `remote_addr` Naming Suggestion
Posted by "kayx23 (via GitHub)" <gi...@apache.org>.
kayx23 commented on issue #9441:
URL: https://github.com/apache/apisix/issues/9441#issuecomment-1543459908
@fatihbm ok I see, thanks for sharing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org