You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org> on 2007/04/25 23:26:15 UTC

[jira] Updated: (WICKET-501) javascript comment stripping is erroneous

     [ https://issues.apache.org/jira/browse/WICKET-501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Quenot updated WICKET-501:
----------------------------------------

    Attachment: 20070425-WICKET-501-JavascriptStripper.txt

The attached patch (with unit test) fixes compression for JavaScript files using CR line endings (Macintosh).  Can you try to attach your own test?  I can't reproduce the exact same problem.

> javascript comment stripping is erroneous
> -----------------------------------------
>
>                 Key: WICKET-501
>                 URL: https://issues.apache.org/jira/browse/WICKET-501
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>            Reporter: Peter Ertl
>            Priority: Critical
>         Attachments: 20070425-WICKET-501-JavascriptStripper.txt
>
>
> The following line is crippled when using javascript comment stripping
> (from jquery.js)
>     // Handle the common XPath // expression
>     if ( !t.indexOf("//") ) {
> it will be result in
>     if ( !t.indexOf("
> the // inside the string quotes are taken as a comment instead of as a string...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.