You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/16 02:06:23 UTC

[GitHub] [airflow] jithin97 commented on issue #7159: [AIRFLOW-6553] [UI] Add upstream_failed in instance state filter

jithin97 commented on issue #7159: [AIRFLOW-6553] [UI] Add upstream_failed in instance state filter
URL: https://github.com/apache/airflow/pull/7159#issuecomment-574946733
 
 
   > When making UI changes like this it's helpful to include a before-and-after. Could you please?
   > 
   > It's probably fine, but by you include a screen shot it makes it easier for the reviewer to check the colours used are sensible.
   
   @ashb Thanks!!!
   
   **Before:**
   <img width="488" alt="Screen Shot 2020-01-13 at 15 03 50" src="https://user-images.githubusercontent.com/13610191/72486901-a0d35e00-384f-11ea-8d36-8522c8719d23.png">
   
   **After**
   ![Screen Shot 2020-01-16 at 10 59 25](https://user-images.githubusercontent.com/13610191/72486885-93b66f00-384f-11ea-8429-81c8d8419169.png)
   ![Screen Shot 2020-01-16 at 11 00 42](https://user-images.githubusercontent.com/13610191/72486890-9749f600-384f-11ea-946d-879b46f40586.png)
   
   BTW this is where I took the color from. https://github.com/apache/airflow/blob/1.10.7/airflow/utils/state.py#L77

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services