You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ze...@apache.org on 2022/07/27 19:21:48 UTC
[arrow] branch master updated: MINOR: [Go] fill in field names of struct literal (#13723)
This is an automated email from the ASF dual-hosted git repository.
zeroshade pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new 71ccff9c12 MINOR: [Go] fill in field names of struct literal (#13723)
71ccff9c12 is described below
commit 71ccff9c12657070c1c39e66b9779896f698b280
Author: Matt Topol <zo...@gmail.com>
AuthorDate: Wed Jul 27 15:21:42 2022 -0400
MINOR: [Go] fill in field names of struct literal (#13723)
I just wanted the annoying "Problems" number to go away by fixing this little lint situation that was annoying me by saying that the struct literal was using un-keyed fields.
This is an extremely minor simple change.
Authored-by: Matt Topol <zo...@gmail.com>
Signed-off-by: Matt Topol <zo...@gmail.com>
---
go/arrow/array/interval_test.go | 22 ++++++++++++++++------
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/go/arrow/array/interval_test.go b/go/arrow/array/interval_test.go
index c044bc588a..f5d91e8f77 100644
--- a/go/arrow/array/interval_test.go
+++ b/go/arrow/array/interval_test.go
@@ -156,7 +156,9 @@ func TestDayTimeArray(t *testing.T) {
defer mem.AssertSize(t, 0)
var (
- want = []arrow.DayTimeInterval{{1, 1}, {2, 2}, {3, 3}, {4, 4}}
+ want = []arrow.DayTimeInterval{
+ {Days: 1, Milliseconds: 1}, {Days: 2, Milliseconds: 2},
+ {Days: 3, Milliseconds: 3}, {Days: 4, Milliseconds: 4}}
valids = []bool{true, true, false, true}
)
@@ -240,7 +242,9 @@ func TestDayTimeIntervalBuilder_Empty(t *testing.T) {
mem := memory.NewCheckedAllocator(memory.NewGoAllocator())
defer mem.AssertSize(t, 0)
- want := []arrow.DayTimeInterval{{1, 1}, {2, 2}, {3, 3}, {4, 4}}
+ want := []arrow.DayTimeInterval{
+ {Days: 1, Milliseconds: 1}, {Days: 2, Milliseconds: 2},
+ {Days: 3, Milliseconds: 3}, {Days: 4, Milliseconds: 4}}
b := array.NewDayTimeIntervalBuilder(mem)
defer b.Release()
@@ -282,9 +286,11 @@ func TestMonthDayNanoArray(t *testing.T) {
var (
want = []arrow.MonthDayNanoInterval{
- {1, 1, 1000}, {2, 2, 2000}, {3, 3, 3000}, {4, 4, 4000},
- {0, 0, 0}, {-1, -2, -300}, {math.MaxInt32, math.MinInt32, math.MaxInt64},
- {math.MinInt32, math.MaxInt32, math.MinInt64},
+ {Months: 1, Days: 1, Nanoseconds: 1000}, {Months: 2, Days: 2, Nanoseconds: 2000},
+ {Months: 3, Days: 3, Nanoseconds: 3000}, {Months: 4, Days: 4, Nanoseconds: 4000},
+ {Months: 0, Days: 0, Nanoseconds: 0}, {Months: -1, Days: -2, Nanoseconds: -300},
+ {Months: math.MaxInt32, Days: math.MinInt32, Nanoseconds: math.MaxInt64},
+ {Months: math.MinInt32, Days: math.MaxInt32, Nanoseconds: math.MinInt64},
}
valids = []bool{true, true, false, true, true, true, false, true}
)
@@ -370,7 +376,11 @@ func TestMonthDayNanoIntervalBuilder_Empty(t *testing.T) {
mem := memory.NewCheckedAllocator(memory.NewGoAllocator())
defer mem.AssertSize(t, 0)
- want := []arrow.MonthDayNanoInterval{{1, 1, 1000}, {2, 2, 2000}, {3, 3, 3000}, {4, 4, 4000}}
+ want := []arrow.MonthDayNanoInterval{
+ {Months: 1, Days: 1, Nanoseconds: 1000},
+ {Months: 2, Days: 2, Nanoseconds: 2000},
+ {Months: 3, Days: 3, Nanoseconds: 3000},
+ {Months: 4, Days: 4, Nanoseconds: 4000}}
b := array.NewMonthDayNanoIntervalBuilder(mem)
defer b.Release()