You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ta...@apache.org on 2016/04/04 22:54:02 UTC
qpid-jms git commit: QPIDJMS-166 Remve some additional outdated TODOs
Repository: qpid-jms
Updated Branches:
refs/heads/master e4fc8eef5 -> 52a4a6eaa
QPIDJMS-166 Remve some additional outdated TODOs
Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/52a4a6ea
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/52a4a6ea
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/52a4a6ea
Branch: refs/heads/master
Commit: 52a4a6eaa6664b3a9cfbe19c221e967f3c5e0288
Parents: e4fc8ee
Author: Timothy Bish <ta...@gmail.com>
Authored: Mon Apr 4 16:53:55 2016 -0400
Committer: Timothy Bish <ta...@gmail.com>
Committed: Mon Apr 4 16:53:55 2016 -0400
----------------------------------------------------------------------
.../src/main/java/org/apache/qpid/jms/JmsSession.java | 2 --
.../apache/qpid/jms/provider/amqp/AmqpConnectionProperties.java | 4 ----
.../java/org/apache/qpid/jms/provider/amqp/AmqpConsumer.java | 2 +-
3 files changed, 1 insertion(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/52a4a6ea/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsSession.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsSession.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsSession.java
index a9ef004..4a10a4e 100644
--- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsSession.java
+++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsSession.java
@@ -914,8 +914,6 @@ public class JmsSession implements AutoCloseable, Session, QueueSession, TopicSe
@Override
public void onInboundMessage(JmsInboundMessageDispatch envelope) {
- // TODO: is onInboundMessage ever called on the Session?
- // Seems like we might only call it on consumers from within the connection.
if (started.get()) {
deliver(envelope);
} else {
http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/52a4a6ea/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConnectionProperties.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConnectionProperties.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConnectionProperties.java
index 1f22f57..79a0d95 100644
--- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConnectionProperties.java
+++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConnectionProperties.java
@@ -78,8 +78,6 @@ public class AmqpConnectionProperties {
if (list.contains(ANONYMOUS_RELAY)) {
anonymousRelaySupported = true;
}
-
- // TODO - Inspect capabilities for any other configuration options
}
protected void processProperties(Map<Symbol, Object> properties) {
@@ -103,8 +101,6 @@ public class AmqpConnectionProperties {
LOG.trace("Remote sent Connection Establishment Failed marker.");
connectionOpenFailed = true;
}
-
- // TODO - Inspect properties for any other configuration options
}
/**
http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/52a4a6ea/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConsumer.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConsumer.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConsumer.java
index 054b438..52d0db6 100644
--- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConsumer.java
+++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConsumer.java
@@ -280,7 +280,7 @@ public class AmqpConsumer extends AmqpAbstractResource<JmsConsumerInfo, Receiver
*/
private void sendFlowIfNeeded() {
if (getResourceInfo().getPrefetchSize() == 0 || isStopping()) {
- // TODO: isStopping isnt effective when this method is called following
+ // TODO: isStopping isn't effective when this method is called following
// processing the last of any messages received while stopping, since that
// happens just after we stopped. That may be ok in some situations however, and
// if will only happen if prefetchSize != 0.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org