You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Gautam Borad <gb...@gmail.com> on 2015/09/14 09:38:23 UTC
Review Request 38340: RANGER-646 : Policy UI updates for the changes
in policy model to support policyItems of type
allow/deny/allow-exception/deny-exception
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38340/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-646
https://issues.apache.org/jira/browse/RANGER-646
Repository: ranger
Description
-------
Ranger policy model currently supports policy-items of type "allow". The model has been updated to support additional policy-items of type deny/allow-exception/deny-exception.
Ranger policy create/edit UI has been updated to show these additional policy-item types. Also updated other places where the Policy View is shown ( like audit etc. )
Diffs
-----
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js be18c99
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 6532957
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 2af43bc
security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html 50a5f45
security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 9627b09
Diff: https://reviews.apache.org/r/38340/diff/
Testing
-------
Tested on local Ranger setup for create / update policy of policyItems with (allow, deny, allow-exception, deny-exception) permissions.
Thanks,
Gautam Borad
Re: Review Request 38340: RANGER-646 : Policy UI updates for the
changes in policy model to support policyItems of type
allow/deny/allow-exception/deny-exception
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38340/#review98861
-----------------------------------------------------------
Ship it!
Once the review comments are addressed, this update is good to commit.
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js (line 124)
<https://reviews.apache.org/r/38340/#comment155485>
Please change "Allow Exclusion" to "Allow Exceptions"; "Deny Exclusion" to "Deny Exceptions"
security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html (line 47)
<https://reviews.apache.org/r/38340/#comment155484>
Please change "Exclusions" to "Exceptions".
security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html (line 77)
<https://reviews.apache.org/r/38340/#comment155486>
Please change "Exclusions" to "Exceptions".
- Madhan Neethiraj
On Sept. 14, 2015, 7:38 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38340/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 7:38 a.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-646
> https://issues.apache.org/jira/browse/RANGER-646
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ranger policy model currently supports policy-items of type "allow". The model has been updated to support additional policy-items of type deny/allow-exception/deny-exception.
> Ranger policy create/edit UI has been updated to show these additional policy-item types. Also updated other places where the Policy View is shown ( like audit etc. )
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js be18c99
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 6532957
> security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 2af43bc
> security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html 50a5f45
> security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 9627b09
>
> Diff: https://reviews.apache.org/r/38340/diff/
>
>
> Testing
> -------
>
> Tested on local Ranger setup for create / update policy of policyItems with (allow, deny, allow-exception, deny-exception) permissions.
>
>
> Thanks,
>
> Gautam Borad
>
>