You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2023/01/02 07:49:43 UTC
[GitHub] [dubbo] baerwang opened a new pull request, #11228: style：optimization-log4j
baerwang opened a new pull request, #11228:
URL: https://github.com/apache/dubbo/pull/11228
## What is the purpose of the change
optimization log4j
## Brief changelog
## Verifying this change
<!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
## Checklist
- [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
- [ ] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] baerwang closed pull request #11228: style：optimization-log4j
Posted by GitBox <gi...@apache.org>.
baerwang closed pull request #11228: style：optimization-log4j
URL: https://github.com/apache/dubbo/pull/11228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] baerwang commented on a diff in pull request #11228: style：optimization-log4j
Posted by GitBox <gi...@apache.org>.
baerwang commented on code in PR #11228:
URL: https://github.com/apache/dubbo/pull/11228#discussion_r1061189827
##########
dubbo-common/src/main/java/org/apache/dubbo/common/logger/log4j/Log4jLoggerAdapter.java:
##########
@@ -26,11 +26,32 @@
import java.io.File;
import java.util.Enumeration;
+import java.util.HashMap;
+import java.util.Map;
public class Log4jLoggerAdapter implements LoggerAdapter {
private File file;
+ private static final Map<Level, org.apache.log4j.Level> toLevel = new HashMap<>();
+ private static final Map<org.apache.log4j.Level, Level> toApacheLevel = new HashMap<>();
+
+ static {
+ toLevel.put(Level.ALL, org.apache.log4j.Level.ALL);
+ toLevel.put(Level.TRACE, org.apache.log4j.Level.TRACE);
+ toLevel.put(Level.DEBUG, org.apache.log4j.Level.DEBUG);
+ toLevel.put(Level.INFO, org.apache.log4j.Level.INFO);
+ toLevel.put(Level.WARN, org.apache.log4j.Level.WARN);
+ toLevel.put(Level.ERROR, org.apache.log4j.Level.ERROR);
+
+ toApacheLevel.put(org.apache.log4j.Level.ALL, Level.ALL);
+ toApacheLevel.put(org.apache.log4j.Level.TRACE, Level.TRACE);
+ toApacheLevel.put(org.apache.log4j.Level.DEBUG, Level.DEBUG);
+ toApacheLevel.put(org.apache.log4j.Level.INFO, Level.INFO);
+ toApacheLevel.put(org.apache.log4j.Level.WARN, Level.WARN);
+ toApacheLevel.put(org.apache.log4j.Level.ERROR, Level.ERROR);
Review Comment:
you re right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #11228: style：optimization-log4j
Posted by GitBox <gi...@apache.org>.
AlbumenJ commented on code in PR #11228:
URL: https://github.com/apache/dubbo/pull/11228#discussion_r1060319174
##########
dubbo-common/src/main/java/org/apache/dubbo/common/logger/log4j/Log4jLoggerAdapter.java:
##########
@@ -26,11 +26,32 @@
import java.io.File;
import java.util.Enumeration;
+import java.util.HashMap;
+import java.util.Map;
public class Log4jLoggerAdapter implements LoggerAdapter {
private File file;
+ private static final Map<Level, org.apache.log4j.Level> toLevel = new HashMap<>();
+ private static final Map<org.apache.log4j.Level, Level> toApacheLevel = new HashMap<>();
+
+ static {
+ toLevel.put(Level.ALL, org.apache.log4j.Level.ALL);
+ toLevel.put(Level.TRACE, org.apache.log4j.Level.TRACE);
+ toLevel.put(Level.DEBUG, org.apache.log4j.Level.DEBUG);
+ toLevel.put(Level.INFO, org.apache.log4j.Level.INFO);
+ toLevel.put(Level.WARN, org.apache.log4j.Level.WARN);
+ toLevel.put(Level.ERROR, org.apache.log4j.Level.ERROR);
+
+ toApacheLevel.put(org.apache.log4j.Level.ALL, Level.ALL);
+ toApacheLevel.put(org.apache.log4j.Level.TRACE, Level.TRACE);
+ toApacheLevel.put(org.apache.log4j.Level.DEBUG, Level.DEBUG);
+ toApacheLevel.put(org.apache.log4j.Level.INFO, Level.INFO);
+ toApacheLevel.put(org.apache.log4j.Level.WARN, Level.WARN);
+ toApacheLevel.put(org.apache.log4j.Level.ERROR, Level.ERROR);
Review Comment:
This may cause `NoClassDefFoundError` if log4j's dependency is absent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org