You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Alex Huang <Al...@citrix.com> on 2013/07/18 19:01:54 UTC
Why are these code in utils?
As part of the work to merge vmsync over to master, I've been combing through our code.
I'm surprised to find the following code in the utils package.
Cisco n1kv.vsm
S3
Swift
The intent of the utils package is to provide generic java software libraries that all other cloudstack libraries to use. These packages do not belong here.
--Alex
RE: Why are these code in utils?
Posted by Alex Huang <Al...@citrix.com>.
+1
> -----Original Message-----
> From: John Burwell [mailto:jburwell@basho.com]
> Sent: Thursday, July 18, 2013 12:25 PM
> To: dev@cloudstack.apache.org
> Subject: Re: Why are these code in utils?
>
> Edison,
>
> I suggest creating a utils model in engine/storage in package
> org.apache.cloudstack.engine.storage.utils. When I Swift and S3 were
> originally implemented, we didn't have such a good place to put these types
> of classes. Now that we have a more robust module structure, it seems
> appropriate to move them out.
>
> Thanks,
> -John
>
> On Jul 18, 2013, at 1:53 PM, Edison Su <Ed...@citrix.com> wrote:
>
> > For s3/swift, both secondary storage code and storage plugin will access
> S3/Swift library.
> > What you suggestion to put these library?
> >
> >> -----Original Message-----
> >> From: Alex Huang [mailto:Alex.Huang@citrix.com]
> >> Sent: Thursday, July 18, 2013 10:02 AM
> >> To: dev@cloudstack.apache.org
> >> Subject: Why are these code in utils?
> >>
> >> As part of the work to merge vmsync over to master, I've been combing
> >> through our code.
> >>
> >> I'm surprised to find the following code in the utils package.
> >>
> >> Cisco n1kv.vsm
> >> S3
> >> Swift
> >>
> >> The intent of the utils package is to provide generic java software
> >> libraries that all other cloudstack libraries to use. These packages do not
> belong here.
> >>
> >> --Alex
> >
Re: Why are these code in utils?
Posted by John Burwell <jb...@basho.com>.
Edison,
I suggest creating a utils model in engine/storage in package org.apache.cloudstack.engine.storage.utils. When I Swift and S3 were originally implemented, we didn't have such a good place to put these types of classes. Now that we have a more robust module structure, it seems appropriate to move them out.
Thanks,
-John
On Jul 18, 2013, at 1:53 PM, Edison Su <Ed...@citrix.com> wrote:
> For s3/swift, both secondary storage code and storage plugin will access S3/Swift library.
> What you suggestion to put these library?
>
>> -----Original Message-----
>> From: Alex Huang [mailto:Alex.Huang@citrix.com]
>> Sent: Thursday, July 18, 2013 10:02 AM
>> To: dev@cloudstack.apache.org
>> Subject: Why are these code in utils?
>>
>> As part of the work to merge vmsync over to master, I've been combing
>> through our code.
>>
>> I'm surprised to find the following code in the utils package.
>>
>> Cisco n1kv.vsm
>> S3
>> Swift
>>
>> The intent of the utils package is to provide generic java software libraries
>> that all other cloudstack libraries to use. These packages do not belong here.
>>
>> --Alex
>
RE: Why are these code in utils?
Posted by Edison Su <Ed...@citrix.com>.
For s3/swift, both secondary storage code and storage plugin will access S3/Swift library.
What you suggestion to put these library?
> -----Original Message-----
> From: Alex Huang [mailto:Alex.Huang@citrix.com]
> Sent: Thursday, July 18, 2013 10:02 AM
> To: dev@cloudstack.apache.org
> Subject: Why are these code in utils?
>
> As part of the work to merge vmsync over to master, I've been combing
> through our code.
>
> I'm surprised to find the following code in the utils package.
>
> Cisco n1kv.vsm
> S3
> Swift
>
> The intent of the utils package is to provide generic java software libraries
> that all other cloudstack libraries to use. These packages do not belong here.
>
> --Alex
Re: Why are these code in utils?
Posted by Prasanna Santhanam <ts...@apache.org>.
On Thu, Jul 18, 2013 at 05:01:54PM +0000, Alex Huang wrote:
> As part of the work to merge vmsync over to master, I've been combing through our code.
>
> I'm surprised to find the following code in the utils package.
>
> Cisco n1kv.vsm
> S3
> Swift
>
> The intent of the utils package is to provide generic java software
> libraries that all other cloudstack libraries to use. These
> packages do not belong here.
>
> --Alex
I was going to pull in another item into utils wherein OTW params sent
as maps could be translated to what the service layer expects as
Map<String,String> but wasn't sure if it should go here. I guess it
should now that you mention it?
--
Prasanna.,
------------------------
Powered by BigRock.com