[jira] [Commented] (HBASE-3052) Add ability to have multiple ZK servers in a quorum in MiniZooKeeperCluster for test writing

["Jonathan Gray (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009454#comment-13009454 ] 

Jonathan Gray commented on HBASE-3052:
--------------------------------------

Patch is looking good but I'm confused by a few things.

Are you starting all the servers at the beginning?  Or do the ZK servers only actually start/run once you kill another one?

The idea for this is to create a ZK quorum of servers and then be able to kill individual ones.  Ideally, we'd also be able to specifically kill whichever server is the quorum leader.

Also, I'm unclear on the meaning of "candidate" in this context.  Is the candidate server the "active" server?  Does that mean it's online?  Maybe change the name or at least add some javadoc explaining what exactly is happening.

> Add ability to have multiple ZK servers in a quorum in MiniZooKeeperCluster for test writing
> --------------------------------------------------------------------------------------------
>
>                 Key: HBASE-3052
>                 URL: https://issues.apache.org/jira/browse/HBASE-3052
>             Project: HBase
>          Issue Type: Improvement
>          Components: test, zookeeper
>            Reporter: Jonathan Gray
>            Assignee: Liyin Tang
>            Priority: Minor
>         Attachments: HBASE_3052[r1083993].patch
>
>
> Interesting things can happen when you have a ZK quorum of multiple servers and one of them dies.  Doing testing here on clusters, this has turned up some bugs with HBase interaction with ZK.
> Would be good to add the ability to have multiple ZK servers in unit tests and be able to kill them individually.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira