You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <bl...@incubator.apache.org> on 2012/04/28 04:04:08 UTC
[Apache Bloodhound] #45: Refine XML markup to embed dashboard
layouts and widgets
#45: Refine XML markup to embed dashboard layouts and widgets
--------------------------------------------------+--------------------
Reporter: olemis | Owner: nobody
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: dashboard | Version:
Keywords: markup widget layout genshi template |
--------------------------------------------------+--------------------
Right now a combination of XML + JSON has to be inserted in Genshi
templates so as to embed widgets and layouts implemented by dashboard
plugin .
For some reasons it's better to implement this feature using ''XML''
instead. Nonetheless my previous attempt trying to get this done was not
as successful as I expected .
Further details may be found in comments in Genshi templates included in
dashboard plugin
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/45>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #45: Refine XML markup to embed dashboard
layouts and widgets
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#45: Refine XML markup to embed dashboard layouts and widgets
-------------------------+-------------------------------------------------
Reporter: olemis | Owner: gjm
Type: | Status: review
enhancement | Milestone: Release 3
Priority: minor | Version:
Component: dashboard | Keywords: markup widget layout genshi
Resolution: | template
-------------------------+-------------------------------------------------
Changes (by olemis):
* status: accepted => review
* owner: olemis => gjm
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/45#comment:9>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #45: Refine XML markup to embed dashboard
layouts and widgets
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#45: Refine XML markup to embed dashboard layouts and widgets
-------------------------+-------------------------------------------------
Reporter: olemis | Owner: olemis
Type: | Status: accepted
enhancement | Milestone: Release 2
Priority: minor | Version:
Component: dashboard | Keywords: markup widget layout genshi
Resolution: | template
-------------------------+-------------------------------------------------
Old description:
> Right now a combination of XML + JSON has to be inserted in Genshi
> templates so as to embed widgets and layouts implemented by dashboard
> plugin .
>
> For some reasons it's better to implement this feature using ''XML''
> instead. My initial attempt trying to get this done was not as successful
> as I expected but eventually a solution will come up handy .
>
> For instance , widget markup in the early days (prior to r1351312 )
> looked like the snippet shown below
>
> {{{
> #!xml
>
> <bh:widget id="simple_widget" urn="WidgetName" altlinks="false">
> <bh:args>
> {"args" : {"arg1" : "value1",
> "arg2" : "value2"
> }
> }
> </bh:args>
> </bh:widget>
>
> }}}
>
> ... whereas in current implementation ''only XML'' is needed (which is
> more suitable to use together with ''Genshi'' statements e.g. `py:for` ,
> `py:if` ... )
>
> {{{
> #!xml
>
> <bh:widget id="simple_widget" urn="WidgetName" altlinks="false">
> <bh:args>
> <bh:arg name="arg1">value1</bh:arg>
> <bh:arg name="arg2">value2</bh:arg>
> </bh:args>
> </bh:widget>
>
> }}}
>
> Further details may be found in comments in Genshi templates included in
> dashboard plugin
New description:
Right now a combination of XML + JSON has to be inserted in Genshi
templates so as to embed widgets and layouts implemented by dashboard
plugin .
For some reasons it's better to implement this feature using ''XML''
instead. My initial attempt trying to get this done was not as successful
as I expected but eventually a solution will come up handy .
For instance , widget markup in the early days (prior to r1351312 ) looked
like the snippet shown below
{{{
#!xml
<bh:widget id="simple_widget" urn="WidgetName" altlinks="false">
<bh:args>
{"args" : {"arg1" : "value1",
"arg2" : "value2"
}
}
</bh:args>
</bh:widget>
}}}
... whereas in current implementation ''only XML'' is needed (which is
more suitable to use together with ''Genshi'' statements e.g. `py:for` ,
`py:if` ... )
{{{
#!xml
<bh:widget id="simple_widget" urn="WidgetName" altlinks="false">
<bh:args>
<bh:arg name="arg1">value1</bh:arg>
<bh:arg name="arg2">value2</bh:arg>
</bh:args>
</bh:widget>
}}}
[attachment:bh_milestone_view.html Sample file] illustrates the use of
markup to embed (nested) layouts in ''Genshi'' templates.
Further details may be found in comments in Genshi templates included in
dashboard plugin
--
Comment (by olemis):
Attached two patches implementing markup to embed layouts in ''Genshi''
templates . [attachment:t45_r1357341_layout_xml.diff First one] implements
necessary logic needed for this to happen . Some
[attachment:t45_r1357341_widget_markup_doctests.diff doctests] available
as well . Apply patches against r1357341 in the following order :
{{{
#!sh
$ hg qapplied
t45/t45_r1357341_layout_xml.diff
t45/t45_r1357341_widget_markup_doctests.diff
}}}
Everything was tested using [attachment:bh_milestone_view.html sample
Genshi template] to obtain a modified version of milestone view. It all
looks like shown below . Please take a look at the usage of nested layouts
[[Image(bh_theme_x_47_layout_markup_1.png, width=600)]]
[[Image(bh_theme_x_48_layout_markup_2.png, width=600)]]
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/45#comment:8>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #45: Refine XML markup to embed dashboard
layouts and widgets
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#45: Refine XML markup to embed dashboard layouts and widgets
-------------------------+-------------------------------------------------
Reporter: olemis | Owner: olemis
Type: | Status: accepted
enhancement | Milestone: RC1 for initial release
Priority: minor | Version:
Component: dashboard | Keywords: markup widget layout genshi
Resolution: | template
-------------------------+-------------------------------------------------
Changes (by olemis):
* owner: nobody => olemis
* status: new => accepted
* milestone: => RC1 for initial release
Comment:
This ticket is related to #93 as changes in there seem to require improved
markup to embed layouts and widgets .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/45#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #45: Refine XML markup to embed dashboard
layouts and widgets
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#45: Refine XML markup to embed dashboard layouts and widgets
-------------------------+-------------------------------------------------
Reporter: olemis | Owner: olemis
Type: | Status: accepted
enhancement | Milestone: RC1 for initial release
Priority: minor | Version:
Component: dashboard | Keywords: markup widget layout genshi
Resolution: | template
-------------------------+-------------------------------------------------
Comment (by gjm):
r1351312 applies t45_r1345273_widget_xml_bh_args.diff​
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/45#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #45: Refine XML markup to embed dashboard
layouts and widgets
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#45: Refine XML markup to embed dashboard layouts and widgets
-------------------------+-------------------------------------------------
Reporter: olemis | Owner: olemis
Type: | Status: accepted
enhancement | Milestone: Release 2
Priority: minor | Version:
Component: dashboard | Keywords: markup widget layout genshi
Resolution: | template
-------------------------+-------------------------------------------------
Changes (by olemis):
* milestone: RC1 for initial release => Release 2
Comment:
The patch to enhance markup in order to insert layouts in ''Genshi''
templates should be scheduled for next release . Please feel free to
revert this decision if this feature will be needed sooner for '''RC1''' .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/45#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #45: Refine XML markup to embed dashboard
layouts and widgets
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#45: Refine XML markup to embed dashboard layouts and widgets
-------------------------+-------------------------------------------------
Reporter: olemis | Owner: olemis
Type: | Status: accepted
enhancement | Milestone: RC1 for initial release
Priority: minor | Version:
Component: dashboard | Keywords: markup widget layout genshi
Resolution: | template
-------------------------+-------------------------------------------------
Comment (by olemis):
Please take a look at [comment:ticket:93:16 instructions to apply this
patch] .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/45#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #45: Refine XML markup to embed dashboard
layouts and widgets
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#45: Refine XML markup to embed dashboard layouts and widgets
-------------------------+-------------------------------------------------
Reporter: olemis | Owner: olemis
Type: | Status: accepted
enhancement | Milestone: RC1 for initial release
Priority: minor | Version:
Component: dashboard | Keywords: markup widget layout genshi
Resolution: | template
-------------------------+-------------------------------------------------
Description changed by olemis:
Old description:
> Right now a combination of XML + JSON has to be inserted in Genshi
> templates so as to embed widgets and layouts implemented by dashboard
> plugin .
>
> For some reasons it's better to implement this feature using ''XML''
> instead. For instance , widget markup looked like shown below in the
> early days (prior to r1351312 ) looked like the snippet shown below
>
> {{{
> #!xml
>
> <bh:widget id="simple_widget" urn="WidgetName" altlinks="false">
> <bh:args>
> {"args" : {"arg1" : "value1",
> "arg2" : "value2"
> }
> }
> </bh:args>
> </bh:widget>
>
> }}}
>
> ... whereas in current implementation ''only XML'' is needed (which is
> more suitable to use together with ''Genshi'' statements e.g. `py:for` ,
> `py:if` ... )
>
> {{{
> #!xml
>
> <bh:widget id="simple_widget" urn="WidgetName" altlinks="false">
> <bh:args>
> <bh:arg name="arg1">value1</bh:arg>
> <bh:arg name="arg2">value2</bh:arg>
> </bh:args>
> </bh:widget>
>
> }}}
>
> Nonetheless my initial attempt trying to get this done was not as
> successful as I expected .
>
> Further details may be found in comments in Genshi templates included in
> dashboard plugin
New description:
Right now a combination of XML + JSON has to be inserted in Genshi
templates so as to embed widgets and layouts implemented by dashboard
plugin .
For some reasons it's better to implement this feature using ''XML''
instead. My initial attempt trying to get this done was not as successful
as I expected but eventually a solution will come up handy .
For instance , widget markup in the early days (prior to r1351312 ) looked
like the snippet shown below
{{{
#!xml
<bh:widget id="simple_widget" urn="WidgetName" altlinks="false">
<bh:args>
{"args" : {"arg1" : "value1",
"arg2" : "value2"
}
}
</bh:args>
</bh:widget>
}}}
... whereas in current implementation ''only XML'' is needed (which is
more suitable to use together with ''Genshi'' statements e.g. `py:for` ,
`py:if` ... )
{{{
#!xml
<bh:widget id="simple_widget" urn="WidgetName" altlinks="false">
<bh:args>
<bh:arg name="arg1">value1</bh:arg>
<bh:arg name="arg2">value2</bh:arg>
</bh:args>
</bh:widget>
}}}
Further details may be found in comments in Genshi templates included in
dashboard plugin
--
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/45#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #45: Refine XML markup to embed dashboard
layouts and widgets
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#45: Refine XML markup to embed dashboard layouts and widgets
-------------------------+-------------------------------------------------
Reporter: olemis | Owner: olemis
Type: | Status: accepted
enhancement | Milestone: RC1 for initial release
Priority: minor | Version:
Component: dashboard | Keywords: markup widget layout genshi
Resolution: | template
-------------------------+-------------------------------------------------
Comment (by gjm):
It might be an idea to update this ticket with the full rationale for why
it is better to be only working with XML for this.
Also, is this ticket otherwise complete?
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/45#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #45: Refine XML markup to embed dashboard
layouts and widgets
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#45: Refine XML markup to embed dashboard layouts and widgets
-------------------------+-------------------------------------------------
Reporter: olemis | Owner: olemis
Type: | Status: accepted
enhancement | Milestone: RC1 for initial release
Priority: minor | Version:
Component: dashboard | Keywords: markup widget layout genshi
Resolution: | template
-------------------------+-------------------------------------------------
Old description:
> Right now a combination of XML + JSON has to be inserted in Genshi
> templates so as to embed widgets and layouts implemented by dashboard
> plugin .
>
> For some reasons it's better to implement this feature using ''XML''
> instead. Nonetheless my previous attempt trying to get this done was not
> as successful as I expected .
>
> Further details may be found in comments in Genshi templates included in
> dashboard plugin
New description:
Right now a combination of XML + JSON has to be inserted in Genshi
templates so as to embed widgets and layouts implemented by dashboard
plugin .
For some reasons it's better to implement this feature using ''XML''
instead. For instance , widget markup looked like shown below in the early
days (prior to r1351312 ) looked like the snippet shown below
{{{
#!xml
<bh:widget id="simple_widget" urn="WidgetName" altlinks="false">
<bh:args>
{"args" : {"arg1" : "value1",
"arg2" : "value2"
}
}
</bh:args>
</bh:widget>
}}}
... whereas in current implementation ''only XML'' is needed (which is
more suitable to use together with ''Genshi'' statements e.g. `py:for` ,
`py:if` ... )
{{{
#!xml
<bh:widget id="simple_widget" urn="WidgetName" altlinks="false">
<bh:args>
<bh:arg name="arg1">value1</bh:arg>
<bh:arg name="arg2">value2</bh:arg>
</bh:args>
</bh:widget>
}}}
Nonetheless my initial attempt trying to get this done was not as
successful as I expected .
Further details may be found in comments in Genshi templates included in
dashboard plugin
--
Comment (by olemis):
Replying to [comment:4 gjm]:
> It might be an idea to update this ticket with the full rationale for
why it is better to be only working with XML for this.
>
Done with the explanation for widgets . Please review ''';)''' . The
explanation for layouts deserves a whole article ... I'll write a summary
as soon as possible .
> Also, is this ticket otherwise complete?
No . It's missing a patch to upgrade similar markup for for layouts . I
started working on it but ... I could not make much progress as there's
part of the code not working as I expected . ventually this will be ready
.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/45#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker