[jira] [Commented] (NIFI-12895) GetSmbFile and PutSmbFile has forced 5 sec timeout

["Peter Turcsanyi (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830121#comment-17830121 ] 

Peter Turcsanyi commented on NIFI-12895:
----------------------------------------

[~andersns] Thanks for your suggestion! Yes, it was that easy to add the property.

> GetSmbFile and PutSmbFile has forced 5 sec timeout
> --------------------------------------------------
>
>                 Key: NIFI-12895
>                 URL: https://issues.apache.org/jira/browse/NIFI-12895
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: 1.25.0, 2.0.0-M2
>            Reporter: Anders
>            Assignee: Peter Turcsanyi
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> It seems like timeout was introduced with the SmbjClientProviderService, and
> SmbUtils.java defines the withTimeout setting from the underlying smbj library.
> In SmbProperties.java, the default timeout value is set to 5 sec and you can configure it in the SmbjClientProviderService.
> However, the older GetSmbFile and PutSmbFile processors uses SmbUtils.java as well, but the timeout configuration item is not exposed in their config ui.
> The timeout setting should be added to the UI for GetSmbFile and PutSmbFile.
> I think it's enough to add the following lines to PutSmbFile.java and GetSmbFile.java:
> {code}
> ...
> import static org.apache.nifi.smb.common.SmbProperties.TIMEOUT;
> ...
> descriptors.add(TIMEOUT);
> ...
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)