You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/21 03:30:23 UTC

[GitHub] [spark] cloud-fan commented on pull request #35913: [SPARK-38604][SQL] Keep ceil and floor with only a single argument the same as before

cloud-fan commented on pull request #35913:
URL: https://github.com/apache/spark/pull/35913#issuecomment-1073449695


   This maybe not the right place to discuss it, but this PR reminds me of the new overload `def ceil(e: Column, scale: Column)`. Since we only allow literals as the `scale` parameter, shall we make its type `Int` instead of `Column`? cc @sathiyapk @HyukjinKwon 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org