You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/08/02 00:55:53 UTC
Review Request 61313: Bumped minimum required CMake version to 3.7.0.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61313/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
This is required for the `SOURCE_SUBDIR` functionality of
`ExternalProject_Add`, which is required to avoid a work-around where we
re-implement logic the module can do automatically.
Diffs
-----
CMakeLists.txt 75468abd3641171470a0b8759179dc86496820b5
Diff: https://reviews.apache.org/r/61313/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 61313: Bumped minimum required CMake version to
3.7.0.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61313/#review183169
-----------------------------------------------------------
Ship it!
I'll take care of updating some other dependencies before committing this:
* The docker-build.sh file.
* Some internal CI machine images.
* Some other build VMs/images that may or may not be using CMake.
- Joseph Wu
On Aug. 1, 2017, 6:04 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61313/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2017, 6:04 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-6350
> https://issues.apache.org/jira/browse/MESOS-6350
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is required for the `SOURCE_SUBDIR` functionality of
> `ExternalProject_Add`, which is required to avoid a work-around where we
> re-implement logic the module can do automatically.
>
>
> Diffs
> -----
>
> CMakeLists.txt 75468abd3641171470a0b8759179dc86496820b5
>
>
> Diff: https://reviews.apache.org/r/61313/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61313: Bumped minimum required CMake version to
3.7.0.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61313/#review183188
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61313]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On Aug. 1, 2017, 6:04 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61313/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2017, 6:04 p.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-6350
> https://issues.apache.org/jira/browse/MESOS-6350
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is required for the `SOURCE_SUBDIR` functionality of
> `ExternalProject_Add`, which is required to avoid a work-around where we
> re-implement logic the module can do automatically.
>
>
> Diffs
> -----
>
> CMakeLists.txt 75468abd3641171470a0b8759179dc86496820b5
>
>
> Diff: https://reviews.apache.org/r/61313/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61313: Bumped minimum required CMake version to
3.7.0.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61313/
-----------------------------------------------------------
(Updated Aug. 1, 2017, 6:04 p.m.)
Review request for mesos.
Bugs: MESOS-6350
https://issues.apache.org/jira/browse/MESOS-6350
Repository: mesos
Description
-------
This is required for the `SOURCE_SUBDIR` functionality of
`ExternalProject_Add`, which is required to avoid a work-around where we
re-implement logic the module can do automatically.
Diffs
-----
CMakeLists.txt 75468abd3641171470a0b8759179dc86496820b5
Diff: https://reviews.apache.org/r/61313/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer