You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Duncan Jones (JIRA)" <ji...@codehaus.org> on 2012/09/26 10:06:35 UTC
[jira] (MNGSITE-164) Explanation of default value for
useAllReactorProjects is at best confusing, possibly wrong
Duncan Jones created MNGSITE-164:
------------------------------------
Summary: Explanation of default value for useAllReactorProjects is at best confusing, possibly wrong
Key: MNGSITE-164
URL: https://jira.codehaus.org/browse/MNGSITE-164
Project: Maven Project Web Site
Issue Type: Bug
Environment: Apache Maven 2.2.1 (r801777; 2009-08-06 20:16:01+0100)
Java version: 1.7.0
Java home: C:\Program Files\Java\jdk1.7.0\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7" version: "6.1" arch: "x86" Family: "windows"
Reporter: Duncan Jones
Attachments: parent.zip
See page: http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html#class_moduleSet
The explanation of {{useAllReactorProjects}} is given as follows:
bq. If set to true, the plugin will include all projects in the current reactor for processing in this ModuleSet. These will be subject to include/exclude rules. Default value is true. (Since 2.2)
Default value is: false.
I'm using Maven 2.2.1, so I assumed this would default to {{true}}. However, it appears to be {{false}}. Attached is a small example project which seems to require {{useAllReactorProjects}} to be specified as true in order to build correctly with Maven 2.2.1.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNGSITE-164) Explanation of default value for
useAllReactorProjects is at best confusing, possibly wrong
Posted by "Duncan Jones (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MNGSITE-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=309848#comment-309848 ]
Duncan Jones edited comment on MNGSITE-164 at 9/27/12 2:04 AM:
---------------------------------------------------------------
bq. The "(Since 2.2)" you see in the documentation refers to the version of Maven Assembly Plugin - not Maven itself.
Clearly not enough coffee for me yesterday! Sorry, I meant to state that I'm using Maven Assembly plugin 2.3.
bq. What is the behavior you expect and what is the behavior that you currently see?
I expect that if I comment out the following line in moduleB's assembly descriptor:
{code:xml}
<useAllReactorProjects>true</useAllReactorProjects>
{code}
it would have no effect on the build, since this value should default to true when using Maven Assembly 2.3. However, the actual result is a failure to find the artifact produced by moduleA:
{noformat}
[INFO] Reading assembly descriptor: src/main/assembly/assembly.xml
[WARNING] The following patterns were never triggered in this artifact inclusion filter:
o 'foo:moduleA'
[WARNING] The following patterns were never triggered in this artifact inclusion filter:
o 'foo:moduleA'
[WARNING] NOTE: Currently, inclusion of module dependencies may produce unpredictable results if a version conflict occurs.
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Failed to create assembly: Error creating assembly archive dist: You must set at least one file.
{noformat}
If I don't comment out the line, it builds successfully and I get the same single warning you see.
was (Author: dmjones500):
bq. The "(Since 2.2)" you see in the documentation refers to the version of Maven Assembly Plugin - not Maven itself.
Clearly not enough coffee for me yesterday! Sorry, I meant to state that I'm using Maven Assembly plugin 2.3.
bq. What is the behavior you expect and what is the behavior that you currently see?
I expect that if I comment out the following line in moduleB's assembly descriptor:
{code:xml}
<useAllReactorProjects>true</useAllReactorProjects>
{code}
it would have no effect on the build, since this value should default to true when using Maven Assembly 2.3. However, the actual result is a failure to find the artifact produced by moduleA:
{noformat}
[INFO] Reading assembly descriptor: src/main/assembly/assembly.xml
[WARNING] The following patterns were never triggered in this artifact inclusion filter:
o 'foo:moduleA'
[WARNING] The following patterns were never triggered in this artifact inclusion filter:
o 'foo:moduleA'
[WARNING] NOTE: Currently, inclusion of module dependencies may produce unpredictable results if a version conflict occurs.
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Failed to create assembly: Error creating assembly archive dist: You must set at least one file.
{noformat}
If I don't comment out the line, it builds find and I get the same single warning you see.
> Explanation of default value for useAllReactorProjects is at best confusing, possibly wrong
> -------------------------------------------------------------------------------------------
>
> Key: MNGSITE-164
> URL: https://jira.codehaus.org/browse/MNGSITE-164
> Project: Maven Project Web Site
> Issue Type: Bug
> Environment: Apache Maven 2.2.1 (r801777; 2009-08-06 20:16:01+0100)
> Java version: 1.7.0
> Java home: C:\Program Files\Java\jdk1.7.0\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7" version: "6.1" arch: "x86" Family: "windows"
> Reporter: Duncan Jones
> Attachments: parent.zip
>
>
> See page: http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html#class_moduleSet
> The explanation of {{useAllReactorProjects}} is given as follows:
> bq. If set to true, the plugin will include all projects in the current reactor for processing in this ModuleSet. These will be subject to include/exclude rules. Default value is true. (Since 2.2)
> Default value is: false.
> I'm using Maven 2.2.1, so I assumed this would default to {{true}}. However, it appears to be {{false}}. Attached is a small example project which seems to require {{useAllReactorProjects}} to be specified as true in order to build correctly with Maven 2.2.1.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MASSEMBLY-629) Explanation of default value for
useAllReactorProjects is at best confusing, possibly wrong
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MASSEMBLY-629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg moved MNGSITE-164 to MASSEMBLY-629:
---------------------------------------------------
Key: MASSEMBLY-629 (was: MNGSITE-164)
Project: Maven 2.x Assembly Plugin (was: Maven Project Web Site)
> Explanation of default value for useAllReactorProjects is at best confusing, possibly wrong
> -------------------------------------------------------------------------------------------
>
> Key: MASSEMBLY-629
> URL: https://jira.codehaus.org/browse/MASSEMBLY-629
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Environment: Apache Maven 2.2.1 (r801777; 2009-08-06 20:16:01+0100)
> Java version: 1.7.0
> Java home: C:\Program Files\Java\jdk1.7.0\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7" version: "6.1" arch: "x86" Family: "windows"
> Reporter: Duncan Jones
> Attachments: parent.zip
>
>
> See page: http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html#class_moduleSet
> The explanation of {{useAllReactorProjects}} is given as follows:
> bq. If set to true, the plugin will include all projects in the current reactor for processing in this ModuleSet. These will be subject to include/exclude rules. Default value is true. (Since 2.2)
> Default value is: false.
> I'm using Maven 2.2.1, so I assumed this would default to {{true}}. However, it appears to be {{false}}. Attached is a small example project which seems to require {{useAllReactorProjects}} to be specified as true in order to build correctly with Maven 2.2.1.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNGSITE-164) Explanation of default value for
useAllReactorProjects is at best confusing, possibly wrong
Posted by "Duncan Jones (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MNGSITE-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=309848#comment-309848 ]
Duncan Jones commented on MNGSITE-164:
--------------------------------------
bq. The "(Since 2.2)" you see in the documentation refers to the version of Maven Assembly Plugin - not Maven itself.
Clearly not enough coffee for me yesterday! Sorry, I meant to state that I'm using Maven Assembly plugin 2.3.
bq. What is the behavior you expect and what is the behavior that you currently see?
I expect that if I comment out the following line in moduleB's assembly descriptor:
{code:xml}
<useAllReactorProjects>true</useAllReactorProjects>
{code}
it would have no effect on the build, since this value should default to true when using Maven Assembly 2.3. However, the actual result is a failure to find the artifact produced by moduleA:
{noformat}
[INFO] Reading assembly descriptor: src/main/assembly/assembly.xml
[WARNING] The following patterns were never triggered in this artifact inclusion filter:
o 'foo:moduleA'
[WARNING] The following patterns were never triggered in this artifact inclusion filter:
o 'foo:moduleA'
[WARNING] NOTE: Currently, inclusion of module dependencies may produce unpredictable results if a version conflict occurs.
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Failed to create assembly: Error creating assembly archive dist: You must set at least one file.
{noformat}
If I don't comment out the line, it builds find and I get the same single warning you see.
> Explanation of default value for useAllReactorProjects is at best confusing, possibly wrong
> -------------------------------------------------------------------------------------------
>
> Key: MNGSITE-164
> URL: https://jira.codehaus.org/browse/MNGSITE-164
> Project: Maven Project Web Site
> Issue Type: Bug
> Environment: Apache Maven 2.2.1 (r801777; 2009-08-06 20:16:01+0100)
> Java version: 1.7.0
> Java home: C:\Program Files\Java\jdk1.7.0\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7" version: "6.1" arch: "x86" Family: "windows"
> Reporter: Duncan Jones
> Attachments: parent.zip
>
>
> See page: http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html#class_moduleSet
> The explanation of {{useAllReactorProjects}} is given as follows:
> bq. If set to true, the plugin will include all projects in the current reactor for processing in this ModuleSet. These will be subject to include/exclude rules. Default value is true. (Since 2.2)
> Default value is: false.
> I'm using Maven 2.2.1, so I assumed this would default to {{true}}. However, it appears to be {{false}}. Attached is a small example project which seems to require {{useAllReactorProjects}} to be specified as true in order to build correctly with Maven 2.2.1.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MASSEMBLY-629) Explanation of default value for
useAllReactorProjects is at best confusing, possibly wrong
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MASSEMBLY-629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg closed MASSEMBLY-629.
-------------------------------------
Resolution: Fixed
Fix Version/s: 2.4
Assignee: Dennis Lundberg
It is the documentation that is wrong. The default value is false.
I fixed the documentation in [r1391202|http://svn.apache.org/viewvc?view=revision&revision=1391202].
> Explanation of default value for useAllReactorProjects is at best confusing, possibly wrong
> -------------------------------------------------------------------------------------------
>
> Key: MASSEMBLY-629
> URL: https://jira.codehaus.org/browse/MASSEMBLY-629
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Environment: Apache Maven 2.2.1 (r801777; 2009-08-06 20:16:01+0100)
> Java version: 1.7.0
> Java home: C:\Program Files\Java\jdk1.7.0\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7" version: "6.1" arch: "x86" Family: "windows"
> Reporter: Duncan Jones
> Assignee: Dennis Lundberg
> Fix For: 2.4
>
> Attachments: parent.zip
>
>
> See page: http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html#class_moduleSet
> The explanation of {{useAllReactorProjects}} is given as follows:
> bq. If set to true, the plugin will include all projects in the current reactor for processing in this ModuleSet. These will be subject to include/exclude rules. Default value is true. (Since 2.2)
> Default value is: false.
> I'm using Maven 2.2.1, so I assumed this would default to {{true}}. However, it appears to be {{false}}. Attached is a small example project which seems to require {{useAllReactorProjects}} to be specified as true in order to build correctly with Maven 2.2.1.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNGSITE-164) Explanation of default value for
useAllReactorProjects is at best confusing, possibly wrong
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MNGSITE-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=309802#comment-309802 ]
Dennis Lundberg commented on MNGSITE-164:
-----------------------------------------
The "(Since 2.2)" you see in the documentation refers to the version of Maven Assembly Plugin - not Maven itself. It means that the parameter was first introduced in Maven Assembly Plugin 2.2.
I tried building your sample project like this:
{noformat}
mvn clean verify
{noformat}
The build succeeds and the only problems I see are warnings like this one:
{noformat}
[WARNING] NOTE: Currently, inclusion of module dependencies may produce unpredictable results if a version conflict occurs.
{noformat}
What is the behavior you expect and what is the behavior that you currently see?
> Explanation of default value for useAllReactorProjects is at best confusing, possibly wrong
> -------------------------------------------------------------------------------------------
>
> Key: MNGSITE-164
> URL: https://jira.codehaus.org/browse/MNGSITE-164
> Project: Maven Project Web Site
> Issue Type: Bug
> Environment: Apache Maven 2.2.1 (r801777; 2009-08-06 20:16:01+0100)
> Java version: 1.7.0
> Java home: C:\Program Files\Java\jdk1.7.0\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7" version: "6.1" arch: "x86" Family: "windows"
> Reporter: Duncan Jones
> Attachments: parent.zip
>
>
> See page: http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html#class_moduleSet
> The explanation of {{useAllReactorProjects}} is given as follows:
> bq. If set to true, the plugin will include all projects in the current reactor for processing in this ModuleSet. These will be subject to include/exclude rules. Default value is true. (Since 2.2)
> Default value is: false.
> I'm using Maven 2.2.1, so I assumed this would default to {{true}}. However, it appears to be {{false}}. Attached is a small example project which seems to require {{useAllReactorProjects}} to be specified as true in order to build correctly with Maven 2.2.1.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira