You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/07/28 04:19:41 UTC
[GitHub] [incubator-uniffle] smallzhongfeng opened a new pull request, #96: [Minor] Reduce RssSparkConfig's code redundancy
smallzhongfeng opened a new pull request, #96:
URL: https://github.com/apache/incubator-uniffle/pull/96
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://github.com/Tencent/Firestorm/blob/master/CONTRIBUTING.md
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Make the code more concise.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
No need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on pull request #96: [Minor] Reduce RssSparkConfig's code redundancy
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on PR #96:
URL: https://github.com/apache/incubator-uniffle/pull/96#issuecomment-1200903022
> @smallzhongfeng Will you close this pr? You seems to have raised a new pr.
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #96: [Minor] Reduce RssSparkConfig's code redundancy
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #96:
URL: https://github.com/apache/incubator-uniffle/pull/96#issuecomment-1197870801
> Most of the configurations are relatively clear, but some parameters can be added appropriately. Maybe this is more friendly to novice users.
Agree with you, could we reuse Spark's class `ConfigBuilder` to optimize these code? Class `ConfigBuilder` have a field named `description`, the description can tell users how to use the parameter. But `ConfigBuilder` is scala code, there may be some difficulty to use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #96: [Minor] Reduce RssSparkConfig's code redundancy
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #96:
URL: https://github.com/apache/incubator-uniffle/pull/96#discussion_r931811465
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java:
##########
@@ -26,87 +26,69 @@
public class RssSparkConfig {
public static final String SPARK_RSS_CONFIG_PREFIX = "spark.";
- public static final String RSS_PARTITION_NUM_PER_RANGE =
- SPARK_RSS_CONFIG_PREFIX + RssClientConfig.RSS_PARTITION_NUM_PER_RANGE;
+ public static final String RSS_PARTITION_NUM_PER_RANGE = prefix(RssClientConfig.RSS_PARTITION_NUM_PER_RANGE);
Review Comment:
```
SPARK_RSS_CONFIG_PREFIX + RSS_XXX_XXX
```
is enough simple. When we use the method `prefix`, we need look at the method concrete implement. I don't think the pr improve the readability. And is there any other system to do similar code optimization? Hadoop use the same style as ours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on pull request #96: [Minor] Reduce RssSparkConfig's code redundancy
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on PR #96:
URL: https://github.com/apache/incubator-uniffle/pull/96#issuecomment-1197915041
Can I rewrite this class of RssConf instead of Spark's ConfigBuilder, is there any risk.@jerqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #96: [Minor] Reduce RssSparkConfig's code redundancy
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #96:
URL: https://github.com/apache/incubator-uniffle/pull/96#issuecomment-1198105370
> It might need to introduce Scala code. Can I rewrite this class of RssConf instead of Spark's ConfigBuilder, is there any risk.@jerqi
You can call Scala code in Java code. I think it's a good way to reuse the `ConfigBuilder`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #96: [Minor] Reduce RssSparkConfig's code redundancy
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #96:
URL: https://github.com/apache/incubator-uniffle/pull/96#issuecomment-1197921285
> Can I rewrite this class of RssConf instead of Spark's ConfigBuilder, is there any risk.@jerqi
Spark Client only supports to get configuration from `SparkConf`. `SparkConf` only supports to use `ConfigBuilder`. RssConf is used for shuffle server and coordinator. You can try to use `ConfigBuilder` to rewrite the class `RssSparkConfig`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #96: [Minor] Reduce RssSparkConfig's code redundancy
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #96:
URL: https://github.com/apache/incubator-uniffle/pull/96#issuecomment-1197648514
# [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/96?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#96](https://codecov.io/gh/apache/incubator-uniffle/pull/96?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8b24fef) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/cdbacca19736fd1eccc8ab65c085ec4455d74c71?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cdbacca) will **decrease** coverage by `0.91%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 8b24fef differs from pull request most recent head f26b7c8. Consider uploading reports for the commit f26b7c8 to get more accurate results
```diff
@@ Coverage Diff @@
## master #96 +/- ##
============================================
- Coverage 56.34% 55.43% -0.92%
+ Complexity 1175 1100 -75
============================================
Files 149 140 -9
Lines 7977 7607 -370
Branches 765 735 -30
============================================
- Hits 4495 4217 -278
+ Misses 3239 3156 -83
+ Partials 243 234 -9
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-uniffle/pull/96?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...storage/handler/impl/DataSkippableReadHandler.java](https://codecov.io/gh/apache/incubator-uniffle/pull/96/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmFnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zdG9yYWdlL2hhbmRsZXIvaW1wbC9EYXRhU2tpcHBhYmxlUmVhZEhhbmRsZXIuamF2YQ==) | `81.25% <0.00%> (-3.13%)` | :arrow_down: |
| [...org/apache/uniffle/server/ShuffleFlushManager.java](https://codecov.io/gh/apache/incubator-uniffle/pull/96/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9TaHVmZmxlRmx1c2hNYW5hZ2VyLmphdmE=) | `76.70% <0.00%> (-1.71%)` | :arrow_down: |
| [...e/uniffle/server/storage/SingleStorageManager.java](https://codecov.io/gh/apache/incubator-uniffle/pull/96/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9zdG9yYWdlL1NpbmdsZVN0b3JhZ2VNYW5hZ2VyLmphdmE=) | `65.57% <0.00%> (-1.64%)` | :arrow_down: |
| [.../java/org/apache/spark/shuffle/RssSparkConfig.java](https://codecov.io/gh/apache/incubator-uniffle/pull/96/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS9Sc3NTcGFya0NvbmZpZy5qYXZh) | | |
| [...k/shuffle/writer/WrappedByteArrayOutputStream.java](https://codecov.io/gh/apache/incubator-uniffle/pull/96/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS93cml0ZXIvV3JhcHBlZEJ5dGVBcnJheU91dHB1dFN0cmVhbS5qYXZh) | | |
| [...che/spark/shuffle/writer/BufferManagerOptions.java](https://codecov.io/gh/apache/incubator-uniffle/pull/96/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS93cml0ZXIvQnVmZmVyTWFuYWdlck9wdGlvbnMuamF2YQ==) | | |
| [...org/apache/spark/shuffle/RssSparkShuffleUtils.java](https://codecov.io/gh/apache/incubator-uniffle/pull/96/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS9Sc3NTcGFya1NodWZmbGVVdGlscy5qYXZh) | | |
| [.../org/apache/spark/shuffle/writer/WriterBuffer.java](https://codecov.io/gh/apache/incubator-uniffle/pull/96/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS93cml0ZXIvV3JpdGVyQnVmZmVyLmphdmE=) | | |
| [...e/spark/shuffle/reader/RssShuffleDataIterator.java](https://codecov.io/gh/apache/incubator-uniffle/pull/96/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS9yZWFkZXIvUnNzU2h1ZmZsZURhdGFJdGVyYXRvci5qYXZh) | | |
| [...pache/spark/shuffle/writer/WriteBufferManager.java](https://codecov.io/gh/apache/incubator-uniffle/pull/96/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS93cml0ZXIvV3JpdGVCdWZmZXJNYW5hZ2VyLmphdmE=) | | |
| ... and [2 more](https://codecov.io/gh/apache/incubator-uniffle/pull/96/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] frankliee commented on pull request #96: [Minor] Reduce RssSparkConfig's code redundancy
Posted by GitBox <gi...@apache.org>.
frankliee commented on PR #96:
URL: https://github.com/apache/incubator-uniffle/pull/96#issuecomment-1198820187
> It might need to introduce Scala code. Can I rewrite this class of RssConf instead of Spark's ConfigBuilder, is there any risk.@jerqi
It makes sense to reuse spark's implementations in uniffle spark client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #96: [Minor] Reduce RssSparkConfig's code redundancy
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #96:
URL: https://github.com/apache/incubator-uniffle/pull/96#discussion_r931811465
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java:
##########
@@ -26,87 +26,69 @@
public class RssSparkConfig {
public static final String SPARK_RSS_CONFIG_PREFIX = "spark.";
- public static final String RSS_PARTITION_NUM_PER_RANGE =
- SPARK_RSS_CONFIG_PREFIX + RssClientConfig.RSS_PARTITION_NUM_PER_RANGE;
+ public static final String RSS_PARTITION_NUM_PER_RANGE = prefix(RssClientConfig.RSS_PARTITION_NUM_PER_RANGE);
Review Comment:
```
SPARK_RSS_CONFIG_PREFIX + RSS_XXX_XXX
```
is enough simple. When we use the method `prefix`, we need look at the method concrete implement. I don't think the pr improve the readability. And is there any other system to do similar code optimization? Hadoop use the same style as ours. I prefer not merging this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #96: [Minor] Reduce RssSparkConfig's code redundancy
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #96:
URL: https://github.com/apache/incubator-uniffle/pull/96#issuecomment-1200435910
Will you close @smallzhongfeng this pr? You seems to have raised a new pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on pull request #96: [Minor] Reduce RssSparkConfig's code redundancy
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on PR #96:
URL: https://github.com/apache/incubator-uniffle/pull/96#issuecomment-1197859902
Most of the configurations are relatively clear, but some parameters can be added appropriately. Maybe this is more friendly to novice users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng closed pull request #96: [Minor] Reduce RssSparkConfig's code redundancy
Posted by GitBox <gi...@apache.org>.
smallzhongfeng closed pull request #96: [Minor] Reduce RssSparkConfig's code redundancy
URL: https://github.com/apache/incubator-uniffle/pull/96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #96: [Minor] Reduce RssSparkConfig's code redundancy
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #96:
URL: https://github.com/apache/incubator-uniffle/pull/96#issuecomment-1197737085
> Indeed, I have carefully looked at the configuration of Hadoop config, which is similar to the current code, and the reason why I modified it at first is that this part of the configuration information is relatively messy. Here is a suggestion. Can we simply mark the meaning of these parameters like Hadoop?
Could you give me an example to show how to simply mark the meaning of these parameters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on pull request #96: [Minor] Reduce RssSparkConfig's code redundancy
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on PR #96:
URL: https://github.com/apache/incubator-uniffle/pull/96#issuecomment-1197722790
Indeed, I have carefully looked at the configuration of Hadoop config, which is similar to the current code, and the reason why I modified it at first is that this part of the configuration information is relatively messy. Here is a suggestion. Can we simply mark the meaning of these parameters like Hadoop?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org