You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/09/02 17:45:17 UTC
[GitHub] [netbeans] neilcsmith-net opened a new pull request #2338: Snapshot of APIs as of Apache NetBeans 12.1
neilcsmith-net opened a new pull request #2338:
URL: https://github.com/apache/netbeans/pull/2338
Snapshot of APIs as of Apache NetBeans 12.1 cade25887c5450e4595fa59e616daee4d2520ee0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2338: Snapshot of APIs as of Apache NetBeans 12.1
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2338:
URL: https://github.com/apache/netbeans/pull/2338#discussion_r482810220
##########
File path: cpplite/cpplite.editor/nbproject/org-netbeans-modules-cpplite-editor.sig
##########
@@ -0,0 +1,31 @@
+#Signature file v4.1
+#Version 1.0
+
+CLSS public java.lang.Object
+cons public init()
+meth protected java.lang.Object clone() throws java.lang.CloneNotSupportedException
+meth protected void finalize() throws java.lang.Throwable
+meth public boolean equals(java.lang.Object)
+meth public final java.lang.Class<?> getClass()
+meth public final void notify()
+meth public final void notifyAll()
+meth public final void wait() throws java.lang.InterruptedException
+meth public final void wait(long) throws java.lang.InterruptedException
+meth public final void wait(long,int) throws java.lang.InterruptedException
+meth public int hashCode()
+meth public java.lang.String toString()
+
+CLSS public abstract interface org.netbeans.modules.cpplite.editor.spi.CProjectConfigurationProvider
+innr public static ProjectConfiguration
+meth public abstract org.netbeans.modules.cpplite.editor.spi.CProjectConfigurationProvider$ProjectConfiguration getProjectConfiguration()
+meth public abstract void addChangeListener(javax.swing.event.ChangeListener)
+meth public abstract void removeChangeListener(javax.swing.event.ChangeListener)
+
+CLSS public static org.netbeans.modules.cpplite.editor.spi.CProjectConfigurationProvider$ProjectConfiguration
Review comment:
@jlahoda, really!? `ProjectConfiguration` inner class as your public API?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #2338: Snapshot of APIs as of Apache NetBeans 12.1
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #2338:
URL: https://github.com/apache/netbeans/pull/2338#discussion_r482987972
##########
File path: extide/libs.gradle/nbproject/org-netbeans-modules-libs-gradle.sig
##########
@@ -0,0 +1,167 @@
+#Signature file v4.1
Review comment:
Confirmed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2338: Snapshot of APIs as of Apache NetBeans 12.1
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2338:
URL: https://github.com/apache/netbeans/pull/2338#issuecomment-687075742
:+1: merging now, and will figure out how we document that (and getPeer issue) into the release process for next time. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2338: Snapshot of APIs as of Apache NetBeans 12.1
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2338:
URL: https://github.com/apache/netbeans/pull/2338#discussion_r482947461
##########
File path: apisupport/apisupport.installer/nbproject/org-netbeans-modules-apisupport-installer.sig
##########
@@ -159,6 +159,8 @@ meth public java.awt.im.InputMethodRequests getInputMethodRequests()
meth public java.awt.image.ColorModel getColorModel()
meth public java.awt.image.VolatileImage createVolatileImage(int,int)
meth public java.awt.image.VolatileImage createVolatileImage(int,int,java.awt.ImageCapabilities) throws java.awt.AWTException
+meth public java.awt.peer.ComponentPeer getPeer()
Review comment:
Great:
```
curl https://patch-diff.githubusercontent.com/raw/apache/netbeans/pull/2338.diff | grep getPeer
```
yields nothing. Good job.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2338: Snapshot of APIs as of Apache NetBeans 12.1
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2338:
URL: https://github.com/apache/netbeans/pull/2338#issuecomment-686633315
@JaroslavTulach you happy for merge without the requested review though? Does make me wonder whether we should generate this snapshot PR at feature freeze and keep updated through the beta phase so questions on API can be addressed before they're baked in?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #2338: Snapshot of APIs as of Apache NetBeans 12.1
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #2338:
URL: https://github.com/apache/netbeans/pull/2338#issuecomment-687074709
> @JaroslavTulach you happy for merge without the requested review though?
It is too late to fix the API anyway. 12.1 has already been approved. Sure, merge this PR.
> should (we) generate this snapshot PR at feature freeze?
That would be really great next time! The review would then be more meaningful as it could correct possible errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2338: Snapshot of APIs as of Apache NetBeans 12.1
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2338:
URL: https://github.com/apache/netbeans/pull/2338#discussion_r482810220
##########
File path: cpplite/cpplite.editor/nbproject/org-netbeans-modules-cpplite-editor.sig
##########
@@ -0,0 +1,31 @@
+#Signature file v4.1
+#Version 1.0
+
+CLSS public java.lang.Object
+cons public init()
+meth protected java.lang.Object clone() throws java.lang.CloneNotSupportedException
+meth protected void finalize() throws java.lang.Throwable
+meth public boolean equals(java.lang.Object)
+meth public final java.lang.Class<?> getClass()
+meth public final void notify()
+meth public final void notifyAll()
+meth public final void wait() throws java.lang.InterruptedException
+meth public final void wait(long) throws java.lang.InterruptedException
+meth public final void wait(long,int) throws java.lang.InterruptedException
+meth public int hashCode()
+meth public java.lang.String toString()
+
+CLSS public abstract interface org.netbeans.modules.cpplite.editor.spi.CProjectConfigurationProvider
+innr public static ProjectConfiguration
+meth public abstract org.netbeans.modules.cpplite.editor.spi.CProjectConfigurationProvider$ProjectConfiguration getProjectConfiguration()
+meth public abstract void addChangeListener(javax.swing.event.ChangeListener)
+meth public abstract void removeChangeListener(javax.swing.event.ChangeListener)
+
+CLSS public static org.netbeans.modules.cpplite.editor.spi.CProjectConfigurationProvider$ProjectConfiguration
Review comment:
@jlahoda, really!? `ProjectConfiguration` inner class as you public API?
##########
File path: apisupport/apisupport.installer/nbproject/org-netbeans-modules-apisupport-installer.sig
##########
@@ -159,6 +159,8 @@ meth public java.awt.im.InputMethodRequests getInputMethodRequests()
meth public java.awt.image.ColorModel getColorModel()
meth public java.awt.image.VolatileImage createVolatileImage(int,int)
meth public java.awt.image.VolatileImage createVolatileImage(int,int,java.awt.ImageCapabilities) throws java.awt.AWTException
+meth public java.awt.peer.ComponentPeer getPeer()
Review comment:
It would be better to remove all these getPeer() methods from the listing. They are not present on newer JDK and if we include them in the `.sig` file, then the `ant build` (which includes sigtest check) will fail on JDK11+.
##########
File path: platform/openide.util.lookup/nbproject/org-openide-util-lookup.sig
##########
@@ -238,6 +240,14 @@ supr org.openide.util.Lookup
hfds data
hcls EmptyInternalData,ImmutableInternalData,LazyCollection,LazyList,LazySet,R,RealInternalData,SingleInternalData,WeakRef,WeakResult
+CLSS public final static org.openide.util.lookup.ProxyLookup$Controller
+ outer org.openide.util.lookup.ProxyLookup
Review comment:
Great contribution, @timboudreau!
##########
File path: platform/core.startup/nbproject/org-netbeans-core-startup.sig
##########
@@ -738,6 +738,8 @@ meth public abstract void resultChanged(org.openide.util.LookupEvent)
CLSS public org.openide.util.lookup.ProxyLookup
cons protected init()
cons public !varargs init(org.openide.util.Lookup[])
+cons public init(org.openide.util.lookup.ProxyLookup$Controller)
Review comment:
@timboudreau's lookup improvements made it into NetBeans 12.1!
##########
File path: java/libs.javacapi/nbproject/org-netbeans-libs-javacapi.sig
##########
@@ -301,6 +301,11 @@ intf com.sun.source.tree.ExpressionTree
meth public abstract com.sun.source.tree.ExpressionTree getLeftOperand()
meth public abstract com.sun.source.tree.ExpressionTree getRightOperand()
+CLSS public abstract interface com.sun.source.tree.BindingPatternTree
+intf com.sun.source.tree.PatternTree
Review comment:
`PatternTree` - that must be related to upgrading to JDK14 syntax, right @jlahoda?
##########
File path: extide/libs.gradle/nbproject/org-netbeans-modules-libs-gradle.sig
##########
@@ -0,0 +1,167 @@
+#Signature file v4.1
Review comment:
Just a result of moving to another cluster, I assume. CCing @lkishalmi
##########
File path: platform/libs.junit4/nbproject/org-netbeans-libs-junit4.sig
##########
@@ -617,9 +617,377 @@ meth public void testStarted(java.lang.String)
supr junit.runner.BaseTestRunner
hfds fPrinter
+CLSS public abstract org.hamcrest.BaseDescription
Review comment:
Result of @sdedic opening up the module, so it is possible to use hamcrest checks in `NbModuleTest` I assume.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2338: Snapshot of APIs as of Apache NetBeans 12.1
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2338:
URL: https://github.com/apache/netbeans/pull/2338#issuecomment-685895966
@JaroslavTulach @ebarboni what's the deal with the `getPeer()` stuff? Needs removing manually?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net merged pull request #2338: Snapshot of APIs as of Apache NetBeans 12.1
Posted by GitBox <gi...@apache.org>.
neilcsmith-net merged pull request #2338:
URL: https://github.com/apache/netbeans/pull/2338
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on a change in pull request #2338: Snapshot of APIs as of Apache NetBeans 12.1
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on a change in pull request #2338:
URL: https://github.com/apache/netbeans/pull/2338#discussion_r482862445
##########
File path: apisupport/apisupport.installer/nbproject/org-netbeans-modules-apisupport-installer.sig
##########
@@ -159,6 +159,8 @@ meth public java.awt.im.InputMethodRequests getInputMethodRequests()
meth public java.awt.image.ColorModel getColorModel()
meth public java.awt.image.VolatileImage createVolatileImage(int,int)
meth public java.awt.image.VolatileImage createVolatileImage(int,int,java.awt.ImageCapabilities) throws java.awt.AWTException
+meth public java.awt.peer.ComponentPeer getPeer()
Review comment:
OK, done - please double check @JaroslavTulach
Used -
```
find . -name "*.sig" -exec sed -i '/java.awt.peer.ComponentPeer/{N;d;}' {} \;
```
If that looks correct we should document that unless/until generation is fixed. Initially matched on `getPeer()` until I realised there's a non-AWT method with same name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists