You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by "selfxp (via GitHub)" <gi...@apache.org> on 2026/05/12 00:46:05 UTC
[PR] Prepare 3.21.9 release [openwhisk-client-js]
selfxp opened a new pull request, #283:
URL: https://github.com/apache/openwhisk-client-js/pull/283
Prepare openwhisk-client-js 3.21.9 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare 3.21.9 release [openwhisk-client-js]
Posted by "dgrove-oss (via GitHub)" <gi...@apache.org>.
dgrove-oss commented on code in PR #283:
URL: https://github.com/apache/openwhisk-client-js/pull/283#discussion_r3243990480
##########
.github/workflows/ci.yaml:
##########
@@ -71,28 +71,31 @@ jobs:
uses: actions/checkout@v4
with:
repository: apache/openwhisk
+ ref: 2.0.0
path: core
- name: Install python packages needed to deploy OpenWhisk
run: |
pip install couchdb
pip install 'jinja2<3.1' ansible==2.8.18
pip install pydocumentdb
- pip install humanize requests
+ pip install humanize 'requests<2.32' 'urllib3<2' 'docker>=6,<7'
Review Comment:
Thank you for doing this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare 3.21.9 release [openwhisk-client-js]
Posted by "style95 (via GitHub)" <gi...@apache.org>.
style95 commented on code in PR #283:
URL: https://github.com/apache/openwhisk-client-js/pull/283#discussion_r3243995786
##########
.github/workflows/ci.yaml:
##########
@@ -71,28 +71,41 @@ jobs:
uses: actions/checkout@v4
with:
repository: apache/openwhisk
+ ref: 2.0.0
path: core
- name: Install python packages needed to deploy OpenWhisk
run: |
- pip install couchdb
- pip install 'jinja2<3.1' ansible==2.8.18
- pip install pydocumentdb
- pip install humanize requests
+ python3 -m pip install couchdb
+ python3 -m pip install 'jinja2<3.1' ansible==2.8.18
+ python3 -m pip install pydocumentdb
+ python3 -m pip install humanize 'requests<2.32' 'urllib3<2' 'docker>=6,<7'
- name: Deploy OpenWhisk
working-directory: core/ansible
env:
ANSIBLE_CMD: "ansible-playbook -i environments/local -e docker_image_prefix=openwhisk -e docker_image_tag=nightly"
+ ANSIBLE_EXTRA_VARS: '{"scheduler_enable":false,"jmxremote_enabled":"","controller_loadbalancer_spi":"org.apache.openwhisk.core.loadBalancer.ShardingContainerPoolBalancer","invokerReactive_spi":"org.apache.openwhisk.core.invoker.InvokerReactive","invokerServer_spi":"org.apache.openwhisk.core.invoker.DefaultInvokerServer"}'
Review Comment:
Is there a reason that you used the ShardingPoolBalancer that is deprecated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare 3.21.9 release [openwhisk-client-js]
Posted by "style95 (via GitHub)" <gi...@apache.org>.
style95 commented on PR #283:
URL: https://github.com/apache/openwhisk-client-js/pull/283#issuecomment-4426652836
Oddly, no CI is running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare 3.21.9 release [openwhisk-client-js]
Posted by "style95 (via GitHub)" <gi...@apache.org>.
style95 closed pull request #283: Prepare 3.21.9 release
URL: https://github.com/apache/openwhisk-client-js/pull/283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare 3.21.9 release [openwhisk-client-js]
Posted by "style95 (via GitHub)" <gi...@apache.org>.
style95 commented on PR #283:
URL: https://github.com/apache/openwhisk-client-js/pull/283#issuecomment-4445387084
I will defer to other reviewers.
I generally fix the issue from OW first and make it pass the CI to make sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare 3.21.9 release [openwhisk-client-js]
Posted by "style95 (via GitHub)" <gi...@apache.org>.
style95 commented on PR #283:
URL: https://github.com/apache/openwhisk-client-js/pull/283#issuecomment-4426659654
It has been disabled because of inactivity. Reenable it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare 3.21.9 release [openwhisk-client-js]
Posted by "selfxp (via GitHub)" <gi...@apache.org>.
selfxp commented on code in PR #283:
URL: https://github.com/apache/openwhisk-client-js/pull/283#discussion_r3243655096
##########
.github/workflows/ci.yaml:
##########
@@ -71,28 +71,31 @@ jobs:
uses: actions/checkout@v4
with:
repository: apache/openwhisk
+ ref: 2.0.0
path: core
- name: Install python packages needed to deploy OpenWhisk
run: |
pip install couchdb
pip install 'jinja2<3.1' ansible==2.8.18
pip install pydocumentdb
- pip install humanize requests
+ pip install humanize 'requests<2.32' 'urllib3<2' 'docker>=6,<7'
Review Comment:
i upgraded OW to the latest version 2.0, fixed ansible config, and now all tests, including the integration tests are passing. ok to merge? cc: @style95
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare 3.21.9 release [openwhisk-client-js]
Posted by "selfxp (via GitHub)" <gi...@apache.org>.
selfxp commented on PR #283:
URL: https://github.com/apache/openwhisk-client-js/pull/283#issuecomment-4436062618
Integration tests are failing, not because of this PR, but because OW doesn't correctly start. Is it still ok to merge @style95?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare 3.21.9 release [openwhisk-client-js]
Posted by "style95 (via GitHub)" <gi...@apache.org>.
style95 commented on code in PR #283:
URL: https://github.com/apache/openwhisk-client-js/pull/283#discussion_r3238491321
##########
.github/workflows/ci.yaml:
##########
@@ -71,28 +71,31 @@ jobs:
uses: actions/checkout@v4
with:
repository: apache/openwhisk
+ ref: 2.0.0
path: core
- name: Install python packages needed to deploy OpenWhisk
run: |
pip install couchdb
pip install 'jinja2<3.1' ansible==2.8.18
pip install pydocumentdb
- pip install humanize requests
+ pip install humanize 'requests<2.32' 'urllib3<2' 'docker>=6,<7'
Review Comment:
Does it work if we update it to `docker>=7.1.0`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare 3.21.9 release [openwhisk-client-js]
Posted by "selfxp (via GitHub)" <gi...@apache.org>.
selfxp merged PR #283:
URL: https://github.com/apache/openwhisk-client-js/pull/283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare 3.21.9 release [openwhisk-client-js]
Posted by "selfxp (via GitHub)" <gi...@apache.org>.
selfxp commented on code in PR #283:
URL: https://github.com/apache/openwhisk-client-js/pull/283#discussion_r3244228353
##########
.github/workflows/ci.yaml:
##########
@@ -71,28 +71,41 @@ jobs:
uses: actions/checkout@v4
with:
repository: apache/openwhisk
+ ref: 2.0.0
path: core
- name: Install python packages needed to deploy OpenWhisk
run: |
- pip install couchdb
- pip install 'jinja2<3.1' ansible==2.8.18
- pip install pydocumentdb
- pip install humanize requests
+ python3 -m pip install couchdb
+ python3 -m pip install 'jinja2<3.1' ansible==2.8.18
+ python3 -m pip install pydocumentdb
+ python3 -m pip install humanize 'requests<2.32' 'urllib3<2' 'docker>=6,<7'
- name: Deploy OpenWhisk
working-directory: core/ansible
env:
ANSIBLE_CMD: "ansible-playbook -i environments/local -e docker_image_prefix=openwhisk -e docker_image_tag=nightly"
+ ANSIBLE_EXTRA_VARS: '{"scheduler_enable":false,"jmxremote_enabled":"","controller_loadbalancer_spi":"org.apache.openwhisk.core.loadBalancer.ShardingContainerPoolBalancer","invokerReactive_spi":"org.apache.openwhisk.core.invoker.InvokerReactive","invokerServer_spi":"org.apache.openwhisk.core.invoker.DefaultInvokerServer"}'
Review Comment:
In OpenWhisk 2.0.0, the docs say the old shared state model was deprecated/removed, while sharding remains available.
Had to use it here because the default `FPCPoolBalancer` path expects scheduler/etcd configuration, which is what was breaking this CI. `ShardingContainerPoolBalancer` keeps this legacy Docker-based integration test working without enabling the scheduler path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare 3.21.9 release [openwhisk-client-js]
Posted by "style95 (via GitHub)" <gi...@apache.org>.
style95 commented on code in PR #283:
URL: https://github.com/apache/openwhisk-client-js/pull/283#discussion_r3244392967
##########
.github/workflows/ci.yaml:
##########
@@ -71,28 +71,41 @@ jobs:
uses: actions/checkout@v4
with:
repository: apache/openwhisk
+ ref: 2.0.0
path: core
- name: Install python packages needed to deploy OpenWhisk
run: |
- pip install couchdb
- pip install 'jinja2<3.1' ansible==2.8.18
- pip install pydocumentdb
- pip install humanize requests
+ python3 -m pip install couchdb
+ python3 -m pip install 'jinja2<3.1' ansible==2.8.18
+ python3 -m pip install pydocumentdb
+ python3 -m pip install humanize 'requests<2.32' 'urllib3<2' 'docker>=6,<7'
- name: Deploy OpenWhisk
working-directory: core/ansible
env:
ANSIBLE_CMD: "ansible-playbook -i environments/local -e docker_image_prefix=openwhisk -e docker_image_tag=nightly"
+ ANSIBLE_EXTRA_VARS: '{"scheduler_enable":false,"jmxremote_enabled":"","controller_loadbalancer_spi":"org.apache.openwhisk.core.loadBalancer.ShardingContainerPoolBalancer","invokerReactive_spi":"org.apache.openwhisk.core.invoker.InvokerReactive","invokerServer_spi":"org.apache.openwhisk.core.invoker.DefaultInvokerServer"}'
Review Comment:
Thank you for sharing that. I have no objection to merging this.
I was just wondering what the error was when the scheduler was breaking CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org