You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/31 10:57:37 UTC

[GitHub] [arrow] mqy opened a new pull request #9058: ARROW-10996: [Rust] change return value type of `get_arrow_schema_from_metadata`

mqy opened a new pull request #9058:
URL: https://github.com/apache/arrow/pull/9058


   https://github.com/apache/arrow/pull/8936 updated crate `flatbuffers` to 0.8.0 , but function `get_arrow_schema_from_metadata` still returning `Option` rather than `Result`. This PR fixes this issue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jorgecarleitao closed pull request #9058: ARROW-10996: [Rust] [Parquet] change return value type of get_arrow_schema_from_metadata()

Posted by GitBox <gi...@apache.org>.
jorgecarleitao closed pull request #9058:
URL: https://github.com/apache/arrow/pull/9058


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mqy edited a comment on pull request #9058: ARROW-10996: [Rust] change return value type of get_arrow_schema_from_metadata()

Posted by GitBox <gi...@apache.org>.
mqy edited a comment on pull request #9058:
URL: https://github.com/apache/arrow/pull/9058#issuecomment-752993373


   @alamb thanks
   I will rebase again after https://github.com/apache/arrow/pull/9061 get merged, it has passed all checks.
   ping @Dandandan


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] alamb commented on pull request #9058: ARROW-10996: [Rust] change return value type of get_arrow_schema_from_metadata()

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9058:
URL: https://github.com/apache/arrow/pull/9058#issuecomment-752955926


   The full set of Rust CI tests did not run on this PR :(
   
   Can you please rebase this PR against [apache/master](https://github.com/apache/arrow) to pick up the changes in https://github.com/apache/arrow/pull/9056 so that they do? 
   
   I apologize for the inconvenience. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #9058: ARROW-10996: [Rust] change return value type of get_arrow_schema_from_metadata()

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9058:
URL: https://github.com/apache/arrow/pull/9058#issuecomment-752929015


   https://issues.apache.org/jira/browse/ARROW-10996


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mqy commented on a change in pull request #9058: ARROW-10996: [Rust] [Parquet] change return value type of get_arrow_schema_from_metadata()

Posted by GitBox <gi...@apache.org>.
mqy commented on a change in pull request #9058:
URL: https://github.com/apache/arrow/pull/9058#discussion_r550756009



##########
File path: rust/parquet/src/arrow/schema.rs
##########
@@ -42,14 +42,10 @@ pub fn parquet_to_arrow_schema(
     key_value_metadata: &Option<Vec<KeyValue>>,
 ) -> Result<Schema> {
     let mut metadata = parse_key_value_metadata(key_value_metadata).unwrap_or_default();
-    let maybe_schema = metadata
+    let arrow_schema_metadata = metadata
         .remove(super::ARROW_SCHEMA_META_KEY)
-        .map(|encoded| get_arrow_schema_from_metadata(&encoded));
-
-    let arrow_schema_metadata = match maybe_schema {
-        Some(v) => Some(v?),
-        _ => None,
-    };
+        .map(|encoded| get_arrow_schema_from_metadata(&encoded))
+        .map_or(Ok(None), |v| v.map(Some))?;

Review comment:
       @Dandandan thanks a lot!  The code looks more concise!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] Dandandan commented on a change in pull request #9058: ARROW-10996: [Rust] change return value type of get_arrow_schema_from_metadata()

Posted by GitBox <gi...@apache.org>.
Dandandan commented on a change in pull request #9058:
URL: https://github.com/apache/arrow/pull/9058#discussion_r550752212



##########
File path: rust/parquet/src/arrow/schema.rs
##########
@@ -42,14 +42,10 @@ pub fn parquet_to_arrow_schema(
     key_value_metadata: &Option<Vec<KeyValue>>,
 ) -> Result<Schema> {
     let mut metadata = parse_key_value_metadata(key_value_metadata).unwrap_or_default();
-    let maybe_schema = metadata
+    let arrow_schema_metadata = metadata
         .remove(super::ARROW_SCHEMA_META_KEY)
-        .map(|encoded| get_arrow_schema_from_metadata(&encoded));
-
-    let arrow_schema_metadata = match maybe_schema {
-        Some(v) => Some(v?),
-        _ => None,
-    };
+        .map(|encoded| get_arrow_schema_from_metadata(&encoded))
+        .map_or(Ok(None), |v| v.map(Some))?;

Review comment:
       I think this can use unwrap_or, as both of the cases map to Ok?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mqy commented on a change in pull request #9058: ARROW-10996: [Rust] [Parquet] change return value type of get_arrow_schema_from_metadata()

Posted by GitBox <gi...@apache.org>.
mqy commented on a change in pull request #9058:
URL: https://github.com/apache/arrow/pull/9058#discussion_r550762559



##########
File path: rust/parquet/src/arrow/schema.rs
##########
@@ -123,7 +119,7 @@ where
     let arrow_schema_metadata = metadata
         .remove(super::ARROW_SCHEMA_META_KEY)
         .map(|encoded| get_arrow_schema_from_metadata(&encoded))
-        .unwrap_or_default();
+        .map_or(Ok(None), |v| v.map(Some))?;

Review comment:
       Thanks, let me try




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mqy edited a comment on pull request #9058: ARROW-10996: [Rust] change return value type of get_arrow_schema_from_metadata()

Posted by GitBox <gi...@apache.org>.
mqy edited a comment on pull request #9058:
URL: https://github.com/apache/arrow/pull/9058#issuecomment-752993373


   @alamb thanks
   I will rebase again after https://github.com/apache/arrow/pull/9061 merged, it has passed all checks.
   ping @Dandandan


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] codecov-io edited a comment on pull request #9058: ARROW-10996: [Rust] change return value type of get_arrow_schema_from_metadata()

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9058:
URL: https://github.com/apache/arrow/pull/9058#issuecomment-753281027


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=h1) Report
   > Merging [#9058](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=desc) (1e6082c) into [master](https://codecov.io/gh/apache/arrow/commit/51672b28e97f19f70de0f0a8800c40ee9bb939d3?el=desc) (51672b2) will **increase** coverage by `0.00%`.
   > The diff coverage is `86.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9058/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #9058   +/-   ##
   =======================================
     Coverage   82.61%   82.62%           
   =======================================
     Files         202      202           
     Lines       50048    50054    +6     
   =======================================
   + Hits        41347    41355    +8     
   + Misses       8701     8699    -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/parquet/src/arrow/schema.rs](https://codecov.io/gh/apache/arrow/pull/9058/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9zY2hlbWEucnM=) | `91.02% <86.66%> (+0.40%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=footer). Last update [51672b2...1e6082c](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jorgecarleitao commented on a change in pull request #9058: ARROW-10996: [Rust] change return value type of get_arrow_schema_from_metadata()

Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on a change in pull request #9058:
URL: https://github.com/apache/arrow/pull/9058#discussion_r550747754



##########
File path: rust/parquet/src/arrow/schema.rs
##########
@@ -42,12 +42,17 @@ pub fn parquet_to_arrow_schema(
     key_value_metadata: &Option<Vec<KeyValue>>,
 ) -> Result<Schema> {
     let mut metadata = parse_key_value_metadata(key_value_metadata).unwrap_or_default();
-    let arrow_schema_metadata = metadata
+    let maybe_schema = metadata
         .remove(super::ARROW_SCHEMA_META_KEY)
         .map(|encoded| get_arrow_schema_from_metadata(&encoded));
 
+    let arrow_schema_metadata = match maybe_schema {

Review comment:
       There may be an idiom for this in rust (that I do not know).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jorgecarleitao commented on pull request #9058: ARROW-10996: [Rust] [Parquet] change return value type of get_arrow_schema_from_metadata()

Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #9058:
URL: https://github.com/apache/arrow/pull/9058#issuecomment-753322058


   Thanks a lot for helping out in the reviews, @Dandandan , much appreciated 💯 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mqy commented on pull request #9058: ARROW-10996: [Rust] [Parquet] change return value type of get_arrow_schema_from_metadata()

Posted by GitBox <gi...@apache.org>.
mqy commented on pull request #9058:
URL: https://github.com/apache/arrow/pull/9058#issuecomment-753318973


   @Dandandan @alamb Sorry, I failed to apply `unwrap_or` or something else to`parquet_to_arrow_schema_by_columns`,
   because there are two places using arrow schema (if exists), so we can't return early.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mqy commented on a change in pull request #9058: ARROW-10996: [Rust] change return value type of get_arrow_schema_from_metadata()

Posted by GitBox <gi...@apache.org>.
mqy commented on a change in pull request #9058:
URL: https://github.com/apache/arrow/pull/9058#discussion_r550750646



##########
File path: rust/parquet/src/arrow/schema.rs
##########
@@ -42,12 +42,17 @@ pub fn parquet_to_arrow_schema(
     key_value_metadata: &Option<Vec<KeyValue>>,
 ) -> Result<Schema> {
     let mut metadata = parse_key_value_metadata(key_value_metadata).unwrap_or_default();
-    let arrow_schema_metadata = metadata
+    let maybe_schema = metadata
         .remove(super::ARROW_SCHEMA_META_KEY)
         .map(|encoded| get_arrow_schema_from_metadata(&encoded));
 
+    let arrow_schema_metadata = match maybe_schema {

Review comment:
       @jorgecarleitao thank you for the tip!
   
   The codes were updated to use `map_or` for flipping `Option<Result>` to `Result<Option>`.
   BTW, I found some similar usage of `map_or` in `parquet/src/column/writer.rs` 🥇 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] Dandandan commented on a change in pull request #9058: ARROW-10996: [Rust] [Parquet] change return value type of get_arrow_schema_from_metadata()

Posted by GitBox <gi...@apache.org>.
Dandandan commented on a change in pull request #9058:
URL: https://github.com/apache/arrow/pull/9058#discussion_r550758655



##########
File path: rust/parquet/src/arrow/schema.rs
##########
@@ -123,7 +119,7 @@ where
     let arrow_schema_metadata = metadata
         .remove(super::ARROW_SCHEMA_META_KEY)
         .map(|encoded| get_arrow_schema_from_metadata(&encoded))
-        .unwrap_or_default();
+        .map_or(Ok(None), |v| v.map(Some))?;

Review comment:
       I think you can use it here to




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] codecov-io edited a comment on pull request #9058: ARROW-10996: [Rust] change return value type of get_arrow_schema_from_metadata()

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9058:
URL: https://github.com/apache/arrow/pull/9058#issuecomment-753281027


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=h1) Report
   > Merging [#9058](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=desc) (58ac5de) into [master](https://codecov.io/gh/apache/arrow/commit/51672b28e97f19f70de0f0a8800c40ee9bb939d3?el=desc) (51672b2) will **increase** coverage by `0.00%`.
   > The diff coverage is `77.77%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9058/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #9058   +/-   ##
   =======================================
     Coverage   82.61%   82.62%           
   =======================================
     Files         202      202           
     Lines       50048    50057    +9     
   =======================================
   + Hits        41347    41358   +11     
   + Misses       8701     8699    -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/parquet/src/arrow/schema.rs](https://codecov.io/gh/apache/arrow/pull/9058/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9zY2hlbWEucnM=) | `90.96% <77.77%> (+0.34%)` | :arrow_up: |
   | [rust/arrow/src/memory.rs](https://codecov.io/gh/apache/arrow/pull/9058/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvbWVtb3J5LnJz) | `98.14% <0.00%> (-1.86%)` | :arrow_down: |
   | [rust/arrow/src/ffi.rs](https://codecov.io/gh/apache/arrow/pull/9058/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvZmZpLnJz) | `70.00% <0.00%> (-0.29%)` | :arrow_down: |
   | [rust/arrow/src/array/array\_boolean.rs](https://codecov.io/gh/apache/arrow/pull/9058/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYm9vbGVhbi5ycw==) | `86.50% <0.00%> (-0.22%)` | :arrow_down: |
   | [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9058/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.24% <0.00%> (-0.20%)` | :arrow_down: |
   | [rust/arrow/src/array/array\_primitive.rs](https://codecov.io/gh/apache/arrow/pull/9058/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfcHJpbWl0aXZlLnJz) | `91.64% <0.00%> (-0.05%)` | :arrow_down: |
   | [rust/arrow/src/array/array\_list.rs](https://codecov.io/gh/apache/arrow/pull/9058/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfbGlzdC5ycw==) | `93.10% <0.00%> (-0.02%)` | :arrow_down: |
   | [rust/arrow/src/buffer.rs](https://codecov.io/gh/apache/arrow/pull/9058/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYnVmZmVyLnJz) | `98.21% <0.00%> (-0.01%)` | :arrow_down: |
   | [rust/arrow/src/array/raw\_pointer.rs](https://codecov.io/gh/apache/arrow/pull/9058/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvcmF3X3BvaW50ZXIucnM=) | `100.00% <0.00%> (ø)` | |
   | [rust/arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9058/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYmluYXJ5LnJz) | `90.61% <0.00%> (ø)` | |
   | ... and [4 more](https://codecov.io/gh/apache/arrow/pull/9058/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=footer). Last update [51672b2...58ac5de](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] Dandandan commented on pull request #9058: ARROW-10996: [Rust] [Parquet] change return value type of get_arrow_schema_from_metadata()

Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #9058:
URL: https://github.com/apache/arrow/pull/9058#issuecomment-753320835


   @mqy no problem, is a rather small style improvement anyway.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] codecov-io edited a comment on pull request #9058: ARROW-10996: [Rust] [Parquet] change return value type of get_arrow_schema_from_metadata()

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9058:
URL: https://github.com/apache/arrow/pull/9058#issuecomment-753281027


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=h1) Report
   > Merging [#9058](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=desc) (56c24ed) into [master](https://codecov.io/gh/apache/arrow/commit/51672b28e97f19f70de0f0a8800c40ee9bb939d3?el=desc) (51672b2) will **increase** coverage by `0.00%`.
   > The diff coverage is `77.77%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9058/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #9058   +/-   ##
   =======================================
     Coverage   82.61%   82.62%           
   =======================================
     Files         202      202           
     Lines       50048    50055    +7     
   =======================================
   + Hits        41347    41356    +9     
   + Misses       8701     8699    -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/parquet/src/arrow/schema.rs](https://codecov.io/gh/apache/arrow/pull/9058/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9zY2hlbWEucnM=) | `90.93% <77.77%> (+0.31%)` | :arrow_up: |
   | [rust/arrow/src/memory.rs](https://codecov.io/gh/apache/arrow/pull/9058/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvbWVtb3J5LnJz) | `98.14% <0.00%> (-1.86%)` | :arrow_down: |
   | [rust/arrow/src/ffi.rs](https://codecov.io/gh/apache/arrow/pull/9058/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvZmZpLnJz) | `70.00% <0.00%> (-0.29%)` | :arrow_down: |
   | [rust/arrow/src/array/array\_boolean.rs](https://codecov.io/gh/apache/arrow/pull/9058/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYm9vbGVhbi5ycw==) | `86.50% <0.00%> (-0.22%)` | :arrow_down: |
   | [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9058/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.24% <0.00%> (-0.20%)` | :arrow_down: |
   | [rust/arrow/src/array/array\_primitive.rs](https://codecov.io/gh/apache/arrow/pull/9058/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfcHJpbWl0aXZlLnJz) | `91.64% <0.00%> (-0.05%)` | :arrow_down: |
   | [rust/arrow/src/array/array\_list.rs](https://codecov.io/gh/apache/arrow/pull/9058/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfbGlzdC5ycw==) | `93.10% <0.00%> (-0.02%)` | :arrow_down: |
   | [rust/arrow/src/buffer.rs](https://codecov.io/gh/apache/arrow/pull/9058/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYnVmZmVyLnJz) | `98.21% <0.00%> (-0.01%)` | :arrow_down: |
   | [rust/arrow/src/array/raw\_pointer.rs](https://codecov.io/gh/apache/arrow/pull/9058/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvcmF3X3BvaW50ZXIucnM=) | `100.00% <0.00%> (ø)` | |
   | [rust/arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9058/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYmluYXJ5LnJz) | `90.61% <0.00%> (ø)` | |
   | ... and [4 more](https://codecov.io/gh/apache/arrow/pull/9058/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=footer). Last update [51672b2...56c24ed](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mqy commented on pull request #9058: ARROW-10996: [Rust] change return value type of get_arrow_schema_from_metadata()

Posted by GitBox <gi...@apache.org>.
mqy commented on pull request #9058:
URL: https://github.com/apache/arrow/pull/9058#issuecomment-752993373


   @nevi-me rebased


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] codecov-io commented on pull request #9058: ARROW-10996: [Rust] change return value type of get_arrow_schema_from_metadata()

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9058:
URL: https://github.com/apache/arrow/pull/9058#issuecomment-753281027


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=h1) Report
   > Merging [#9058](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=desc) (c904ee9) into [master](https://codecov.io/gh/apache/arrow/commit/51672b28e97f19f70de0f0a8800c40ee9bb939d3?el=desc) (51672b2) will **increase** coverage by `0.00%`.
   > The diff coverage is `81.81%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9058/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #9058   +/-   ##
   =======================================
     Coverage   82.61%   82.61%           
   =======================================
     Files         202      202           
     Lines       50048    50051    +3     
   =======================================
   + Hits        41347    41351    +4     
   + Misses       8701     8700    -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/parquet/src/arrow/schema.rs](https://codecov.io/gh/apache/arrow/pull/9058/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9zY2hlbWEucnM=) | `90.98% <81.81%> (+0.36%)` | :arrow_up: |
   | [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9058/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.24% <0.00%> (-0.20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=footer). Last update [51672b2...1e6082c](https://codecov.io/gh/apache/arrow/pull/9058?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org