You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "oscerd (via GitHub)" <gi...@apache.org> on 2026/08/28 04:32:37 UTC
[PR] CAMEL-24526: camel-djl - reject the zoo tabular applications instead of returning no-op predictors [camel]
oscerd opened a new pull request, #25849:
URL: https://github.com/apache/camel/pull/25849
## Issue
[CAMEL-24526](https://issues.apache.org/jira/browse/CAMEL-24526)
## Problem
`ZooLinearRegressionPredictor` and `ZooSoftmaxRegressionPredictor` were empty stubs:
```java
@Override
public void process(Exchange exchange) throws Exception {
// TODO: impl
}
```
`ModelPredictorProducer.getZooPredictor()` routes `djl:tabular/linear_regression` and
`djl:tabular/softmax_regression` (in zoo mode) to these classes, so the producer did **nothing** and
the exchange body was passed through unchanged — the input was silently returned as if it were the
model's prediction. This is a silent wrong-result bug: a route appears to run a regression but never
does.
## Why not just implement them?
The DJL model zoo publishes **no** tabular regression models — the test class documents exactly this
(`ModelPredictorProducerTest` lines 92–93: *"No builtin zoo model available for tabular/linear_regression / softmax_regression"*),
consistent with the other applications that have no downloadable artifact. Unlike CV (`Image` →
`Classifications`) or NLP (`String` → …), a tabular model has no fixed input/output type pair and DJL
provides no generic tabular `Translator`; those types are specific to the user's data. There is
therefore nothing generic a zoo predictor could load or translate. The supported way to run a tabular
model is the **custom** variant (`CustomTabularPredictor`), where the user supplies their own `Model`
and `Translator` via the registry.
## Fix
- Remove the two no-op stub classes.
- `getZooPredictor()` now throws a clear `RuntimeCamelException` for the tabular applications,
telling the user to provide their own model and translator and use the custom predictor instead —
a loud, actionable failure instead of a silently wrong result.
- Add `testGetZooPredictorRejectsTabularApplications` covering both applications.
The custom tabular path (`CustomTabularPredictor`) is unchanged and still fully supported.
## Testing
- `mvn -pl components/camel-ai/camel-djl test` (new test green; existing tests unaffected).
- `mvn -Psourcecheck validate` green (formatter + impsort).
_Claude Code on behalf of oscerd_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24526: camel-djl - reject the zoo tabular applications instead of returning no-op predictors [camel]
Posted by "Croway (via GitHub)" <gi...@apache.org>.
Croway merged PR #25849:
URL: https://github.com/apache/camel/pull/25849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24526: camel-djl - reject the zoo tabular applications instead of returning no-op predictors [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25849:
URL: https://github.com/apache/camel/pull/25849#issuecomment-5448654398
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `components/camel-ai/camel-djl`
---
<details><summary>:microscope: Scalpel shadow comparison — Scalpel: 9 tested, 28 compile-only — current: 9 all tested</summary>
[Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **37 affected modules** (current approach: 9).
<details><summary>:warning: Modules only in Scalpel (28)</summary>
- `apache-camel`
- `camel-allcomponents`
- `camel-catalog`
- `camel-catalog-console`
- `camel-catalog-maven`
- `camel-catalog-suggest`
- `camel-componentdsl`
- `camel-csimple-maven-plugin`
- `camel-endpointdsl`
- `camel-endpointdsl-support`
- `camel-itest`
- `camel-jbang-core`
- `camel-jbang-it`
- `camel-jbang-main`
- `camel-jbang-plugin-edit`
- `camel-jbang-plugin-generate`
- `camel-jbang-plugin-kubernetes`
- `camel-jbang-plugin-test`
- `camel-kamelet-main`
- `camel-launcher`
- `camel-report-maven-plugin`
- `camel-route-parser`
- `camel-yaml-dsl`
- `camel-yaml-dsl-deserializers`
- `camel-yaml-dsl-maven-plugin`
- `coverage`
- `docs`
- `dummy-component`
</details>
**Skip-tests mode would test 9 modules** (1 direct + 8 downstream), **skip tests for 28** (generated code, meta-modules)
<details><summary>Modules Scalpel would test (9)</summary>
- `camel-djl`
- `camel-jbang-mcp`
- `camel-jbang-plugin-mcp`
- `camel-jbang-plugin-route-parser`
- `camel-jbang-plugin-tui`
- `camel-jbang-plugin-validate`
- `camel-launcher-container`
- `camel-yaml-dsl-validator`
- `camel-yaml-dsl-validator-maven-plugin`
</details>
<details><summary>Modules with tests skipped (28)</summary>
- `apache-camel`
- `camel-allcomponents`
- `camel-catalog`
- `camel-catalog-console`
- `camel-catalog-maven`
- `camel-catalog-suggest`
- `camel-componentdsl`
- `camel-csimple-maven-plugin`
- `camel-endpointdsl`
- `camel-endpointdsl-support`
- `camel-itest`
- `camel-jbang-core`
- `camel-jbang-it`
- `camel-jbang-main`
- `camel-jbang-plugin-edit`
- `camel-jbang-plugin-generate`
- `camel-jbang-plugin-kubernetes`
- `camel-jbang-plugin-test`
- `camel-kamelet-main`
- `camel-launcher`
- `camel-report-maven-plugin`
- `camel-route-parser`
- `camel-yaml-dsl`
- `camel-yaml-dsl-deserializers`
- `camel-yaml-dsl-maven-plugin`
- `coverage`
- `docs`
- `dummy-component`
</details>
> :information_source: Shadow mode — Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
</details>
:warning: **Some tests are disabled on GitHub Actions** (`@DisabledIfSystemProperty(named = "ci.env.name")`) and require manual verification:
- `components/camel-ai/camel-djl`: 1 test(s) disabled on GitHub Actions
<details><summary>All tested modules (37 modules)</summary>
- Camel :: AI :: Deep Java Library
- Camel :: All Components Sync point
- Camel :: Assembly
- Camel :: Catalog :: CSimple Maven Plugin (deprecated)
- Camel :: Catalog :: Camel Catalog
- Camel :: Catalog :: Camel Report Maven Plugin
- Camel :: Catalog :: Camel Route Parser
- Camel :: Catalog :: Console
- Camel :: Catalog :: Dummy Component
- Camel :: Catalog :: Maven
- Camel :: Catalog :: Suggest
- Camel :: Component DSL
- Camel :: Coverage
- Camel :: Docs
- Camel :: Endpoint DSL
- Camel :: Endpoint DSL :: Support
- Camel :: Integration Tests
- Camel :: JBang :: Core
- Camel :: JBang :: Integration tests
- Camel :: JBang :: MCP
- Camel :: JBang :: Main
- Camel :: JBang :: Plugin :: Edit
- Camel :: JBang :: Plugin :: Generate
- Camel :: JBang :: Plugin :: Kubernetes
- Camel :: JBang :: Plugin :: MCP
- Camel :: JBang :: Plugin :: Route Parser
- Camel :: JBang :: Plugin :: TUI
- Camel :: JBang :: Plugin :: Testing
- Camel :: JBang :: Plugin :: Validate
- Camel :: Kamelet Main
- Camel :: Launcher
- Camel :: Launcher :: Container
- Camel :: YAML DSL
- Camel :: YAML DSL :: Deserializers
- Camel :: YAML DSL :: Maven Plugins
- Camel :: YAML DSL :: Validator
- Camel :: YAML DSL :: Validator Maven Plugin
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/33142112130)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24526: camel-djl - reject the zoo tabular applications instead of returning no-op predictors [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25849:
URL: https://github.com/apache/camel/pull/25849#issuecomment-5448472059
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org