[GitHub] spark pull request: [SPARK-10180] [SQL] JDBCRDD does not process E...

[rxin <gi...@git.apache.org>]

Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8391#discussion_r38473825
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala ---
    @@ -275,6 +275,10 @@ private[sql] class JDBCRDD(
        */
       private def compileFilter(f: Filter): String = f match {
         case EqualTo(attr, value) => s"$attr = ${compileValue(value)}"
    +    // Since the null-safe equality operator is not a standard SQL operator,
    +    // This was written as using is-null and normal equality.
    +    case EqualNullSafe(attr, value) =>
    +      s"($attr = ${compileValue(value)} OR ($attr IS NULL AND ${compileValue(value)} IS NULL))"
    --- End diff --
    
    could this be null if attr is null but value is not null?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org