You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@answer.apache.org by "culfin (via GitHub)" <gi...@apache.org> on 2026/08/24 03:32:39 UTC
[PR] fix(template): translate the search placeholder in the server-rendered header [answer]
culfin opened a new pull request, #1585:
URL: https://github.com/apache/answer/pull/1585
`ui/template/header.html` writes the placeholder literally:
```html
<input placeholder="Search" name="q" type="search" class="placeholder-search form-control" value="">
```
Every other string in that file goes through `translator`, and the key for this
one already exists — `ui.header.search.placeholder`, present in all 45 language
files under `i18n/`. The React interface uses it; only the template does not.
The result is one English word in the middle of an otherwise translated page.
Two audiences see it: readers, until the interface takes over, and search
engines, which see nothing else.
```html
<input placeholder="{{translator $.language "ui.header.search.placeholder"}}" …>
```
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@answer.apache.org
For additional commands, e-mail: issues-help@answer.apache.org
Re: [PR] fix(template): translate the search placeholder in the server-rendered header [answer]
Posted by "culfin (via GitHub)" <gi...@apache.org>.
culfin closed pull request #1585: fix(template): translate the search placeholder in the server-rendered header
URL: https://github.com/apache/answer/pull/1585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@answer.apache.org
For additional commands, e-mail: issues-help@answer.apache.org
Re: [PR] fix(template): translate the search placeholder in the server-rendered header [answer]
Posted by "culfin (via GitHub)" <gi...@apache.org>.
culfin commented on PR #1585:
URL: https://github.com/apache/answer/pull/1585#issuecomment-5399282919
Folded into #1592 together with the other three defects in `ui/template/` — one pull request is easier to review than four, and none of them is more than a line or two. Nothing is dropped, and the new one also targets `dev` as requested in #1572. Closing to keep the queue readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@answer.apache.org
For additional commands, e-mail: issues-help@answer.apache.org